* [PATCH] mempool: enable code to be compiled with MSVC compiler
@ 2024-11-13 1:24 Andre Muezerie
2024-11-13 3:08 ` Morten Brørup
0 siblings, 1 reply; 3+ messages in thread
From: Andre Muezerie @ 2024-11-13 1:24 UTC (permalink / raw)
To: Andrew Rybchenko, Morten Brørup; +Cc: dev, Andre Muezerie
The issues that were preventing mempool from getting compiled with
MSVC were fixed, so now it should not be excluded from the
build anymore.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
lib/mempool/meson.build | 6 ------
1 file changed, 6 deletions(-)
diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build
index acce66cb97..8099a56466 100644
--- a/lib/mempool/meson.build
+++ b/lib/mempool/meson.build
@@ -1,12 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-if is_ms_compiler
- build = false
- reason = 'not supported building with Visual Studio Toolset'
- subdir_done()
-endif
-
extra_flags = []
foreach flag: extra_flags
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mempool: enable code to be compiled with MSVC compiler
2024-11-13 1:24 [PATCH] mempool: enable code to be compiled with MSVC compiler Andre Muezerie
@ 2024-11-13 3:08 ` Morten Brørup
2024-11-13 6:38 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Morten Brørup @ 2024-11-13 3:08 UTC (permalink / raw)
To: Andre Muezerie, Andrew Rybchenko; +Cc: dev
> From: Andre Muezerie [mailto:andremue@linux.microsoft.com]
> Sent: Wednesday, 13 November 2024 02.25
>
> The issues that were preventing mempool from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> build anymore.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mempool: enable code to be compiled with MSVC compiler
2024-11-13 3:08 ` Morten Brørup
@ 2024-11-13 6:38 ` Andrew Rybchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2024-11-13 6:38 UTC (permalink / raw)
To: Morten Brørup, Andre Muezerie; +Cc: dev
On 11/13/24 06:08, Morten Brørup wrote:
>> From: Andre Muezerie [mailto:andremue@linux.microsoft.com]
>> Sent: Wednesday, 13 November 2024 02.25
>>
>> The issues that were preventing mempool from getting compiled with
>> MSVC were fixed, so now it should not be excluded from the
>> build anymore.
>>
>> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>> ---
>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-13 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-13 1:24 [PATCH] mempool: enable code to be compiled with MSVC compiler Andre Muezerie
2024-11-13 3:08 ` Morten Brørup
2024-11-13 6:38 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).