From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8B3F4318D; Tue, 17 Oct 2023 16:27:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A32040273; Tue, 17 Oct 2023 16:27:12 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2052.outbound.protection.outlook.com [40.107.101.52]) by mails.dpdk.org (Postfix) with ESMTP id B80B540270 for ; Tue, 17 Oct 2023 16:27:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8BeJTtpUXEmEu2TiuJc9a17uvzKBG6D17/mwEbn5f3gc7P5tAOry3SptPwaVNPIB//DiD5sWIhxOo/j5xaktHYSwGuFptP7hbbwvw8KoY0+V7EgVel5KrpoRvyD1VDV3loQJI1G5wTlnHEJ0kJfps3PdLyDaVIS++ZhQfplwwvkC4mdyZk0ebJ2uYpv5EqfXLWzInyjwz7f/MO9Rm/FFCkrtP9KsnG7Fz6PIA4pdWNV+htTEw7IsI8xk/skuDKZy9CjKn8u/Z8cgFmFnqx2s6QJkMxUCXKhTRlDJwf5tnepJ+xnibnnKdayuypOK3BVw3jtrmlMb3MAWlavM1aQRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=565wgn6xf45oxaQUrHIUNBOgk3luRV30pIbjR7jm09Q=; b=SR2tj7gruVsRk7rkILy9VJyKQqip/HYHnKenuwzzhFa1M+oigx83kIW+/r+JsUkA37L3wQZZoTvHm2l8p8zYyQ4rleb5MU2uDs52yElmxSsEM29TCFxL5HS0Ku5BNNt4xKspzevcTRUJU3rg6pr6sODwbkgDDNC1ySrB/J/yHiO0MxxPM+ym4vJhJUC1ywl1TZZcRAIeKQZdMrob1Iv2+4FlHhYyJhcbMd5o28mQkOWcy3/FQBBLHcs249tpzRiN5REI1HqUGC55n6DS5ujMVSkOgmpR/lJAnMDMkHHFzJTN3+M4PbSsVup+KbOnGLaJqxGOKQh/FzHL8og+5A0baA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=565wgn6xf45oxaQUrHIUNBOgk3luRV30pIbjR7jm09Q=; b=pU0BL/16ltGxO7k/FiQsV1ux1D1TyVFvaHfg8JYtTx0VfTCboiz1ctjzWuitsODOnvka85930S0HRPukKsw2pP7LJ8ApfYwWT7AqH35JTfQhYTP+W4oasby/f1Jw+dZq2G2MOa2a3W4SXb8iNSrMAja4rv/iYepZfM7RlV58nag= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6548.namprd12.prod.outlook.com (2603:10b6:208:38f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 14:27:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Tue, 17 Oct 2023 14:27:07 +0000 Message-ID: <2c1c2b20-f7ab-4189-8f04-746edf19f1b4@amd.com> Date: Tue, 17 Oct 2023 15:26:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/40] support setting and querying RSS algorithms Content-Language: en-US To: Thomas Monjalon , Jie Hai Cc: dev@dpdk.org, lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com, stephen@networkplumber.org References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <10678182.aFP6jjVeTY@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <10678182.aFP6jjVeTY@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0401.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6548:EE_ X-MS-Office365-Filtering-Correlation-Id: ca855b62-2cd3-4364-d724-08dbcf1d2413 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k6FHs6018fxJ/KhBc3mpXg1zbDL3ex5vA4KB9AmrFiTV9EAOrgXpTu2KyWf9Z+M2r9hKtQalgHQpu7QFRQHC6eo/2l4RzZ8LdlVq8RS9dJF/4kCOiZlq7MUeixCH75ytHiyE6MyxXvN/U6Wd6v4RwmNMsBx82Q9Fy+Lh2CqL1RLmv1pLnpM15ZDI03Xv3E9KAFbKB19LAzlxm8JH3ZB62AgqOkEOBajSYEnze23oX4rC1NKd1S0VJXzMtc86ACsP8vpOIP9sAdf2Sfaie+p8TwuDkQ7LamMpd0MQ1yq+8pCLpLdXSUZJANhI0S6EUI7u2XbceU9DlFlSmupSWE9fL4aJkkQMCiEgIRNLwG6rykEnLn1qPcWHUI8OrKveCUqCdhBd0wFhFoj0m32f1ZdFSwilGAk0KLVvZ9M7qzWt6NHe5e5bFNsZJmKq1n37TQfQFETT9QUBWDxVo51ZnsgIbQ/I46dgJm5nDmtcCtosOeQrXTk3qzJYayC/XurRaZv2n8UBRvACuM+XXjrI+nW/3/7DlU91M+ie04kLwJTZ+JsMnrNEj9re6A18oodyRhlxVO10SkGSneSSvVpNpSuZLNt7SRtRcLpYltMCbK9qFTufoMvTIgPMZjG0C2yRcaNSHWJWgUcfEoJgcfFlJ1ijoA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(136003)(366004)(39860400002)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(4326008)(2616005)(66556008)(66476007)(66946007)(26005)(316002)(110136005)(6666004)(6486002)(6506007)(478600001)(6512007)(53546011)(5660300002)(41300700001)(44832011)(86362001)(31696002)(2906002)(83380400001)(8676002)(8936002)(38100700002)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUdyQUlUaCtHS2Y1eXAxR252WmZpdzR3TSthZ2EvZVRMTURGRGJhZ0VFQ2xL?= =?utf-8?B?aXJBTzFuTTFyVEtESGowcDlOTHBvOWFjQVhNajk5Wit5ZjQ4ZTlVVkI4YmV5?= =?utf-8?B?Ri84VWpiVGhQZWg0Si9XbjVaMGwwOE0ySFpaZ2RCR2hMckt5aDBiRHM0S1RJ?= =?utf-8?B?RTBsZ1pZTzBhS0EzcHMwQzBwdk14VVh6WFZSVWlzVTAzd1k1bm9CRVhudTRB?= =?utf-8?B?MGdQQjlOOFBURTNxT3pQZnhQQ0F3UzJYQ3lYS2tIcnBrQ0xTR3BEd1h1dXZ3?= =?utf-8?B?TGtpait5TnFFb2pXUTNMU3FTYzRldjFQSTlLR3N4T0lXcWpzOXFjUE1kdWdj?= =?utf-8?B?SFRTbTEzVlptd2U1R2VBUGpWckd2d1U0VG8xUlFLZWtDemF2YjJ6MWZ3cStr?= =?utf-8?B?L2ZOTDUvSmV0NURKTkNXMjllVlJObHFzbWErMGZYOUZPWElTZ3BJV0VCKzBM?= =?utf-8?B?bjFEdGtzWWxQODN6d0c5NUQ4VDNFbGc5ZGFTTmFDRW9mZU9vcDltb1llOW5l?= =?utf-8?B?YjdmajFNSFVTU1hsczQvWjJPbW9zUTZ3c3c0dXh1MFNBUHVmREpGdHdJUTdB?= =?utf-8?B?SWZqemNCbjVHV0g4ME8xZ05SUWRZcktFekNSaVk0UjZkc214L2NxOXpvVGhV?= =?utf-8?B?OU5RdnE0UjhtM1UvUjh5aGJ1THdHNE84eEJkMXVBZ3hsVFFqVkZldkl0bFFm?= =?utf-8?B?SEZ2V1E1elhkOGtmMTNrSUFlQlRPRXhwMnh5dk9WbWQ3N3BrYncrUm1lZzRR?= =?utf-8?B?QUNwR1NMblZDeEkwWWxnamowOTJ3QzRlWFl4ODB2T1d1eHZCWkg0dGZtSTRa?= =?utf-8?B?M2ZrZXd5eHljdW5ROERadHVxYXdYNTQzYnZuUkdKUGRxK1N2RDZyUmhjNmZ4?= =?utf-8?B?eVlkMkx0bUdJbGxnSmxwcFpEbzdtR1A0eFJ3V1ExeGVpR1plUDJ3VTRHelFD?= =?utf-8?B?S3ljeStFYzhKaWpQdWpBaUZoeHpZbVpWUEYyYk5SeVVXMnZNMFlpUjlvU1l1?= =?utf-8?B?dUVXeHJOMjlpK0pyVE96eGVrdUJUYU51VTQwOGkxSGxNU1dXMldYNW5ObmtW?= =?utf-8?B?ZkI4aWpUN3FnbXN5WDU3eGNJdlFnQ2J6WGxzR1cxWU9qd21vOFJnck9TTTB1?= =?utf-8?B?eTdlTWNZeFFLZHZTVm1EUWhSSGdjdWlhNkNDS3c5MXZoZGFpeGp2dkt3OXlW?= =?utf-8?B?S1cxU2RXSjRhRkMzSE45MmFmWGd6bXNiUERtd1JPUHAvMjJXWWNCaStqZE9I?= =?utf-8?B?QmRtbVZncWFoRi9Dd2M2OHMrWDdMei9qMUhHVjZQeFBXOVBiQUVhUGpJeFlF?= =?utf-8?B?N1kycWpRQjRDRitXeXo3YkphWGpyMUd4K0hzY1A0c1JsM2ptM0JxUDFEZ0hp?= =?utf-8?B?V09Cck5oZlVXRmVxbGpiOTNUS09LNzhrZUM2dUxqYm83bWs4Vnh0MExWUzI0?= =?utf-8?B?UVlMUVFyVkF2SGR5eWhJYi9uVEJYNHdydExudmZYbkxBdHlHU3Q5T3VRc2wz?= =?utf-8?B?SkdaZTNCNEtNZ1pkcFFSbEtZTkJLQzRiU080MVlnSnU1d0RqanFrVTd4ZVFx?= =?utf-8?B?YUtyN0cyMDJuczNqcHNpMzlUUnRpc3cvVXhRZ05zNVdIRm5FRXMvY3RnV2lw?= =?utf-8?B?SUk3SWhYK255NDJTY0ZuQW9tRUdacnlYMTBCZWxoc1VGeWp5Qi9ZM2x1bE9a?= =?utf-8?B?RkYybS8yL0tlQ0ZhUkxGRU56aDVqMXBVdkN3TzlJd1lXdWZPVzNNTWRvOXBH?= =?utf-8?B?MVJPbDZxZlNQOXQ3OWVvRitkeG8vZ0Z3M1hoZUYxdFo2eE1vV0NxcGQwQWNk?= =?utf-8?B?M3BuNUV0T2JDNXdwbU5UcTlzdGQ3eHFpMjZaTUpERUJVU0ZHUWQvcitHTjcx?= =?utf-8?B?d25ISjduY0Z6azRtR0N6Y0tFQStiTmdRSldYTjRSTGxsY3M4MTk0c0FHTURK?= =?utf-8?B?WG54bkdvMmFLWnZKMURwODdDQXFZLzF5d1JlMGxXMzk3MW16djB1WmNyVzd0?= =?utf-8?B?NEpRcXB1OUJOa0hQOHVzeUx2UWd1aUdzVjBHQVNVOWI4RXBJdTFtSkUvaVBP?= =?utf-8?B?Q3A3TG5PaEdlUjJZTzQxVmJCblR5SkFYTlY2c0xuQUJOU3lJNXBhM3VUbmhm?= =?utf-8?Q?kdMQkzWoso0miSwJ5ZAUA9Sdy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca855b62-2cd3-4364-d724-08dbcf1d2413 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:27:07.1529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +jq7EXzYE12dhLEvTF8KapCUZAF0b0YJNH42c3aFRVgt4haaHvt70qkZ/P7aYBkG X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6548 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/17/2023 3:06 PM, Thomas Monjalon wrote: > Hello, > > 11/10/2023 11:27, Jie Hai: >> app/proc-info/main.c | 32 ++++++++++----- >> app/test-pmd/cmdline.c | 29 ++++++++++--- >> app/test-pmd/config.c | 38 ++++++++--------- >> app/test-pmd/testpmd.h | 2 +- >> doc/guides/rel_notes/release_23_11.rst | 2 + >> drivers/net/atlantic/atl_ethdev.c | 2 + >> drivers/net/axgbe/axgbe_ethdev.c | 9 +++++ >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++ >> drivers/net/bnxt/bnxt_ethdev.c | 6 +++ >> drivers/net/bonding/rte_eth_bond_pmd.c | 6 +++ >> drivers/net/cnxk/cnxk_ethdev.c | 5 +++ >> drivers/net/cnxk/cnxk_ethdev_ops.c | 3 ++ >> drivers/net/cpfl/cpfl_ethdev.c | 6 +++ >> drivers/net/cxgbe/cxgbe_ethdev.c | 9 ++++- >> drivers/net/dpaa/dpaa_ethdev.c | 7 ++++ >> drivers/net/dpaa2/dpaa2_ethdev.c | 7 ++++ >> drivers/net/ena/ena_rss.c | 3 ++ >> drivers/net/enic/enic_ethdev.c | 1 + >> drivers/net/enic/enic_main.c | 3 ++ >> drivers/net/fm10k/fm10k_ethdev.c | 9 ++++- >> drivers/net/hinic/hinic_pmd_ethdev.c | 3 ++ >> drivers/net/hinic/hinic_pmd_rx.c | 3 ++ >> drivers/net/hns3/hns3_rss.c | 47 ++++++++++++--------- >> drivers/net/i40e/i40e_ethdev.c | 7 ++++ >> drivers/net/iavf/iavf_ethdev.c | 6 +++ >> drivers/net/ice/ice_dcf.c | 3 ++ >> drivers/net/ice/ice_dcf_ethdev.c | 3 ++ >> drivers/net/ice/ice_ethdev.c | 7 ++++ >> drivers/net/idpf/idpf_ethdev.c | 6 +++ >> drivers/net/igc/igc_ethdev.c | 4 ++ >> drivers/net/igc/igc_txrx.c | 5 +++ >> drivers/net/ionic/ionic_ethdev.c | 6 +++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++- >> drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++ >> drivers/net/mana/mana.c | 11 ++++- >> drivers/net/mlx5/mlx5_ethdev.c | 4 ++ >> drivers/net/mlx5/mlx5_rss.c | 3 +- >> drivers/net/mvpp2/mrvl_ethdev.c | 3 ++ >> drivers/net/netvsc/hn_ethdev.c | 6 +++ >> drivers/net/nfp/nfp_common.c | 9 ++++- >> drivers/net/ngbe/ngbe_ethdev.c | 6 ++- >> drivers/net/ngbe/ngbe_rxtx.c | 3 ++ >> drivers/net/null/rte_eth_null.c | 8 ++++ >> drivers/net/qede/qede_ethdev.c | 9 ++++- >> drivers/net/sfc/sfc_ethdev.c | 3 ++ >> drivers/net/sfc/sfc_rx.c | 3 ++ >> drivers/net/tap/rte_eth_tap.c | 8 ++++ >> drivers/net/thunderx/nicvf_ethdev.c | 10 ++++- >> drivers/net/txgbe/txgbe_ethdev.c | 7 +++- >> drivers/net/txgbe/txgbe_ethdev_vf.c | 7 +++- >> drivers/net/txgbe/txgbe_rxtx.c | 3 ++ >> lib/ethdev/rte_ethdev.c | 17 ++++++++ >> lib/ethdev/rte_ethdev.h | 56 +++++++++++++++++++------- >> lib/ethdev/rte_flow.c | 1 - >> lib/ethdev/rte_flow.h | 25 +----------- >> 55 files changed, 395 insertions(+), 106 deletions(-) > > Changing all drivers is suspicious. > It shows that something is missing in ethdev. > Please can you add the checks in ethdev only? > That is kind of request from me, let me try to summarize what is going on, there is a new config item added to "struct rte_eth_rss_conf" introduced in this set, which is RSS hashing algorithm to use. Problem is none of the existing drivers are taking account this new config item, so application will request it but drivers silently ignore it. This is a generic problem when adding a new config item to existing config struct. So my request was if drivers not supporting it, and it is requested by the application, driver should return an error to let application know that it is not supported, that is why bunch of drivers updated. One option can be adding a new, specific API and dev_ops for this, for this case new config item is related to the existing RSS API, so I think it can be part of the existing API. Other can be to have some kind of capability reporting by drivers, and application will detect it and won't request this new config item, I think Stephen already suggested something like this. This capability flag is again a generic requirement, and `rte_eth_dev_info_get()` partially used for this purpose. I think it will be odd from application perspective to have a capability for just one config item of a feature set. Anyway, I think updating drivers to report they are not supporting new config item is best option to me, but also I think we should discuss this capability reporting in ethdev in a wider context.