From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBECCA00C3; Tue, 1 Feb 2022 12:29:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46F3140698; Tue, 1 Feb 2022 12:29:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CFC0A40691 for ; Tue, 1 Feb 2022 12:29:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643714972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhUAQwLyBJmKG0+rmcKdtS/IB5Q8Nc9JRSmtRFAKUvc=; b=X6QvOZrS3ztEqZZeZzejhg4rdiTQ7uNKyAFkhSBAxO3YvIJUYPnJ/zExOk84EVP3WMUFd2 bVGsVpgIyXJmRKrkUbs16yZNxq8+Q/0xmS/TJb/de08yJUGbt84Ny5txTEhzPwtqx6sq9K PN6szdL2oax9BJg7Fy94vedSw5R+4fw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-0N6oV7ZCNzitGj8w1wWF0g-1; Tue, 01 Feb 2022 06:29:31 -0500 X-MC-Unique: 0N6oV7ZCNzitGj8w1wWF0g-1 Received: by mail-wr1-f72.google.com with SMTP id r27-20020adfb1db000000b001d7567e33baso5864147wra.12 for ; Tue, 01 Feb 2022 03:29:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=xhUAQwLyBJmKG0+rmcKdtS/IB5Q8Nc9JRSmtRFAKUvc=; b=Slc75M7vkGL5s7gtcLR85fvhvM5SUyIFn5xzipr0PG1MQQ9X9I3poP3oiin9xs3tIU 1nhuN/V3JoUfNSHiBC9tw9805p4ZPhDBBxtYPrjPuzJot4KO1EIzy8Lx2H+lL6FpBVeL qierXtuKyW/bBVedvMe5mQxRZMEzTApIWtcxeE9KXvgXRCWV/dFoSm1M1g/4o8iXR8oz OKCP5hHKY7fdQ3Fz6HpIXwgcuwbWV8gGjbUtz8T0MVwKF8DqAa6Nd4psA8o4CJmD/U1U HOxVXySo4vUQtoGsMYA3ihwoE7345xFGVZAvAjuELxw10SnZeFC4lg9rAx2p5Gc6J602 8R0A== X-Gm-Message-State: AOAM531DYxOT8O14oXB6QOJxOoN4MmNSoe2R1m+I2GwqekD3H2J9Q2So Qf8UMxW/U8cUiTe4GiJw7LeJjzbKJdoU0SWhUOGKw+BYG8FVNNxuB9kt6GJM3mwjAX7GblDh0KH RV9M= X-Received: by 2002:a5d:6c64:: with SMTP id r4mr21323065wrz.659.1643714970117; Tue, 01 Feb 2022 03:29:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfi2jhNybYveTbx10JY9nAQ9x0pHHo0tJzc2Nb/y3VZYG5qcYqpM9UH6hOe7bksHaQ94fiaQ== X-Received: by 2002:a5d:6c64:: with SMTP id r4mr21323055wrz.659.1643714969941; Tue, 01 Feb 2022 03:29:29 -0800 (PST) Received: from [192.168.0.36] ([78.16.129.141]) by smtp.gmail.com with ESMTPSA id a26sm2023811wmj.18.2022.02.01.03.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 03:29:29 -0800 (PST) Message-ID: <2c4069f6-ea11-aebc-dc17-5c49ce6cf19c@redhat.com> Date: Tue, 1 Feb 2022 11:29:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Maxime Coquelin , xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yuanx.wang@intel.com References: <20220119151016.9970-1-xuan.ding@intel.com> <2d2831bd-0a8c-2684-118d-37e45fd87994@redhat.com> From: Kevin Traynor Subject: Re: [PATCH v2 0/2] vhost: fix async address mapping In-Reply-To: <2d2831bd-0a8c-2684-118d-37e45fd87994@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 01/02/2022 08:28, Maxime Coquelin wrote: > > > On 1/19/22 16:10, xuan.ding@intel.com wrote: >> From: Xuan Ding >> >> This patchset fixes the issue of incorrect DMA mapping in PA mode. >> Due to the ambiguity of host_phys_addr naming in the guest page >> struct, rename it to host_iova. >> >> v2: >> * Change the order of patch. > > I'm not sure why you changed the order of the patches. > Now, the second one is the fix, so it will make the backport more > difficult. Either both are considered to be fixes. I think it can make > sense as the renaming does not introduce risk of regression and will > make backporting patches easier in the future. > > Other solution is to reverse the order again, but I think tagging the > renaming as a fix is OK for me here. > > What do you think? > Either way sounds ok to me, but can you also add stable tag(s). There isn't a stable tag on either patch at present. Thanks. > Regards, > Maxime > >> >> Xuan Ding (2): >> vhost: rename field in guest page struct >> vhost: fix physical address mapping >> >> lib/vhost/vhost.h | 11 ++-- >> lib/vhost/vhost_user.c | 130 ++++++++++++++++++++--------------------- >> lib/vhost/virtio_net.c | 11 ++-- >> 3 files changed, 75 insertions(+), 77 deletions(-) >> >