DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build
Date: Wed, 13 Oct 2021 23:02:22 +0100
Message-ID: <2c4452de-863a-eb61-a816-677781c3e486@intel.com> (raw)
In-Reply-To: <CACZ4nhuN0FORvF1GGqwggRSHjht7r-HWYaqsKCsqG7asDgi44A@mail.gmail.com>

On 10/13/2021 10:35 PM, Ajit Khaparde wrote:
> On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> On 10/13/2021 6:34 PM, Ajit Khaparde wrote:
>>> On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error,
>>>> removing it.
>>>> Also with meson build system compile time debug macros should be
>>>> documented in driver documentation, since there is not other way to
>>> s/not/no
>>>> figure out their existence.
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> With thanks and above nit, :-)
>>> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>> Other option is to fix the build error when macro is set, would you like
>> to go with that option?
> No.  There is more that we would like to add if we want to add debug capability.
> Currently what you are trying to remove is a bit half baked which
> should not have sneaked in.
> So removing it for now is perfectly fine.


>> And can you please send a separate patch to document the remaining
>> compile time macros in the driver guide?
> Sure. I will go through the code and take care of that.

I recognized that no more debug macro left after patch, so nothing to

btw, '-DRTE_LIBRTE_BNXT_TF' in the meson seems not used at all.

  reply	other threads:[~2021-10-13 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 16:31 Ferruh Yigit
2021-10-13 17:34 ` Ajit Khaparde
2021-10-13 19:23   ` Ferruh Yigit
2021-10-13 21:35     ` Ajit Khaparde
2021-10-13 22:02       ` Ferruh Yigit [this message]
2021-10-13 22:55   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c4452de-863a-eb61-a816-677781c3e486@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=somnath.kotur@broadcom.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git