From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41705A0C55; Thu, 14 Oct 2021 00:02:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08E8E40041; Thu, 14 Oct 2021 00:02:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id A4A0A4003E for ; Thu, 14 Oct 2021 00:02:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="224998298" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="224998298" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 15:02:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="491664422" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 13 Oct 2021 15:02:32 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 15:02:32 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 15:02:32 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 15:02:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzXuJen4difjC+YB6Z4yksErMnQFSriHp3cRu9f3fSVeUtmM8nPvt3Zrgik3JNaQxXjoKCWOKHazsA74Ci4uE70hCEqIKvg9PEfEJ1d9Z+pXT/03o4UKppLcjq5CT0JYCBV3RDqEu9Nbi9/pDg+hiyXkF7r777rEPC0vbvHFN5KRp+fvE7jdPwhAVN+Sq7V3itlWdtzp2BuEAeTfyEhua8PulvKkaATXjjKVem6ursbNK7rzBhCNv9kt1IMGhBR1KSSePspsbsAgueoXRdQuFfQyENCz4Zbgf4vqInbFeR8Ru6w6Y77MPpVx+2BlTeTEwhCzWD/5Pn5wRxVWZZ75Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KYkaVd2ogMRO+Kdx6vvbG9vSue3wXrIAubfzC5suwkM=; b=d0ezS1zKylzmfjzbSDr3qzFePTB0OuIOL+CKsRrYy9pVKty87bSKQntGmJIO5BtS1Yv/jG3PAxuJycDIfP8/b6oNjTlcvUG0mLY/AQoUi4C3VzrEtL9UlnU6heADkWhbqjKiyPYa9iDmE64QwZnM7QflUzDqEoT9mz8mo9iLLW+MljOi7oBXQKR/XA+IYK41Bxy2u3lGbDVltA/S1BaMiycROlQNVPsww/xT/8227cWAPWPdnhlijegCALtGO1tnSsq43ptdjohqUUbpknrS41qy7FkDgy+Ayvz0fOWl0m2wn/msX5ABl1MvUAp2N7ZdS2gAXmev+XbKLD487QCLQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYkaVd2ogMRO+Kdx6vvbG9vSue3wXrIAubfzC5suwkM=; b=lBVUCmCM5ZEEHz0X3xPIshUi5QLakYd307Up2Rcig5QExtJdmDzTMccB3J/ARbUb8L9bfQO0jYQJOVumLZEQ+S0ccdYCaKet3ytQoh3JwhgOSvPKOTPMJy5yx89rSsFo4YZ4F0OR1XWuuuav+61tGMbFxwmg1Ax6B2vDZjH3Fj8= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5887.namprd11.prod.outlook.com (2603:10b6:510:136::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Wed, 13 Oct 2021 22:02:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 22:02:29 +0000 Message-ID: <2c4452de-863a-eb61-a816-677781c3e486@intel.com> Date: Wed, 13 Oct 2021 23:02:22 +0100 Content-Language: en-US To: Ajit Khaparde CC: Somnath Kotur , dpdk-dev References: <20211013163101.2811453-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR03CA0013.eurprd03.prod.outlook.com (2603:10a6:10:be::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR03CA0013.eurprd03.prod.outlook.com (2603:10a6:10:be::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 22:02:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 263b8b9e-7b1b-4787-b5b6-08d98e9525fb X-MS-TrafficTypeDiagnostic: PH7PR11MB5887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JW+Bzf4RTFULNW+Ki9TMyU6BQ+mcdHBfIX1/4fYXKePfcJCKPK4Ll2Xe5cxOcpyGbYFw8lMykXOgYR1sVjg6kabqj25Yp3kCNgGJpVzS6lZ11GqxKwlG7YLCVAx1r3YCNEjDBRp+J+3vL/eP9Q/X84f/SDCJEpTjiEBv8UQLRIISD7J8KrcQoTNIa/ZUD+kxQGXjF843s6WeFjpzjyGvr5MNVskwcj7aJzzLqxmptKclm2ehzG0FSKpLJF0JtfUEWI7w5RcTARK/4UaqBMtZG/yAP9glirtRnxNrFBUkV6SuIBPQQCb7PqHYEynspINHRR1xsn0P/tK/3gkWm529+T8BvwjSLcEkAnp9mJCN88hJeVn6bazk8xApUvrJDC9emHqS/YJQOZjdbhfpKxuPsfVkKk/OFr3tHcVoLYm1ACFTi6p8anU/0nf1B58bpdYRn9DmdDBOpy7MR4HXRj8OHEzJSACbqSKlAkd0BZ5U8xX20ouooGLHe44Gr9mm1IiOzllmPYijGXDd2DfqC9aOt1Qmdxix1TARAO6jzQWnL90XK7gK3aLMnMIzQ5Ea4u5Go6Ca0UgZQQ1xmIDcNftkwNuNqDjbE+JtxANShbz8JKMdTGylb907RCp2Lo3H2+7HAMIJrct/v4n2hDq+QcLu4ovXaseemQ7uy5KruXG7Y53yUi4NZSAzWfB2baDBCIPMBTzJBhgANCVs0ED8yrKyHg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(54906003)(8936002)(53546011)(6916009)(8676002)(2906002)(316002)(16576012)(508600001)(6486002)(6666004)(31686004)(86362001)(66556008)(956004)(4326008)(36756003)(66946007)(38100700002)(5660300002)(2616005)(44832011)(66476007)(82960400001)(31696002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGFpRGErYUVKYklPTnM2dGVGYXo1YmFlWnhhL2FwejEvYVlJYVptcDJUeU9M?= =?utf-8?B?Q0M4TTVEeDdSei9tdmtSdStUZnBtS3JrQ3ZpdUJCWnduMXBqQVFWQ1BtdXFV?= =?utf-8?B?TlFVTFFyeW81c3c4TDZQeGZUMWYza0dqcERkTXBxWWlwQnp2RUhuZ2NZZXMx?= =?utf-8?B?OFN3bHdicm81ZjJrVGVITXk3ajVsVitEMFUvZ3YxbEEwZlBJZDMzaHJvMjNR?= =?utf-8?B?TlNNckxha2NqMEwxL2ljZnhncCt0OTVUWW96OXFiakptYUVMUWFtck0xaVI3?= =?utf-8?B?RW1SaktveS9hT3I4bDJiMnR5cGQrWHJRUkhoK1kyZ2MzV1NqTHgvWGVtVEl4?= =?utf-8?B?UFpjaUtIa1lUUUpCcEc0ckdqdHJlVER3bVpGRFBkRjZMNEpnOVFBM1lVS3d5?= =?utf-8?B?S05jZWJIM3FHSWRCL2EwNjlXcGJZMWxuQkg5Qzl4cytBS0xXbXUwTTYvaTBm?= =?utf-8?B?ZGlXZDVZaWF1eDVuTnhUYTl1WjBsRTY0S25JQ0YvZXpHOHAxaFl0M0QrUVNQ?= =?utf-8?B?RVkvL3kybGFrNmlWZ29vRi9sMTZnZHhwK0ErN0FieUFvZVlnSTRwcWpJR3ox?= =?utf-8?B?eVlTWEUxMDJZdUhRNGxBYnFsaG9UUitJL1NZbEpZRWUvc3V4MlkrTHd6RmFV?= =?utf-8?B?VHNqNTRwcVpUbnpOMU1sb2lLZWV4bExjdjlJNVQveVBjLytZeEhldTRvWnlT?= =?utf-8?B?VExya3pSK2VjbHh6aUNkQWg4bWRDcUFOYkR4dy9VVFJucFlwNkJEVFg3WExr?= =?utf-8?B?Q0NuWldGUXhlUkRiZklwcWMwQm55dWsxdjFlT01sOEc0N1h0RDBLaS9qUzdy?= =?utf-8?B?RWlTTUFoUUJ6T1M4VUV5aldsZGdpZ0k4NXN5YkMyTkFxMlFoRnJKdEEzRWIx?= =?utf-8?B?V0RFRk1BTWo1M1pibDhPYzByOGZldEQ5SWN0ZXZxZWhUNWswMG1xSXFHUHdN?= =?utf-8?B?WWlzdytRbUExOWJicDYyaVBXNStDdm05YjJvT2YxNUpSbFVNMmduSU1QKzh2?= =?utf-8?B?RmFkZzRmUllzVG9YOHEvbSs5VkNQUFluK2RiQzV3ODdscGxWbUd3SHQyY0ls?= =?utf-8?B?WG9SSHpDclNSdm5NSVEyQ0IvTFV3ZmRibEJ4TkFLaElxWWJBcE5zY280R0Ix?= =?utf-8?B?T3g0a0xEZnpMeDVMYnJ3UEg4OCtJTTM2di91ZkRSem03emU1YWtDYTBucmRu?= =?utf-8?B?UkRqL0Nhei9DMmFSWmFjSDRlVFoyUjhQV1hSd04yV0FoYlJpR2pPemQwZjht?= =?utf-8?B?eXJrWFQxQm9OZGtFWUg4Si80cGV3dHpRVkxhbmFIVlVaV2x4bGkzMlJmUUhN?= =?utf-8?B?eWcwYzJweWVubllMTnloM2laeE44SWZPZFV4Z1ZBaklGN1g4dFVZVXNoV0N5?= =?utf-8?B?bXBXdmtFVXA4Ty9idzhwZjVtalMzbGpzS1JWK2xJWUpabXpzOHh6TVgraEJL?= =?utf-8?B?UEFRejdTa1kxZjRYVXlUalhBV2sxWk1xMFkvTHpOUVBESlZ0eGVuZTlZTGdH?= =?utf-8?B?NzF4YmdnbG8zRy85OFU0aEZlNVAyT1JCaXpLUVNtdEZmM3NHRnF1ekpmaUZ2?= =?utf-8?B?dFgyRHZHbmZwSjY5bUNFTThHU0tRMnd4OUwzT0E1cE1CU05leFJGakRqS3lB?= =?utf-8?B?dWpIU3A3aTdRazA4eXVVVE5zOHVUVHZXWVZmOHVxZTJ1U3E0aERWaHZ4QkZn?= =?utf-8?B?V2pBaTBjdytoRDJORHMwdis5U3JwL0xDaEVWc2VzbGRjKytzQXNMS1BOT3Zm?= =?utf-8?Q?IV66Uv8vGM/4D7VqfheLrq2ONI2drkPfPVzJtYM?= X-MS-Exchange-CrossTenant-Network-Message-Id: 263b8b9e-7b1b-4787-b5b6-08d98e9525fb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 22:02:29.0848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: acl8UTseFDRixqPrdqlU4V71mOWNS//uBXQXo3jdxeD5lPiOVI/aYmRS1qp0b63/PrTbqObAvXZAtGguL2mfVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 10:35 PM, Ajit Khaparde wrote: > On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit wrote: >> >> On 10/13/2021 6:34 PM, Ajit Khaparde wrote: >>> On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: >>>> >>>> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, >>>> removing it. >>>> >>>> Also with meson build system compile time debug macros should be >>>> documented in driver documentation, since there is not other way to >>> s/not/no >>> >>>> figure out their existence. >>>> >>>> Signed-off-by: Ferruh Yigit >>> With thanks and above nit, :-) >>> >>> Reviewed-by: Ajit Khaparde >>> >> >> Other option is to fix the build error when macro is set, would you like >> to go with that option? > No. There is more that we would like to add if we want to add debug capability. > Currently what you are trying to remove is a bit half baked which > should not have sneaked in. > So removing it for now is perfectly fine. > OK. >> >> And can you please send a separate patch to document the remaining >> compile time macros in the driver guide? > Sure. I will go through the code and take care of that. > I recognized that no more debug macro left after patch, so nothing to document. btw, '-DRTE_LIBRTE_BNXT_TF' in the meson seems not used at all.