From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Phil Yang <Phil.Yang@arm.com>, David Liu <dliu@iol.unh.edu>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"lylavoie@iol.unh.edu" <lylavoie@iol.unh.edu>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display
Date: Thu, 24 Sep 2020 16:26:54 +0100 [thread overview]
Message-ID: <2c4935de-5b4d-3cf9-2e4d-9757ae502d29@intel.com> (raw)
In-Reply-To: <DB7PR08MB386576F77CFBDE9B1485C396E9390@DB7PR08MB3865.eurprd08.prod.outlook.com>
On 9/24/2020 11:57 AM, Phil Yang wrote:
>
> dev <dev-bounces@dpdk.org> On Behalf Of Phil Yang : writes:
>
>
>>> Subject: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module
>>> eeprom display
>>>
>>> Add module EEPROM/EEPROM dump command
>>> "show port <port_id> (module_eeprom|eeprom)"
>>> Commands will dump the content of the EEPROM/module
>>> EEPROM for the selected port.
>>
>>
>> Verified with some popular NICs, it can dump the same info as the Linux
>> ethtool does.
>> This is supported in examples/ethtool as well.
>>
>> Minor nitpick comments inlined.
>>
>> Thanks,
>> Phil
>>
>>>
>>> Signed-off-by: David Liu <dliu@iol.unh.edu>
<...>
>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
(empty line above include fixed while merging.)
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2020-09-24 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 6:00 [dpdk-dev] [PATCH V1] " David Liu
2020-09-10 11:47 ` Ferruh Yigit
2020-09-10 18:48 ` David Liu
2020-09-14 15:11 ` [dpdk-dev] [PATCH V2] " David Liu
2020-09-14 16:48 ` Ferruh Yigit
2020-09-15 14:22 ` David Liu
2020-09-10 20:00 ` [dpdk-dev] [PATCH V1] " David Liu
2020-09-15 15:42 ` [dpdk-dev] [PATCH] [PATCH V2] " David Liu
2020-09-15 17:24 ` David Liu
2020-09-15 17:27 ` David Liu
2020-09-22 9:13 ` Phil Yang
2020-09-24 10:57 ` Phil Yang
2020-09-24 15:26 ` Ferruh Yigit [this message]
2020-09-10 20:12 ` [dpdk-dev] [PATCH V1 2/2] Fix coding style issues David Liu
2020-09-15 14:58 [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display David Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c4935de-5b4d-3cf9-2e4d-9757ae502d29@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Phil.Yang@arm.com \
--cc=dev@dpdk.org \
--cc=dliu@iol.unh.edu \
--cc=lylavoie@iol.unh.edu \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).