From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53FF0A0579; Mon, 19 Apr 2021 23:42:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C555C41471; Mon, 19 Apr 2021 23:42:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 67B2B41448 for ; Mon, 19 Apr 2021 23:42:44 +0200 (CEST) IronPort-SDR: +VbeCPgzaQsODez2yTUTBMYHlfeoz0gu4t1L5JKVorGtkp3/EoCrvky8fxpEMGqnjUwqvWVzrd I/lzLn6SFNsA== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="215985661" X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="215985661" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 14:42:43 -0700 IronPort-SDR: zLzy7abQrYtPP2KDjRD7K/a26mq3WZA9w7FdUUl7hQdp1wIuz+l1cqTJ/loGqlXPdhJELThLsV /gm8+T1ypyoA== X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="462878225" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.224]) ([10.213.220.224]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 14:42:40 -0700 To: Li Zhang , dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20210331073632.1443011-1-lizh@nvidia.com> <20210415151135.2098674-1-lizh@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2c4adae7-e0b5-7125-5bb6-6e8ec6840fef@intel.com> Date: Mon, 19 Apr 2021 22:42:36 +0100 MIME-Version: 1.0 In-Reply-To: <20210415151135.2098674-1-lizh@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/15/2021 4:11 PM, Li Zhang wrote: > To support more meters and better performance, > MLX HW provide ASO flow meter. > It can expose millions of ASO flow meter context's in HW. > This ASO object can allocate the large bulk meter objects. > This patch set implement the ASO flow meter for mlx5 driver. > MLX5 PMD driver will be responsible for ASO flow meter manage to HW. > What is ASO? Search yields "Advanced Steering Operation" but that seems Mellanox jargon, would you mind adding some mlx documentation to describe it? If there are some design considerations around it, it may be good to document that too. Also please provide the long version of the abbreviation in the commit log, at least at first usage of it. And what do you think mentioning from this new support in the release notes? Thanks, ferruh > V2: Fix compile error issue (mlx5_glue->destroy_flow_action) > V3: Fix comments. > V4: Fix comments and add Acked. > V5: Fix unused log_obj_size issue. > > Li Zhang (10): > net/mlx5: optimize meter statistics > common/mlx5: add definitions for ASO flow meter > common/mlx5: add read ASO flow meter HCA capability > common/mlx5: add DevX API to create ASO flow meter object > net/mlx5: flow meter pool to manage meter object > net/mlx5: initialize the flow meter ASO SQ > net/mlx5: aso flow meter send WQE and CQE handle > net/mlx5: add support of ASO meter action > net/mlx5: make ASO meter queue thread-safe > net/mlx5: allow multiple flow tables on the same level > > Shun Hao (3): > common/mlx5: add color register idle bits definition > net/mlx5: fix meter statistics > net/mlx5: use mask for meter register setting > > Suanming Mou (1): > net/mlx5: support three level table walk > > doc/guides/nics/mlx5.rst | 6 + > drivers/common/mlx5/mlx5_devx_cmds.c | 68 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 26 +- > drivers/common/mlx5/mlx5_prm.h | 81 +- > drivers/common/mlx5/version.map | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 20 +- > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5.c | 98 +- > drivers/net/mlx5/mlx5.h | 258 +++++- > drivers/net/mlx5/mlx5_flow.c | 334 +++++-- > drivers/net/mlx5/mlx5_flow.h | 212 ++--- > .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 289 +++++- > drivers/net/mlx5/mlx5_flow_dv.c | 792 +++++++++++----- > drivers/net/mlx5/mlx5_flow_meter.c | 873 ++++++++++++------ > drivers/net/mlx5/mlx5_utils.h | 90 ++ > 15 files changed, 2320 insertions(+), 830 deletions(-) > rename drivers/net/mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} (65%) >