From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57219A04BB; Tue, 6 Oct 2020 14:04:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DEC729C6; Tue, 6 Oct 2020 14:04:43 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 69BAA25B3; Tue, 6 Oct 2020 14:04:40 +0200 (CEST) IronPort-SDR: rTbQcLDA3H1BtS6msJr8tecHHuI0vAOXSpiRU/vXi7ielZXM0OD+lcdquSuGI9UnFjBDSh911O JDqGOYp9OfVg== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="161070572" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="161070572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 05:04:37 -0700 IronPort-SDR: GdlPJ18pP1sO41QKe99WSquAtPiWcDrkgwZzJO1CoAYN6q3vyz4V4GUJOumxIidwi9XXRqaivz qDwxK32XW+FA== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342216265" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 05:04:35 -0700 From: Ferruh Yigit To: Thomas Monjalon , "Min Hu (Connor)" Cc: "techboard@dpdk.org" , stephen@networkplumber.org, bruce.richardson@intel.com, "jerinj@marvell.com" , dev@dpdk.org References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <1601176596-29900-3-git-send-email-humin29@huawei.com> <64be8517-6c26-6185-fb2e-981105225d90@intel.com> <4609355.k5e1dzZlXI@thomas> <2a7862a2-5aa1-5b61-82db-3e3cba0bce15@intel.com> Message-ID: <2c501e00-8373-9a4a-9431-1418151098e1@intel.com> Date: Tue, 6 Oct 2020 13:04:32 +0100 MIME-Version: 1.0 In-Reply-To: <2a7862a2-5aa1-5b61-82db-3e3cba0bce15@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 2/2] ethdev: change data type in TC rxq and TC txq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2020 1:26 PM, Ferruh Yigit wrote: > On 9/28/2020 10:21 AM, Thomas Monjalon wrote: >> 28/09/2020 11:04, Ferruh Yigit: >>> On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: >>>> From: Huisong Li >>>> >>>> Currently, base and nb_queue in the tc_rxq and tc_txq information >>>> of queue and TC mapping on both TX and RX paths are uint8_t. >>>> However, these data will be truncated when queue number under a TC >>>> is greater than 256. So it is necessary for base and nb_queue to >>>> change from uint8_t to uint16_t. >> [...] >>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>>    struct rte_eth_dcb_tc_queue_mapping { >>>>        /** rx queues assigned to tc per Pool */ >>>>        struct { >>>> -        uint8_t base; >>>> -        uint8_t nb_queue; >>>> +        uint16_t base; >>>> +        uint16_t nb_queue; >>>>        } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; >>>>        /** rx queues assigned to tc per Pool */ >>>>        struct { >>>> -        uint8_t base; >>>> -        uint8_t nb_queue; >>>> +        uint16_t base; >>>> +        uint16_t nb_queue; >>>>        } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS]; >>>>    }; >>>> >>> >>> cc'ed tech-board, >>> >>> The patch breaks the ethdev ABI without a deprecation notice from previous >>> release(s). >>> >>> It is increasing the storage size of the fields to support more than 255 queues. >> >> Yes queues are in 16-bit range. >> >>> Since the ethdev library already heavily breaks the ABI this release, I am for >>> getting this patch, instead of waiting for one more year for the update. >>> >>> Can you please review the patch, is there any objection to proceed with it? >> >> Acked-by: Thomas Monjalon >> >> > > Reviewed-by: Ferruh Yigit > > I will continue with this patch (not patchset) if there is no objection. > Applied to dpdk-next-net/main, thanks. Only this patch in the patchset merged, discussion is going on the 1/2 one, since the issues are separate, it can continue on its own.