From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 953BE1BA8D for ; Thu, 26 Oct 2017 12:06:34 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id r196so6868465wmf.2 for ; Thu, 26 Oct 2017 03:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=/ZZhmE8hr8UULL4stu1w5PghDdd3QTWn8Ow0Q/rALfM=; b=TxvODl0BhSIwrZCmWgnFYF4KcDdDAfnv6CoHkCj5tNVy94fFhsfsK/WkwDwx1axYGg B7Q5mibvfrhK3ouWig6XrFYpTehvZ+rm+fjLVSP13JvfUgdckhJ3v0EE4FPM1KhQwVu7 /ROxj5CJ8+paOfym2ZJuwN/leVmCaYopgPfuLiCGAxzBCuJYVBQb/145RV/RWb1Wjuub UD+bkzmIsWx4g60oKsi4vj2SKHrCCgh4CgnEkCKYKi0thvbDmEnzn6fckBhazzjJdYgO sjOu/tpq0kg1d9CGDSJwYvAiVoVvzEzmxIqIkIQ9vDnsl/HgwNQ7waMJ7egQLt/u9IdH 4row== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=/ZZhmE8hr8UULL4stu1w5PghDdd3QTWn8Ow0Q/rALfM=; b=BavpMd90JqRrUOYxv1xoAgItSBJikZnULDj+FhGza1rvN87EIw34sv3iyq/eV1Su5x CHdTmj4H/ZACwcIfLTy19n4PPJIYhtOlJzhJAMSSXv5hnJj/PrQDoskbySU7K3MkARLl GkHvQP7DvrTEJQLkbzRO1CRTknA5274Vk4kIeyDeWOVHG0k1NEUqkTchcoIijBpzd76c hASFOQq7lcyjRaYeHCCbGMwa0egEYEMpotExml5dGRxsfp9urK43LPACOwwBb1hmqVXh dqkM6wTC0Alfhtaz8jVpI1UbfphwU0uOpW3xW5fL1NKoJWkvhOS2/UhC79N+KMfwi+Vy hNhQ== X-Gm-Message-State: AMCzsaXDY7wsR4GSX+ayBgGoNR08EszoRYFQP/0JLZ0IoWybn5FW0Goo 88DADd3VrEpPh3cyUxf1TA9eIfWc X-Google-Smtp-Source: ABhQp+Qg8CDIjDZi7B+RasKUhf+9xeu4KNcNynjeuXDtfsk6bd0wmtNY9LIfDDC+7nrMfIXXy9j1kg== X-Received: by 10.80.135.176 with SMTP id a45mr27168202eda.112.1509012393805; Thu, 26 Oct 2017 03:06:33 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u12sm3339619edk.45.2017.10.26.03.06.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Oct 2017 03:06:33 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Thu, 26 Oct 2017 12:05:50 +0200 Message-Id: <2c5d766c968f22dd2c3c967d877c05bd4b031072.1509012196.git.gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v8 05/25] eal: expose rte_eal_using_phys_addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 10:06:34 -0000 This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from bool to int. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal_memory.c | 6 ++++++ lib/librte_eal/common/eal_private.h | 11 ----------- lib/librte_eal/common/include/rte_memory.h | 11 +++++++++++ lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +- lib/librte_eal/rte_eal_version.map | 1 + 5 files changed, 19 insertions(+), 12 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index 3614da8..65c96b0 100644 --- a/lib/librte_eal/bsdapp/eal/eal_memory.c +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c @@ -192,3 +192,9 @@ rte_eal_hugepage_attach(void) close(fd_hugepage); return -1; } + +int +rte_eal_using_phys_addrs(void) +{ + return 0; +} diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 9340b6e..80fea24 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib/librte_eal/common/eal_private.h @@ -345,17 +345,6 @@ int rte_eal_hugepage_init(void); int rte_eal_hugepage_attach(void); /** - * Returns true if the system is able to obtain - * physical addresses. Return false if using DMA - * addresses through an IOMMU. - * - * Drivers based on uio will not load unless physical - * addresses are obtainable. It is only possible to get - * physical addresses when running as a privileged user. - */ -bool rte_eal_using_phys_addrs(void); - -/** * Find a bus capable of identifying a device. * * @param str diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h index c545963..271d2bb 100644 --- a/lib/librte_eal/common/include/rte_memory.h +++ b/lib/librte_eal/common/include/rte_memory.h @@ -187,6 +187,17 @@ unsigned rte_memory_get_nchannel(void); */ unsigned rte_memory_get_nrank(void); +/** + * Drivers based on uio will not load unless physical + * addresses are obtainable. It is only possible to get + * physical addresses when running as a privileged user. + * + * @return + * 1 if the system is able to obtain physical addresses. + * 0 if using DMA addresses through an IOMMU. + */ +int rte_eal_using_phys_addrs(void); + #ifdef __cplusplus } #endif diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 187d338..ddf88c5 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1494,7 +1494,7 @@ rte_eal_hugepage_attach(void) return -1; } -bool +int rte_eal_using_phys_addrs(void) { return phys_addrs_available; diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index 8eb53ab..bcc594d 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -244,6 +244,7 @@ DPDK_17.11 { rte_bus_get_iommu_class; rte_eal_iova_mode; rte_eal_mbuf_default_mempool_ops; + rte_eal_using_phys_addrs; rte_lcore_has_role; rte_memcpy_ptr; rte_pci_get_iommu_class; -- 2.1.4