From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6EA961B61A for ; Fri, 22 Dec 2017 22:57:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2017 13:57:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,442,1508828400"; d="scan'208";a="13984077" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.109]) ([10.241.224.109]) by FMSMGA003.fm.intel.com with ESMTP; 22 Dec 2017 13:57:48 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1512042367-6361-1-git-send-email-hemant.agrawal@nxp.com> <1512042367-6361-2-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <2c6d5b3c-eb45-dd00-055d-e84f55342def@intel.com> Date: Fri, 22 Dec 2017 13:57:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512042367-6361-2-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] kni: add support for promisc mode set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 21:57:50 -0000 On 11/30/2017 3:46 AM, Hemant Agrawal wrote: > Inform userspace app about promisc mode change Same two concerns here with prev patch. - Breaking ABI - And handling ops.port_id not set by application case. > > Signed-off-by: Hemant Agrawal <...>