Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/12/2017 1:04 PM, Olivier Matz wrote:
> Fix typo when checking that no Vlan offload flags are passed at port
> initialization.
> 
> By the way, also fix a typo in the log.
> 
> Fixes: d4a27a3b092a ("nfp: add basic features")
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/nfp/nfp_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 65ba09f..ed3c9b8 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask)
>  	new_ctrl = 0;
>  
>  	if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
> -	    (mask & ETH_VLAN_FILTER_OFFLOAD))
> -		RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
> +	    (mask & ETH_VLAN_FILTER_EXTEND))

I can't find "ETH_VLAN_FILTER_EXTEND",
do you mean "ETH_VLAN_EXTEND_OFFLOAD" ?

> +		RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
>  			" ETH_VLAN_FILTER_EXTEND");
>  
>  	/* Enable vlan strip if it is not configured yet */
>