From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 163542B97 for ; Fri, 13 Jan 2017 15:32:35 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 13 Jan 2017 04:03:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,221,1477983600"; d="scan'208";a="53438067" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga006.fm.intel.com with ESMTP; 13 Jan 2017 04:03:02 -0800 To: Olivier Matz , dev@dpdk.org, alejandro.lucero@netronome.com References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> From: Ferruh Yigit Message-ID: <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com> Date: Fri, 13 Jan 2017 12:03:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484226296-540-1-git-send-email-olivier.matz@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 14:32:36 -0000 On 1/12/2017 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- > drivers/net/nfp/nfp_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 65ba09f..ed3c9b8 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask) > new_ctrl = 0; > > if ((mask & ETH_VLAN_FILTER_OFFLOAD) || > - (mask & ETH_VLAN_FILTER_OFFLOAD)) > - RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or" > + (mask & ETH_VLAN_FILTER_EXTEND)) I can't find "ETH_VLAN_FILTER_EXTEND", do you mean "ETH_VLAN_EXTEND_OFFLOAD" ? > + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or" > " ETH_VLAN_FILTER_EXTEND"); > > /* Enable vlan strip if it is not configured yet */ >