From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 48438A10E; Wed, 2 Aug 2017 01:47:31 +0200 (CEST) Received: from pps.filterd (m0000700.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v71NZfUc008363; Tue, 1 Aug 2017 16:47:30 -0700 Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 2c0r030cpq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 01 Aug 2017 16:47:30 -0700 Received: from [10.252.52.3] (10.252.52.3) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 1 Aug 2017 17:47:27 -0600 To: Shrikrishna Khare References: <1500906162-18009-1-git-send-email-ciwillia@brocade.com> CC: , , From: "Charles (Chas) Williams" Message-ID: <2c9bfa3f-ea0e-c803-c435-f1dca132d894@brocade.com> Date: Tue, 1 Aug 2017 19:47:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-08-01_14:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708010368 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 23:47:31 -0000 On 08/01/2017 07:41 PM, Shrikrishna Khare wrote: > > > On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > >> We should only restore shadow_vfta when hw_vlan_filter is active. >> Otherwise, we should restore the previous filtering behavior. >> >> Fixes: f003fc383487("vmxnet3: enable vlan filtering") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chas Williams >> --- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c >> index ab5a824..3910991 100644 >> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c >> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c >> @@ -1219,7 +1219,10 @@ vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev) >> struct vmxnet3_hw *hw = dev->data->dev_private; >> uint32_t *vf_table = hw->shared->devRead.rxFilterConf.vfTable; >> >> - memcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE); >> + if (dev->data->dev_conf.rxmode.hw_vlan_filter) >> + memcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE); >> + else >> + memset(vf_table, 0xff, VMXNET3_VFT_TABLE_SIZE); > > From the device emulation standpoint, vf_table array set to all 1s means > that rx filtering is enabled but all vlan ID are allowed, while vf_table > array set to all 0s means that no vlan ID filtering is done. > > So, it is better to go with all 0s rather than all 1s, it is also more > efficient for the emulation. > > This is an existing problem in vmxnet3_dev_vlan_offload_set as well. That may be the case, but this patch isn't the place to address that. If this needs changed, there should be a follow on patch that makes this change. > >> vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 0); >> VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, >> VMXNET3_CMD_UPDATE_VLAN_FILTERS); >> -- >> 2.1.4 >> >>