From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 259CEA0521; Tue, 3 Nov 2020 13:39:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A1CCC9F2; Tue, 3 Nov 2020 13:37:40 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 0B206C9CE for ; Tue, 3 Nov 2020 13:37:38 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 94C277F5A1; Tue, 3 Nov 2020 15:37:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 94C277F5A1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1604407056; bh=+nhPG6nKgiIucvl+VPFzmOrZq11yDnAjdP+6A/v+kBU=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=r5qlLs13uhsVFBw9gzv11lN1x0WZRCsXPcXgRoVcKhj6p2kkxUx3Q0QRfzNGpWd9c R1ZYFIVDgsdBDJzkCyMjTbrClELtxoeaE6Yb99hd5u5LrfMRUzRZCsk2KiO7G9qY+c p+HyvaV9Dk2vaxkoFkH5wFZWOLhaT9RZ4fsEy6iM= To: Thomas Monjalon , dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, jerinj@marvell.com, viacheslavo@nvidia.com, Shepard Siegel , Ed Czeck , John Miller References: <20201029092751.3837177-1-thomas@monjalon.net> <20201103122205.183472-1-thomas@monjalon.net> <20201103122205.183472-5-thomas@monjalon.net> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <2cb42b0a-972b-2af7-7aef-f28a9b4eb665@oktetlabs.ru> Date: Tue, 3 Nov 2020 15:37:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201103122205.183472-5-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/20 3:21 PM, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related dynamic mbuf flag is set, although was missing previously. > > The timestamp is set if configured for at least one device. > > Signed-off-by: Thomas Monjalon > Acked-by: David Marchand Just one minor comment below > --- > drivers/net/ark/ark_ethdev.c | 16 ++++++++++++++++ > drivers/net/ark/ark_ethdev_rx.c | 7 ++++++- > drivers/net/ark/ark_ethdev_rx.h | 2 ++ > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > index fa343999a1..a34dcc5291 100644 > --- a/drivers/net/ark/ark_ethdev.c > +++ b/drivers/net/ark/ark_ethdev.c > @@ -79,6 +79,8 @@ static int eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t size); > #define ARK_TX_MAX_QUEUE (4096 * 4) > #define ARK_TX_MIN_QUEUE (256) > > +uint64_t ark_timestamp_rx_dynflag; > +int ark_timestamp_dynfield_offset = -1; > int rte_pmd_ark_rx_userdata_dynfield_offset = -1; > int rte_pmd_ark_tx_userdata_dynfield_offset = -1; It is a bit confusing that naming above differs so much and put in the same block without empty lines in between. I guess the reason is export/no-export. May be it would be useful to highlight it in a comment.