From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9323EDE3 for ; Fri, 27 Jan 2017 12:06:53 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 27 Jan 2017 03:06:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,294,1477983600"; d="scan'208";a="927272980" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 27 Jan 2017 03:06:51 -0800 To: John Daley References: <20170126201212.31796-1-johndale@cisco.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com> Date: Fri, 27 Jan 2017 11:06:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170126201212.31796-1-johndale@cisco.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: fix MAC address add and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 11:06:54 -0000 On 1/26/2017 8:12 PM, John Daley wrote: > The mac_addr_add callback function was simply replacing the primary MAC > address instead of adding new ones and the mac_addr_remove callback would > only remove the primary MAC form the adapter. Fix the functions to add or > remove new address. Allow up to 64 MAC addresses per port. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar Applied to dpdk-next-net/master, thanks. (Since it is controversial that if this patch is a fix or implementing a missing feature (allow up to 64 MAC), I am getting patch as it is, but not CC'ed to stable tree, please shout if you disagree.)