From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 424061B998; Thu, 18 Apr 2019 14:02:27 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id y13so2669335wrd.3; Thu, 18 Apr 2019 05:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=++Uv1StQO9mUHpq8fsUe/s7eN8bVV5uSph4OpV1ZxJc=; b=cRozV9DUaXpdrb008nMrKhb/0uSj4KxZRIlYpz7X1tvFxQN+gjGm9i4rtMDlYryQNp udXmB2jeKSF9R6RiY+2/XVCdfkP2gWkLH1sOERHxRYzNA83eWmYKrbYVZnzUcyLTXDSM Juff3rB5K9kzB1/bCoByeE8Zs1QNpzgTX4XBrxJYAk2rP8gnt7GvqQR/dLQLwKHPq+D+ COI/sxWkXZoB4Bd14m/A/gMyzvuZiRKjkgfjkiRMCYHp+iooJCD0kHIzx9Y0Oa4GQxYY vE3ceXabkHwq8dakHhSBd94EUua1JzZWcGJlE9aRl9C0OArr2IQ2YyEK9naadiyqyDk7 ZYkQ== X-Gm-Message-State: APjAAAXeHh/4eu04uRZIVluAbeXCPArbFaUht994hvBojgf2ZshKYb72 7IPrJAnFItzNeD5ujXtmKpc= X-Google-Smtp-Source: APXvYqxBQUXPvFIceKPuA3TzvpVGp94MZtml19THuuIeA6oUKXGXVr3O6LKJA3jH4CmNZQVuf7+k9A== X-Received: by 2002:adf:e4c2:: with SMTP id v2mr13338093wrm.124.1555588946801; Thu, 18 Apr 2019 05:02:26 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x5sm1355466wmi.37.2019.04.18.05.02.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 05:02:23 -0700 (PDT) Message-ID: <2cfc55cd63c6596d668fb3c188865858e17af2b5.camel@debian.org> From: Luca Boccassi To: Yongseok Koh , bruce.richardson@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com, shahafs@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, stable@dpdk.org Date: Thu, 18 Apr 2019 13:02:22 +0100 In-Reply-To: <20190418114903.42231-3-yskoh@mellanox.com> References: <20190412232451.30197-1-yskoh@mellanox.com> <20190418114903.42231-1-yskoh@mellanox.com> <20190418114903.42231-3-yskoh@mellanox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 12:02:27 -0000 On Thu, 2019-04-18 at 04:49 -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for > libraries and > dependency() can't find libraries by pkg-config. By adding fallback > of > using cc.find_library(), libraries are properly located. >=20 > Fixes: e30b4e566f47 ("build: improve dependency handling") > Cc:=20 > bluca@debian.org >=20 > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Yongseok Koh < > yskoh@mellanox.com > > > --- >=20 > v3: > * use lib name without 'lib' prefix for cc.find_library() >=20 > v2: > * change variable names to minimize code change >=20 > drivers/net/mlx4/meson.build | 15 +++++++++------ > drivers/net/mlx5/meson.build | 15 +++++++++------ > 2 files changed, 18 insertions(+), 12 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 652E4A00E6 for ; Thu, 18 Apr 2019 14:02:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 844DF1B9A3; Thu, 18 Apr 2019 14:02:28 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 424061B998; Thu, 18 Apr 2019 14:02:27 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id y13so2669335wrd.3; Thu, 18 Apr 2019 05:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=++Uv1StQO9mUHpq8fsUe/s7eN8bVV5uSph4OpV1ZxJc=; b=cRozV9DUaXpdrb008nMrKhb/0uSj4KxZRIlYpz7X1tvFxQN+gjGm9i4rtMDlYryQNp udXmB2jeKSF9R6RiY+2/XVCdfkP2gWkLH1sOERHxRYzNA83eWmYKrbYVZnzUcyLTXDSM Juff3rB5K9kzB1/bCoByeE8Zs1QNpzgTX4XBrxJYAk2rP8gnt7GvqQR/dLQLwKHPq+D+ COI/sxWkXZoB4Bd14m/A/gMyzvuZiRKjkgfjkiRMCYHp+iooJCD0kHIzx9Y0Oa4GQxYY vE3ceXabkHwq8dakHhSBd94EUua1JzZWcGJlE9aRl9C0OArr2IQ2YyEK9naadiyqyDk7 ZYkQ== X-Gm-Message-State: APjAAAXeHh/4eu04uRZIVluAbeXCPArbFaUht994hvBojgf2ZshKYb72 7IPrJAnFItzNeD5ujXtmKpc= X-Google-Smtp-Source: APXvYqxBQUXPvFIceKPuA3TzvpVGp94MZtml19THuuIeA6oUKXGXVr3O6LKJA3jH4CmNZQVuf7+k9A== X-Received: by 2002:adf:e4c2:: with SMTP id v2mr13338093wrm.124.1555588946801; Thu, 18 Apr 2019 05:02:26 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x5sm1355466wmi.37.2019.04.18.05.02.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 05:02:23 -0700 (PDT) Message-ID: <2cfc55cd63c6596d668fb3c188865858e17af2b5.camel@debian.org> From: Luca Boccassi To: Yongseok Koh , bruce.richardson@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com, shahafs@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, stable@dpdk.org Date: Thu, 18 Apr 2019 13:02:22 +0100 In-Reply-To: <20190418114903.42231-3-yskoh@mellanox.com> References: <20190412232451.30197-1-yskoh@mellanox.com> <20190418114903.42231-1-yskoh@mellanox.com> <20190418114903.42231-3-yskoh@mellanox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418120222.upF7sHGB9lVd5tuZQ-_gutkDZD3h4O4joqKzVZ0kPJc@z> On Thu, 2019-04-18 at 04:49 -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for > libraries and > dependency() can't find libraries by pkg-config. By adding fallback > of > using cc.find_library(), libraries are properly located. >=20 > Fixes: e30b4e566f47 ("build: improve dependency handling") > Cc:=20 > bluca@debian.org >=20 > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Yongseok Koh < > yskoh@mellanox.com > > > --- >=20 > v3: > * use lib name without 'lib' prefix for cc.find_library() >=20 > v2: > * change variable names to minimize code change >=20 > drivers/net/mlx4/meson.build | 15 +++++++++------ > drivers/net/mlx5/meson.build | 15 +++++++++------ > 2 files changed, 18 insertions(+), 12 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi