From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1027843215; Fri, 27 Oct 2023 14:37:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 001D540A8A; Fri, 27 Oct 2023 14:37:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 70D63402DF for ; Fri, 27 Oct 2023 14:37:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698410271; x=1729946271; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=08k4zYiT6UCcvTaJYbYDZH0ZjQz0b6l4KVnpp7F5pS8=; b=Tk5hCdO+NeY6oMD7pu9DdvJ7quxng77ZzcObbF/8H+vP/D+wlt/+O9rd 8jUwONbXxZ0N1GbNuWqKvRh8DeUFxdTmel0RCC8RZVQ5c/y5tz7g3/kxf ZUhGiPKD+Gsb6Ez46xVMVa1Wm1sVo2sfLA2TRF/doelSCeCxOksvjhAwO il9WhqjMOxJqh4dGytsPZAugmX9kRjmbL3D8M8fuAEj7cArCRHKmfKuc+ eRa+mRpmOmigei/BLbfqgpZHPi+Se1T1owI88lxYNUhfM0C5MxtDgl6Af 06ah2Jl2PnsxvzYnKQLO6j05tugmsYdY9yevLoEzpE/VMSH5XuYijKha8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="387581509" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208,217";a="387581509" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 05:36:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="903262865" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208,217";a="903262865" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Oct 2023 05:33:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 05:36:11 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 05:36:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 27 Oct 2023 05:36:11 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 27 Oct 2023 05:36:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+BMlvQKrdmBFYScjYNnY6PfkZV0Zi6JAWz8z0gHE0B9RVlz4XQrqaVv4wLmnh4KX7tFQZdoSUIm3uW2FZfNQpldfrNHCpM3GvWfXVt/5mdNaGepZdF62Q7MXBC3jAbZytPaEipQ3M42+FWTv4ADIacEVMTHlBfxheMaOiHZ3h+XP37b4oMCsSIN0EdwuhOLOPQSy4VHhIoM+Lqwmp/XxwoDMsJzrAPmIlxamTS628jSxnj6ti2dFBveFPJd2qOwZuf7vVl6u+8Srk8Evh9M8j5g80PewVTPAUunUrbM+uIa8wNX8zqKXjvrJC1iPWJgNIHTzw6LwrcjuIntkDt35w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nt/4oC86q4TcBdS2qmhhKZr24LA/fwYhlFMqiJhy2Ec=; b=amgMR2aJOYF0oTlEV+qXSXVaxYWUNWpZ9tLcPC6MrrgqiJ89vOXSaC6Cr52YF1rK7LUqpIlZX6zyyqwYNyaA31Yhnppp5Z6iO2iTdBqEKfxt18YYDpO4WTDjCdZfCuqwyRh4Qrvh6fqQ0oajJwzbW+maJrS9drfdKLYxS55NMEQ49YQHesGv/S+MopCjnsRiAQLdlJ5gepNtsZa/BDCR9uEzT6Q67xe6/YZZZAE0UsQFumzEHrFyHSo2mKeOkm0LBfqSRHWiQ4zkRFAavgeE+Yhap3jlWSK3SvcHH39P+ZNmeWUq1JVHi768o3l00ukp1bjOfx9lmAjlo9hmhv56EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB7055.namprd11.prod.outlook.com (2603:10b6:303:22b::17) by IA1PR11MB6537.namprd11.prod.outlook.com (2603:10b6:208:3a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Fri, 27 Oct 2023 12:36:08 +0000 Received: from MW4PR11MB7055.namprd11.prod.outlook.com ([fe80::be32:e3ab:df1f:b97f]) by MW4PR11MB7055.namprd11.prod.outlook.com ([fe80::be32:e3ab:df1f:b97f%4]) with mapi id 15.20.6907.032; Fri, 27 Oct 2023 12:36:08 +0000 Content-Type: multipart/alternative; boundary="------------gDFUl6GPZyRpOkQH0QpiZTi6" Message-ID: <2d53680a-cde3-45cf-b353-81637ec4f7e2@intel.com> Date: Fri, 27 Oct 2023 13:36:01 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env To: Sivaprasad Tummala , , , CC: , , , References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> Content-Language: en-US From: "Kelly, Karen" In-Reply-To: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> X-ClientProxiedBy: DUZPR01CA0043.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::6) To MW4PR11MB7055.namprd11.prod.outlook.com (2603:10b6:303:22b::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB7055:EE_|IA1PR11MB6537:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b7999d9-ed3b-4b38-1829-08dbd6e94b7e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AugS9+fLsaAw5D1tsD/PQZFVR20QO0enXG5ZtNu9yvL+ybQ1bSQyQpncRTvCE+sWyv6fHAEdjWIS6SYK1R05uGPuRN6YlDfMUjOutyi/5T+w7O7x0hcv4qOPS+5wGl5URJC+QIzQulxxXI+34yazgaNPraryTg3+iie/+WEqeZXgT6NYC7mMgsR+rbuN4qZeuMnskI0g6OhFVILxoulmHNNfvGf3LbpXaB2Jbb3QKhBd8yO+vbq+Vw3lVDyzAuw6kSqPRJZxRrxOoJjmioNZ+MgCrEE71r2nkVcXtb4bLszb170ntNerg1Ft+zsASPEEOPk3GY/s0cjO7dbcEKiSjNlI7i+9AALl2wNlUelG6slHDQyrjTPG/bIyBhMGQyoXHdaPbLp7PK5Z54Puclc59KJ9YSiEHx/IqFf4ZKPK1MiQPB1U+XNKbVdfOIf2crKrUQ/6SZncyso6MEvdyvDcgsPqq7stF2g+02aEypkBKiKf8AeEYNFg7hZA82PwIMW1wviCBkhRNIOFkoQXnaW0qmGkd7CgBrTwnC6QBmGfgXScg/yfMG9yqUR8kJyO/2s+zw9xMUVeDq53N8n6NggLESz3B68XZxNcLmgpPaTe53ylUpAlkBz3eASz2a/T/8lUGtzhoHbT2dY6YobhsW5wJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB7055.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(39860400002)(136003)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(83380400001)(26005)(33964004)(86362001)(5660300002)(6666004)(6486002)(66556008)(41300700001)(66476007)(66946007)(478600001)(6506007)(31696002)(316002)(6512007)(36756003)(8936002)(8676002)(38100700002)(4326008)(2906002)(2616005)(53546011)(82960400001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejViaitRa0xTeFZScXZjUmFRQ3FUOGtQN1lQU3V4amQ3a1pRVm5pRXBsdUN6?= =?utf-8?B?dVpOU1FOTkhHSWVFUzFPYUZyZTdySkdtRERacTcva0RENjJLQVpYYXZIYUps?= =?utf-8?B?czBXWmthNzlVc05yTGJJVWswWFlhSEJBTVIzVHVaYm9EbHVPYmUvNHpOdzc1?= =?utf-8?B?S3VEeXJSR0xvUWZlWHNLWjhRb01PRHhoU1hBMHFkUFlXQng3bWVzM2o4eW1y?= =?utf-8?B?SElhbU1zLzNIZmV0cWZxNTVEMlVSbmtjRTFmY2VtbS9Qc3E2M2F6T3paUnJq?= =?utf-8?B?ZXhMbnN6SFFvL3poRWpHT1RlY2h6L2lIeVpzekFiRVNHYVBCNDE5WExQSG1a?= =?utf-8?B?QmtUTnlBTDVWWTg4bk1QNkZPTkppeFlXaFdSUDROTmNqSkhmSTdwTHRDb2Vr?= =?utf-8?B?UFBQZG1YRjQ3QUVtU2o2VERVdEh6aDFiV1lYMWpwSXVjVEtNYUt3NzQxWk04?= =?utf-8?B?eXVla2cveEl4RkxmS3pWRWJWWjZnQjQ1MjhuYmpEYVJrS252NW5hb2VkSlFw?= =?utf-8?B?YUZQSGV3QzZpZEl5SzMyT1NrZXhWV3FxOW9xSXhqc3djTmhkdm1nbzk3REpr?= =?utf-8?B?NEIxVXdkQ0piNjhzK3VyV3JzV2E5Qk1LQlEyd1RDb1BtTUpIaVZJSjkxa2ps?= =?utf-8?B?OWhaMG5jZ1NqQmw5RUphWU5pYlBFU3J1cnFOTHhnRnkydEQyN1Uyd1ZDUnNl?= =?utf-8?B?UlhNR040TjltaVFqN3Foa1dGNVM4bjFMelpTVWxYTURRaHE0ZkRwTG9rc2NN?= =?utf-8?B?NFZ2YjZ1enhTaW5zdkFVbi94OG8zQ0JTU1YxRVFrVEl6Qkd1eUxXT3hSTWls?= =?utf-8?B?Vzh1RWJXVW13R0w5Zm1ieXp4YUJEN0dMb1I4cnozS0h2TFkzSkI5N3RQSWk0?= =?utf-8?B?d0FCTkxaeEtEZDJ4ODNTQWlkNXAwLzJMRGttTFFTTTRtaUs3enQvZWhLeE94?= =?utf-8?B?V0ZZS3cwUnAzcUdGVGJUMjI5MTR1VnNob3lGWVhiU0tqZ2xKZTJTeGt1bVlB?= =?utf-8?B?Qm9MNXI2eWorTnFtbUY4TjhIeUxQaEplZklpWGVVVGdIRVR5Mlo0NzVUVy9v?= =?utf-8?B?bWJmb3Rma0hpM0RYNFdaZ3RVM3NSankreFQ5SUdsaFpUQU44VVZTbGp2cElN?= =?utf-8?B?bHNJeGJjYkszWXBzQ00xZFgwWCtVSHhFWmhSeGluSFBscUREZm54Znd5enVL?= =?utf-8?B?cXNHL2szbE43dkQ0c1prQ0NlaG9OVjE0MVAreTY5UENMSjM1S0p6LzZDMFAw?= =?utf-8?B?MEFwZk81SDBMTWhtSzFXbFZpUGxMMzY3UGE2YmpGTmhrT2dlK2JoTUUvTzh0?= =?utf-8?B?M0dkSHBQUVpjN3RLNlFTVVlqTnRYVFFZUWxYenFtRXJaYjFqeFdPT2xwN2li?= =?utf-8?B?cDdyWEVBZ0hUdXNBSFZMQ2xreG82SGI4UWNIdmo5QXE3d0U0dFByRVkrZGVY?= =?utf-8?B?NUhJOEVNS1YyNXFvK1JCRmhXSEhZbFRKa0VwVk5nNHdUM1JaTkduKzkwQjNh?= =?utf-8?B?dWQ3aE5wRFNJK3ozWjBlSXArdnliRzdlUGJWWFBWWnllNzRFOU95eDlZQzNZ?= =?utf-8?B?N3lpVFpYTkUyUmdpaFhtd0k1ZWhueTUxdUlZQTlyUm5Wai9qTVQyUVJycUx0?= =?utf-8?B?a0QzZW9ONkI0OGRIOFdCT0tsdjhQTm1qNXFwMVljNVRmWE02N2E4L1RydG5i?= =?utf-8?B?MkJWOE5oaEFyQm55YXpjZmtET215c1hiUXhWTlVBYmJzVnZiRitBRnBnT0Vs?= =?utf-8?B?SmEwSHhtUllyOWdUUnJZNVpyZ2ErelUzSHNkcy9VeUhqUFhWYnZzSUd3bjB5?= =?utf-8?B?Uk5iR3l1K3AwS3VNMW9lRWF4RGQ2WlFHRTFyblhCUktrbXZCMmhDdXZsTEhD?= =?utf-8?B?ODJBZFZpY1VRangyV0luTEFTRVBjZTB2WkNQa3YrcGFYd3hwYlE5amRsMGtZ?= =?utf-8?B?MDZTOXpicEhVcWNhRDVTL1lOVHRXazRzK0hMUHozUHVzY0ZUT01sSnUzUnJv?= =?utf-8?B?ZGp5MThWT3FNbEFhYVNVdkQ2L3dLb1o5SmY0VkxZT0FDWHc2aWVONGRvMFlL?= =?utf-8?B?QkJ2czgybVh5elZzeldBRjVQV2hoQUh2S0ZJZ3FPZGRsVGRyRzdNMDUrZ1Zu?= =?utf-8?B?VVpLdVNBb0V3dlRBSXYzbmtpOUJodDEybmk3RTF3djROanFYdE9zYlp2SmJz?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7999d9-ed3b-4b38-1829-08dbd6e94b7e X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7055.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 12:36:08.7479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uEaZV8iBlvz4ueLOP/xAz75Bs/Uj0vZLzn34Her2zVvwFu8BQfX0yiKNDWxWoTs8q/jVkYRBiAG0hs644vs6fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6537 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------gDFUl6GPZyRpOkQH0QpiZTi6 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 26/10/2023 16:19, Sivaprasad Tummala wrote: > Updated the l3fwd-power app to configure the uncore env before invoking > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > too late because other APIs already called. > > Bugzilla ID: 1304 > Fixes: ac1edcb6621a ("power: refactor uncore power management API") > Cc:karen.kelly@intel.com > > Signed-off-by: Sivaprasad Tummala > --- > examples/l3fwd-power/main.c | 6 ++++++ > lib/power/rte_power_uncore.c | 7 +++++++ > lib/power/rte_power_uncore.h | 9 +++++---- > 3 files changed, 18 insertions(+), 4 deletions(-) Ran on my system, bug is resolved after applying this patch. Tested-by: Karen Kelly --------------gDFUl6GPZyRpOkQH0QpiZTi6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 26/10/2023 16:19, Sivaprasad Tummala wrote:
Updated the l3fwd-power app to configure the uncore env before invoking
any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
too late because other APIs already called.

Bugzilla ID: 1304
Fixes: ac1edcb6621a ("power: refactor uncore power management API")
Cc: karen.kelly@intel.com

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 examples/l3fwd-power/main.c  | 6 ++++++
 lib/power/rte_power_uncore.c | 7 +++++++
 lib/power/rte_power_uncore.h | 9 +++++----
 3 files changed, 18 insertions(+), 4 deletions(-)
Ran on my system, bug is resolved after applying this patch.

Tested-by: Karen Kelly <karen.kelly@intel.com>

--------------gDFUl6GPZyRpOkQH0QpiZTi6--