From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5977245B99;
	Tue, 22 Oct 2024 05:17:22 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D5852402CA;
	Tue, 22 Oct 2024 05:17:21 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id E0644402A3
 for <dev@dpdk.org>; Tue, 22 Oct 2024 05:17:19 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.194])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XXckF3v57z10NnJ;
 Tue, 22 Oct 2024 11:15:17 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242])
 by mail.maildlp.com (Postfix) with ESMTPS id C0858140137;
 Tue, 22 Oct 2024 11:17:17 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com
 (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 22 Oct
 2024 11:17:17 +0800
Message-ID: <2d821244-0f25-6bb3-d145-e16137ea1f9d@huawei.com>
Date: Tue, 22 Oct 2024 11:17:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v7 2/5] power: refactor uncore power management library
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
CC: <dev@dpdk.org>, <david.hunt@intel.com>, <anatoly.burakov@intel.com>,
 <radu.nicolau@intel.com>, <jerinj@marvell.com>,
 <cristian.dumitrescu@intel.com>, <konstantin.ananyev@huawei.com>,
 <ferruh.yigit@amd.com>, <gakhil@marvell.com>
References: <20241020092233.2906612-1-sivaprasad.tummala@amd.com>
 <20241021040724.3325876-1-sivaprasad.tummala@amd.com>
 <20241021040724.3325876-3-sivaprasad.tummala@amd.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <20241021040724.3325876-3-sivaprasad.tummala@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

LGTM except for one typo,
Acked-by: Huisong Li <lihuisong@huawei.com>

在 2024/10/21 12:07, Sivaprasad Tummala 写道:
> iThis patch refactors the power management library, addressing uncore
iThis --> This
> power management. The primary changes involve the creation of dedicated
> directories for each driver within 'drivers/power/uncore/*'. The
> adjustment of meson.build files enables the selective activation
> of individual drivers.
>
> This refactor significantly improves code organization, enhances
> clarity and boosts maintainability. It lays the foundation for more
> focused development on individual drivers and facilitates seamless
> integration of future enhancements, particularly the AMD uncore driver.
>
> v7:
>   - fixed build error with aarch32 gcc cross compilation
>
> v6:
>   - fixed compilation error with symbol export in API
>
> v5:
>   - fixed build errors for risc-v/ppc targets
>
> v4:
>   - fixed build error with RTE_ASSERT
>
> v3:
>   - fixed typo in header file inclusion
<...>