From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9313A42C02; Thu, 1 Jun 2023 13:37:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F8D340EF0; Thu, 1 Jun 2023 13:37:11 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 2C15240DDC; Thu, 1 Jun 2023 13:37:08 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QX3vZ2qplztQTc; Thu, 1 Jun 2023 19:34:50 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 19:37:05 +0800 Subject: Re: [PATCH v2 0/5] net/hns3: add some features and bugfixes To: Ferruh Yigit , , , , References: <20230518112944.32276-1-liudongdong3@huawei.com> <20230522131740.30043-1-liudongdong3@huawei.com> <6d6542fc-ce16-116f-605c-65ee93a3aeb9@amd.com> <6b3e80d3-fc06-cfaa-189c-813f42713f11@amd.com> CC: , , , From: Dongdong Liu Message-ID: <2d9edc96-f226-f840-b53b-7b17ff60f447@huawei.com> Date: Thu, 1 Jun 2023 19:37:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <6b3e80d3-fc06-cfaa-189c-813f42713f11@amd.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh On 2023/6/1 18:30, Ferruh Yigit wrote: > On 5/22/2023 5:15 PM, Ferruh Yigit wrote: >> On 5/22/2023 2:17 PM, Dongdong Liu wrote: >>> This patchset contains some features and bugfixes for hns3. >>> >>> v1->v2: >>> -Fix check-git-log warnings. >>> >>> Chengwen Feng (1): >>> net/hns3: fix receive multiple firmware reset interrupts >>> >>> Dengdui Huang (2): >>> net/hns3: fix loop code variable type mismatch >>> net/hns3: add Tx/Rx descriptor logs >>> >>> Huisong Li (2): >>> net/hns3: fix never set MAC flow control >>> net/hns3: add flow control autoneg for fiber port >>> >> >> Series applied to dpdk-next-net/main, thanks. >> > > There were multiple conflicts with previous "MAC flow control" feature, > can you please double check the latest code in next-net? I have checked the latest code in next-net, it looks good. Thanks for helping to resolve the conflicts. > > Like in 'struct hns3_sfp_info_cmd', it wasn't clear which reserved field > to use for 'fec_ability', after 'pause_status' split the reserved field > into two, etc... The latest code in next-net is right. Thanks, Dongdong. > . >