From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80DA9A04BB; Tue, 6 Oct 2020 18:05:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A64071BACC; Tue, 6 Oct 2020 18:05:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id DEAEB1BA9A for ; Tue, 6 Oct 2020 18:05:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602000309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AFJp4tbzs5ym0FHurmisTfy5UU6e5fklFuwwTvxe+8o=; b=frJztkIx+cPvEZwfvSh+aMEm4gmX0YGIfK2NVuswRz1qCpKEyHkWCl9rpNz/NpXVaAjd2v hasbfE8I415mpMtmP5AMbSfagr830qyDr/z3iO4qh6k7WcxvvYFW0I2bh8NOjGHizfDsC4 TcQlwu6pcr4HcChZcFB627x6V7nxiPw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-EFGk9-ljMyK8UVap6GaV8Q-1; Tue, 06 Oct 2020 12:05:08 -0400 X-MC-Unique: EFGk9-ljMyK8UVap6GaV8Q-1 Received: by mail-qt1-f197.google.com with SMTP id v33so4351413qtd.3 for ; Tue, 06 Oct 2020 09:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AFJp4tbzs5ym0FHurmisTfy5UU6e5fklFuwwTvxe+8o=; b=A09IpfMPDsWheLVA2rCLgic3XjaAQo544Mz+kSS4j261h91tjpC9ceQISVefB/OTqm VkA6nFFxotrxo9I0+BoClHMo+dKMkZc5+vo/hbUjBzSxgg/pNqO+R4pJLecLHQa5tpJJ tjcriE8cXFhDOJZwN1UswSyYX6hGBkuHgWqEJ1QEywK205J3TXJdYAZ82QFj6iFj+OLP A8jY11zrffJjmA29Z5jzlwaD4KFrLq1nXXuBUOEcj4DUs5w+Aqgj9birJGe8p16OomOp ZmYSxf4Ph+PTEMwBpV3OB6h4573W3CSbyF2KqQli0EyIdy+F7/3LyXAy0R09GWhMfKu5 aXWg== X-Gm-Message-State: AOAM531Cmvx7S2w+kIwRzOfk2PdzvIPlhRCPpZC1h5oGQ1tFtI1EhNIN dzfMLf7lDeO/vMYT1mjMeSnQwZ/bx1ZtHCipFdt0ocTrarvJKTherhrrEa8EpMpJDL3y/NU/3M7 tL08= X-Received: by 2002:ac8:7655:: with SMTP id i21mr5798121qtr.82.1602000306624; Tue, 06 Oct 2020 09:05:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjxw9EZ2Get0KNYOf1EgdpgJN/ZG5KqRCTdOM07qZFCG1+sDCs9wLtWaiUgDb3oGEfsnuoVA== X-Received: by 2002:ac8:7655:: with SMTP id i21mr5798097qtr.82.1602000306356; Tue, 06 Oct 2020 09:05:06 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id b9sm1950566qka.86.2020.10.06.09.05.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2020 09:05:05 -0700 (PDT) To: Maxime Coquelin , dev@dpdk.org, stable@dpdk.org, nicolas.chautru@intel.com References: <20201006100421.72210-1-maxime.coquelin@redhat.com> From: Tom Rix Message-ID: <2d9f26e9-41d9-d104-6010-821373222b24@redhat.com> Date: Tue, 6 Oct 2020 09:05:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201006100421.72210-1-maxime.coquelin@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 0/2] baseband: fix segfault in Intel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This change looks fine. Reviewed-by: Tom Rix In looking at the surrounding code i see the is-pf bool being found by checking the driver name. That is a fairly expensive check. Is there a better way to do that ? Tom On 10/6/20 3:04 AM, Maxime Coquelin wrote: > This series fixes segfaults in fpga_5gnr_fec and fpga_lte_fec > drivers when bbdev debug is enabled. > > Maxime Coquelin (2): > baseband/fpga_5gnr_fec: fix segfaults with debug > baseband/fpga_lte_fec: fix segfaults with debug > > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++-- > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >