From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43D3BA0A0C; Tue, 29 Jun 2021 07:16:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B539640E01; Tue, 29 Jun 2021 07:16:26 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 42C7F4069F for ; Tue, 29 Jun 2021 07:16:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="207903866" X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="207903866" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 22:16:24 -0700 X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="454732799" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 22:16:24 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Dmitry Malloy , Narcisa Ana Maria Vasile , Pallavi Kadam , Tyler Retzlaff , Nick Connolly References: <20210501171837.13282-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <2da153d6-c3c7-857b-0812-d8e740cfc0ea@intel.com> Date: Mon, 28 Jun 2021 22:16:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210501171837.13282-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [kmods PATCH 0/3] windows/virt2phys: fix paging issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/1/2021 10:18 AM, Dmitry Kozlyuk wrote: > Physical addresses exposed by virt2phys driver could become pageable. > This presents stability and security issues that prevent Microsoft > from signing virt2phys, because a signed driver would be trusted > by all end-user machines. > > Ensure that memory for which physical addresses are exposed by > virt2phys is non-pageable at least for the lifetime of the process. > As virt2phys code grows, make its development and debugging easier. > > There are other known issues that come from using PA and accessing DMA > from userspace. They are not related to virt2phys par se. It is planned > to address them later by enabling the use of IOMMU for DPDK on Windows. > > Dmitry Kozlyuk (3): > windows/virt2phys: use local time for signing > windows/virt2phys: do not expose pageable physical addresses > windows/virt2phys: add tracing > > windows/virt2phys/virt2phys.c | 89 ++++-- > windows/virt2phys/virt2phys.vcxproj | 8 +- > windows/virt2phys/virt2phys.vcxproj.filters | 11 +- > windows/virt2phys/virt2phys_logic.c | 312 ++++++++++++++++++++ > windows/virt2phys/virt2phys_logic.h | 32 ++ > windows/virt2phys/virt2phys_trace.h | 49 +++ > 6 files changed, 472 insertions(+), 29 deletions(-) > create mode 100644 windows/virt2phys/virt2phys_logic.c > create mode 100644 windows/virt2phys/virt2phys_logic.h > create mode 100644 windows/virt2phys/virt2phys_trace.h Acked-by: Ranjit Menon