From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EE11A055D; Fri, 19 Feb 2021 13:57:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3054C16090E; Fri, 19 Feb 2021 13:57:46 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2CAA916090B for ; Fri, 19 Feb 2021 13:57:44 +0100 (CET) IronPort-SDR: bJaBRv0YpEkQqGb2nTgQLwtfSYw9RC8BkSGWK1Mi8TB1dxTpZzHjudv1jJuh+jE6Aq/Qr7nPzX DKttiwYkCyYg== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="183950371" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="183950371" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 04:57:42 -0800 IronPort-SDR: IEFjb4PEykGakTdBr77JwIOkgymF4ZlB/JPTOPkfoqqOrxfuxCAG999LoS93hx9bA0UlqqYiWP BgyfKPSM1eVA== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="386900950" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.55]) ([10.213.251.55]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 04:57:40 -0800 To: Steve Yang , dev@dpdk.org Cc: jia.guo@intel.com, haiyue.wang@intel.com, qiming.yang@intel.com, beilei.xing@intel.com, orika@nvidia.com, murphyx.yang@intel.com References: <20201014084131.72035-1-simonx.lu@intel.com> <20201103082809.41149-1-stevex.yang@intel.com> <20201103082809.41149-6-stevex.yang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2dafd4f1-6eb9-7a28-ff16-bab939a89318@intel.com> Date: Fri, 19 Feb 2021 12:57:39 +0000 MIME-Version: 1.0 In-Reply-To: <20201103082809.41149-6-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC v2 5/6] net/ixgbe: define the mirror filter parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 8:28 AM, Steve Yang wrote: > Define the sample filter parser for mirror, it will divide to two phases, > the one is sample attributions pattern parsing, and the mirror config > will be filled in according to pattern type VF/PF/VLAN when sample ratio > is 1. > The another is sample action parsing that the port id of mirror config > will be filled in according to action type VF/PF. > > Signed-off-by: Steve Yang <...> > + > +#define GET_VLAN_ID_FROM_TCI(vlan_item, default_vid) \ > + ((vlan_item) ? ntohs((vlan_item)->tci) & 0x0fff : (default_vid)) > + Although ixgbe is not build for windows, better to use 'IXGBE_NTOHS' for consistency. > /* ntuple filter list structure */ > struct ixgbe_ntuple_filter_ele { > TAILQ_ENTRY(ixgbe_ntuple_filter_ele) entries; > @@ -79,6 +91,11 @@ struct ixgbe_rss_conf_ele { > TAILQ_ENTRY(ixgbe_rss_conf_ele) entries; > struct ixgbe_rte_flow_rss_conf filter_info; > }; > +/* rss filter list structure */ copy/paste error? <...> > + if (attr->group) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ATTR_GROUP, > + attr, "Not support group."); > + return -rte_errno; > + } > + if (attr->transfer) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, > + attr, "Not support group."); copy/paste error?