From: Paul Szczepanek <paul.szczepanek@arm.com>
To: Luca Vizzarro <Luca.Vizzarro@arm.com>,
Dean Marx <dmarx@iol.unh.edu>,
probb@iol.unh.edu, npratte@iol.unh.edu, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com
Cc: nd@arm.com, dev@dpdk.org
Subject: Re: [PATCH v5] dts: reform hello world test suite
Date: Wed, 15 Jan 2025 12:53:32 +0000 [thread overview]
Message-ID: <2dd4cb4a-f26c-49e9-a6f3-62736c56c9a5@arm.com> (raw)
In-Reply-To: <977b0f3a-daf8-490b-a731-824cd9ef03e1@arm.com>
I think it makes sense to keep logger private and separate. I can see
one reason - we can change the logger in the framework without affecting
the tests. We can also decide to not use the logger to print test suites
messages - for example save per test artifacts.
On 15/01/2025 10:17, Luca Vizzarro wrote:
> Sorry for the late reply Dean. This is a bit redundant in my opinion,
> there is no reason not to give full access to the test suite's own
> logger. I'd just change TestSuite._logger into TestSuite.logger to
> indicate that it's a public member, and do what you initially did.
next prev parent reply other threads:[~2025-01-15 12:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 21:54 [PATCH v1 0/1] dts: add EAL sanity check suite Dean Marx
2024-12-09 21:54 ` [PATCH v1 1/1] " Dean Marx
2024-12-20 15:49 ` Paul Szczepanek
2024-12-20 16:21 ` Stephen Hemminger
2024-12-23 18:57 ` [PATCH v2 1/1] dts: add EAL confidence " Dean Marx
2024-12-23 18:50 ` Patrick Robb
2025-01-06 17:58 ` [PATCH v3] dts: reform hello world test suite Dean Marx
2025-01-07 16:37 ` Luca Vizzarro
2025-01-07 16:49 ` Patrick Robb
2025-01-07 21:34 ` [PATCH v4] " Dean Marx
2025-01-08 9:07 ` Paul Szczepanek
2025-01-10 19:28 ` [PATCH v5] " Dean Marx
2025-01-15 10:17 ` Luca Vizzarro
2025-01-15 12:53 ` Paul Szczepanek [this message]
2025-01-15 14:42 ` Luca Vizzarro
2025-01-15 15:19 ` Dean Marx
2025-01-15 15:51 ` [PATCH v6] " Dean Marx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd4cb4a-f26c-49e9-a6f3-62736c56c9a5@arm.com \
--to=paul.szczepanek@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=nd@arm.com \
--cc=npratte@iol.unh.edu \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).