From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <maxime.coquelin@redhat.com> Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 979B21CBAD for <dev@dpdk.org>; Thu, 5 Apr 2018 15:42:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D59CEBFE5; Thu, 5 Apr 2018 13:42:55 +0000 (UTC) Received: from [10.36.112.49] (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62A36AB3F3; Thu, 5 Apr 2018 13:42:49 +0000 (UTC) To: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org Cc: tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-2-jfreimann@redhat.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <2ddbca32-e7b6-e2a4-5785-ea283f34086b@redhat.com> Date: Thu, 5 Apr 2018 15:42:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180405101031.26468-2-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 05 Apr 2018 13:42:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 05 Apr 2018 13:42:55 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 01/21] net/virtio: by default disable packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 05 Apr 2018 13:42:55 -0000 On 04/05/2018 12:10 PM, Jens Freimann wrote: > Disable packed virtqueues for now and make it dependend on a build-time > config option. This can be reverted once we have missing features like > indirect descriptors implemented. > > Signed-off-by: Jens Freimann <jfreimann@redhat.com> > --- > config/common_base | 1 + > drivers/net/virtio/virtio_ethdev.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/config/common_base b/config/common_base > index c09c7cf88..cd4b419b4 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -346,6 +346,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_PMD=y > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > +CONFIG_RTE_LIBRTE_VIRTIO_PQ=n > > # > # Compile virtio device emulation inside virtio PMD driver > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 11f758929..06fbf7311 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1149,6 +1149,10 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) > req_features &= ~(1ULL << VIRTIO_NET_F_MTU); > } > > +#ifndef RTE_LIBRTE_VIRTIO_PQ > + req_features &= ~(1ull << VIRTIO_F_RING_PACKED); Is VIRTIO_F_RING_PACKED already declared here? I don't think it is, so would break build when bisecting. Maybe the thing to do is to not have VIRTIO_F_RING_PACKED in the feature set by default. And when RTE_LIBRTE_VIRTIO_PQ is set, enable it and explicitly disable indirect descs. > +#endif > + > /* > * Negotiate features: Subset of device feature bits are written back > * guest feature bits. >