From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 418AAA04B5; Thu, 10 Sep 2020 04:04:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2850C1BFB4; Thu, 10 Sep 2020 04:04:35 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) by dpdk.org (Postfix) with ESMTP id 867CD2BA8 for ; Thu, 10 Sep 2020 04:04:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DdEqb8dalXpf8J9uIxyI5tITauPhoY830cpVlf5i11eixcNrowy6J8DGiY8uzNA9JbhmFQ4BXc9/pj7Cio3JzU83c8plhHEhmC11Go7cHXN4Er/uCjwq9dx4Oo0NGWMU9/nNUewKCGkmdtT3mONAz8PcbZRwHEDvztBlFcv+QFjitQhIamfPNnQnwHoaVuRPmS8uAly3MA5N67tg/znKhsAtCcsmJWwu7l8gYiomTepbH3sGlonpFQD0EZaLBT0te7OKnmnqGtGyeClRPOeqnNIbAU0oE3am0o/NKsgiSeN50aw7JkKGZZ+1rgZnZx2uaXAlMP20v36TgtNjBEBWLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLk1nMCtFLg2CXG2QmrTDKJ02DHHmEuCNGoumTiNrSQ=; b=lLfSKuHzOmQl5f/8f773s2dXrmk2aoJqsHJPaT3K4S8GnWmPraDSkKuly7A0k7VnvM54zrTSu1pSJxS1liDQSqgVp0sUsukUTWi7Y0Hh5YqpN2EbhnmVbASw6NklKdbDP4EjrQmbWnj95uG58sNMyxR4tUFKQ40fEw18l7wEQM2sV77pZY08p/If2W6IgiGPNBaAa4AO+XJWlV5eQEsx48/7HIQXrz+QYA2ed1Bai0FusmRHOSiPB6eoMplxOa5Myg1kKlFDvUzCsug328GP6c0TfUb2YS6OXOGcmAFxXcfQSXgeKrxcXi/EPyo35eruHFnVOoH3j0YI3+5gCL3new== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLk1nMCtFLg2CXG2QmrTDKJ02DHHmEuCNGoumTiNrSQ=; b=MvMi+7ANZeGzzSYHPYfPBv+QkVqDhHTK7ySJK2jNbKkIGDC+j+1ZintPLSLA+ElO2DeA6r6VZ/iEeiqpR0X9PQ0BbbcmkT5wlTRk6G3+MMzTGtLlZLuJFo1/zYgprc1xXX2Q5W1SmLcXPNl7Kw3JtpMQkU7jRjUrJNCAdPqQehk= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) by VE1PR04MB7342.eurprd04.prod.outlook.com (2603:10a6:800:1a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep 2020 02:04:32 +0000 Received: from VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3348.019; Thu, 10 Sep 2020 02:04:32 +0000 To: dev@dpdk.org References: <20200824094021.2323605-1-ferruh.yigit@intel.com> <20200909130148.1756518-1-ferruh.yigit@intel.com> <20200909130148.1756518-7-ferruh.yigit@intel.com> From: "Sachin Saxena (OSS)" Message-ID: <2de62eba-99ab-ed09-e32d-ef7315ca7501@oss.nxp.com> Date: Thu, 10 Sep 2020 07:34:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <20200909130148.1756518-7-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: SG2PR0302CA0010.apcprd03.prod.outlook.com (2603:1096:3:2::20) To VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.3] (106.201.0.162) by SG2PR0302CA0010.apcprd03.prod.outlook.com (2603:1096:3:2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.5 via Frontend Transport; Thu, 10 Sep 2020 02:04:30 +0000 X-Originating-IP: [106.201.0.162] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 77f35493-fdfe-48ae-0015-08d8552ddb56 X-MS-TrafficTypeDiagnostic: VE1PR04MB7342: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wqJ1gqEALBaQxEemyxwDve9D1NwJhG0Qc0PFiR8zePkqvy9bxGhtasS1e1RV/Zkz+v4ecmB3fvlpdHQUlB6S/JDPdNCZrJnyF7O1BMeqapGbx1hTMQ9xDg76MlJC3mEqbAAu1hWqrqMNLUBIRC9N1bSSLrG/Rwnnq8T9csdYRVeg6ephbhucqp5h9Q10yLPjEFHWsKGTxr+bafkzB/fqMA0hj9j2cqfHVJiSG5bD5w1MngPj3oqyBMaX3uOECTBv3R8f4KabrowNPlNQxqWLFgpblhzMKfIAwzM6h5eR6MlfiwviikDDgwSnQWWkL80BNml5YphjoQ4Og38FLl5IsVe8bnGakukgtOvZM5Klysf5UFMTq7I/BWT3zjdtvjtJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(478600001)(5660300002)(53546011)(2616005)(86362001)(16526019)(186003)(52116002)(31686004)(30864003)(55236004)(6916009)(66946007)(66476007)(66556008)(316002)(16576012)(1006002)(6666004)(31696002)(956004)(26005)(6486002)(2906002)(83380400001)(8676002)(8936002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: yro7x6CZ8r9wjsnF6ZXPj5hl/v9rb0eCbMISwWhgKkGLv3xaSFN3OnKP7ULli050Rz4JGO2oK1ZaK5GYK63oCiN7Gl6TNLCbhCCQWhG9A/0jJzVhLb4fEe2ZO6LLPztD2tBuqlzZ2yDx2iBrh3yWJwb8OaUovUMEMRzY6fwejjW5b4dZ8FqNVtoXQoPt9H5hO6WhJmf7TwoHqAe9wTNLba16591irkZrUx2N8a0QDKfoJVh8P/HrjvujPj/QU+jxnTTWOgfuqfOY8D8oc4LFx+58SHXD9GbdCstoX0wT9BM8lCX9THOxWIK1lNwcXGkIX8lWsr2UWljVIBSSBaVxK9gfIryKJEPK+SmLPov9zwEXYT/oWsd3YscDUC9dVnuKHFxy+IMxwBlSjUslTfybNHe2ijg83VpdePgELWvtUY6cILBGPsChVQIl6zpo/KR6PP0EQxeDgnrjLYPx3Mbp6xVbM1QnACdPrB3snjvn5GgbJtjYKDh2VlOrvVX/n2GoU43WcU60umEYaKVXuTmzlFgIFrhCqb8wQdLfzScqZuxt7FHuzWK5z5mjgp/ImTQDmoqmsAtk+mz2Xc1Fdl+H7rPEH6RikKgN6IqgfMj7MWq5C2e4IC9NJa4+0t1X5DPTuXV7Y+hIf9FdTAq44G8Mkw== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77f35493-fdfe-48ae-0015-08d8552ddb56 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5837.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2020 02:04:31.9058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EVoptM9mjAR1jH3QfTsX+WgQRCIBpdlQTvRe9Uu+YAxAY/jCavYa6r2Ha9v5MCUf5Bj7CHr19W+7RyFlyzbwfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7342 Subject: Re: [dpdk-dev] [PATCH v4 7/7] ethdev: remove underscore prefix from internal API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: > '_rte_eth_dev_callback_process()' & '_rte_eth_dev_reset()' internal APIs > has unconventional underscore ('_') prefix. > Although this is not documented most probably this is to mark them as > internal. Since we have '__rte_internal' flag to mark this, removing '_' > from API names. > > For '_rte_eth_dev_reset()', there is already a public API named > 'rte_eth_dev_reset()', so renaming '_rte_eth_dev_reset()' to > 'rte_eth_dev_internal_reset'. > > Signed-off-by: Ferruh Yigit > Acked-by: Andrew Rybchenko > Acked-by: David Marchand > --- > v3: > * release note updated > --- > app/test/virtual_pmd.c | 4 ++-- > doc/guides/prog_guide/poll_mode_drv.rst | 4 ++-- > doc/guides/rel_notes/release_20_11.rst | 5 +++++ > drivers/net/atlantic/atl_ethdev.c | 5 ++--- > drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- > drivers/net/bnxt/rte_pmd_bnxt.c | 4 ++-- > drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++---- > drivers/net/dpaa/dpaa_ethdev.c | 2 +- > drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/e1000/igb_ethdev.c | 7 +++---- > drivers/net/ena/ena_ethdev.c | 4 ++-- > drivers/net/enic/enic_main.c | 2 +- > drivers/net/failsafe/failsafe_ether.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 11 ++++------- > drivers/net/hinic/base/hinic_pmd_hwdev.c | 6 +++--- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev_vf.c | 4 ++-- > drivers/net/i40e/i40e_pf.c | 2 +- > drivers/net/iavf/iavf_vchnl.c | 5 ++--- > drivers/net/ice/ice_ethdev.c | 4 ++-- > drivers/net/igc/igc_ethdev.c | 3 +-- > drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++++------ > drivers/net/ixgbe/ixgbe_pf.c | 5 ++--- > drivers/net/mlx4/mlx4_intr.c | 10 +++++----- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 4 ++-- > drivers/net/mlx5/mlx5_flow.c | 2 +- > drivers/net/netvsc/hn_rndis.c | 2 +- > drivers/net/nfp/nfp_net.c | 2 +- > drivers/net/octeontx/octeontx_ethdev.c | 6 +++--- > drivers/net/octeontx2/otx2_link.c | 2 +- > drivers/net/qede/qede_main.c | 3 +-- > drivers/net/sfc/sfc_intr.c | 12 ++++++------ > drivers/net/thunderx/nicvf_ethdev.c | 6 +++--- > drivers/net/vhost/rte_eth_vhost.c | 6 +++--- > drivers/net/virtio/virtio_ethdev.c | 6 +++--- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 +++--- > lib/librte_ethdev/rte_ethdev.c | 8 ++++---- > lib/librte_ethdev/rte_ethdev_driver.h | 4 ++-- > lib/librte_ethdev/rte_ethdev_version.map | 4 ++-- > 40 files changed, 95 insertions(+), 102 deletions(-) > > diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c > index 79156cb85a..b49089a33c 100644 > --- a/app/test/virtual_pmd.c > +++ b/app/test/virtual_pmd.c > @@ -474,8 +474,8 @@ virtual_ethdev_simulate_link_status_interrupt(uint16_t port_id, > > vrtl_eth_dev->data->dev_link.link_status = link_status; > > - _rte_eth_dev_callback_process(vrtl_eth_dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(vrtl_eth_dev, RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > > int > diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst > index 6fae39f904..86e0a141e6 100644 > --- a/doc/guides/prog_guide/poll_mode_drv.rst > +++ b/doc/guides/prog_guide/poll_mode_drv.rst > @@ -600,9 +600,9 @@ thread safety all these operations should be called from the same thread. > For example when PF is reset, the PF sends a message to notify VFs of > this event and also trigger an interrupt to VFs. Then in the interrupt > service routine the VFs detects this notification message and calls > -_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, NULL). > +rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, NULL). > This means that a PF reset triggers an RTE_ETH_EVENT_INTR_RESET > -event within VFs. The function _rte_eth_dev_callback_process() will > +event within VFs. The function rte_eth_dev_callback_process() will > call the registered callback function. The callback function can trigger > the application to handle all operations the VF reset requires including > stopping Rx/Tx queues and calling rte_eth_dev_reset(). > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index f8c3521b3f..7ff6ac23b6 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -86,6 +86,11 @@ API Changes > > * ``rte_eth_rx_descriptor_done()`` API has deprecated. > > +* Renamed internal ethdev APIs: > + > + * ``_rte_eth_dev_callback_process()`` -> ``rte_eth_dev_callback_process()`` > + * ``_rte_eth_dev_reset`` -> ``rte_eth_dev_internal_reset()`` > + > > ABI Changes > ----------- > diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c > index 540b106045..2fca9140d7 100644 > --- a/drivers/net/atlantic/atl_ethdev.c > +++ b/drivers/net/atlantic/atl_ethdev.c > @@ -1395,8 +1395,7 @@ atl_dev_interrupt_action(struct rte_eth_dev *dev, > /* Notify userapp if link status changed */ > if (!atl_dev_link_update(dev, 0)) { > atl_dev_link_status_print(dev); > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } else { > if (hw->aq_fw_ops->send_macsec_req == NULL) > goto done; > @@ -1422,7 +1421,7 @@ atl_dev_interrupt_action(struct rte_eth_dev *dev, > resp.stats.egress_expired || > resp.stats.ingress_expired) { > PMD_DRV_LOG(INFO, "RTE_ETH_EVENT_MACSEC"); > - _rte_eth_dev_callback_process(dev, > + rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_MACSEC, NULL); > } > } > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 4d224bfa04..8c959ac913 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1528,9 +1528,9 @@ int bnxt_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete, > new.link_speed != eth_dev->data->dev_link.link_speed) { > rte_eth_linkstatus_set(eth_dev, &new); > > - _rte_eth_dev_callback_process(eth_dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(eth_dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > > bnxt_print_link_info(eth_dev); > } > diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c > index eafc1d3868..d67db46c65 100644 > --- a/drivers/net/bnxt/rte_pmd_bnxt.c > +++ b/drivers/net/bnxt/rte_pmd_bnxt.c > @@ -28,8 +28,8 @@ int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg) > ret_param.vf_id = vf_id; > ret_param.msg = msg; > > - _rte_eth_dev_callback_process(bp->eth_dev, RTE_ETH_EVENT_VF_MBOX, > - &ret_param); > + rte_eth_dev_callback_process(bp->eth_dev, RTE_ETH_EVENT_VF_MBOX, > + &ret_param); > > /* Default to approve */ > if (ret_param.retval == RTE_PMD_BNXT_MB_EVENT_PROCEED) > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index cdbd8151ed..4ffd2ca4bb 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1879,7 +1879,7 @@ slave_remove(struct bond_dev_private *internals, > internals->slave_count--; > > /* force reconfiguration of slave interfaces */ > - _rte_eth_dev_reset(slave_eth_dev); > + rte_eth_dev_internal_reset(slave_eth_dev); > } > > static void > @@ -2765,7 +2765,7 @@ bond_ethdev_delayed_lsc_propagation(void *arg) > if (arg == NULL) > return; > > - _rte_eth_dev_callback_process((struct rte_eth_dev *)arg, > + rte_eth_dev_callback_process((struct rte_eth_dev *)arg, > RTE_ETH_EVENT_INTR_LSC, NULL); > } > > @@ -2900,7 +2900,7 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, > bond_ethdev_delayed_lsc_propagation, > (void *)bonded_eth_dev); > else > - _rte_eth_dev_callback_process(bonded_eth_dev, > + rte_eth_dev_callback_process(bonded_eth_dev, > RTE_ETH_EVENT_INTR_LSC, > NULL); > > @@ -2910,7 +2910,7 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, > bond_ethdev_delayed_lsc_propagation, > (void *)bonded_eth_dev); > else > - _rte_eth_dev_callback_process(bonded_eth_dev, > + rte_eth_dev_callback_process(bonded_eth_dev, > RTE_ETH_EVENT_INTR_LSC, > NULL); > } > diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c > index e2c3fd0368..a077b98c3e 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c > @@ -335,7 +335,7 @@ static void dpaa_interrupt_handler(void *param) > if (bytes_read < 0) > DPAA_PMD_ERR("Error reading eventfd\n"); > dpaa_eth_link_update(dev, 0); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static int dpaa_eth_dev_start(struct rte_eth_dev *dev) > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index 38cf0ab71c..0e9f836e55 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -1065,8 +1065,7 @@ dpaa2_interrupt_handler(void *param) > clear = DPNI_IRQ_EVENT_LINK_CHANGED; > dpaa2_dev_link_update(dev, 0); > /* calling all the apps registered for link status event */ > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > out: > ret = dpni_clear_irq_status(dpni, CMD_PRI_LOW, priv->token, > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c > index 82766da882..1dc360713a 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -1630,7 +1630,7 @@ eth_em_interrupt_handler(void *param) > > eth_em_interrupt_get_status(dev); > eth_em_interrupt_action(dev, dev->intr_handle); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static int > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c > index fe0cea88c2..5ab74840aa 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -2920,8 +2920,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev, > pci_dev->addr.bus, > pci_dev->addr.devid, > pci_dev->addr.function); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > return 0; > @@ -2983,8 +2982,8 @@ void igbvf_mbx_process(struct rte_eth_dev *dev) > /* dummy mbx read to ack pf */ > if (mbx->ops.read(hw, &in_msg, 1, 0)) > return; > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > + NULL); > } > } > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index da8c8ad922..8077519735 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1621,7 +1621,7 @@ static void ena_timer_wd_callback(__rte_unused struct rte_timer *timer, > > if (unlikely(adapter->trigger_reset)) { > PMD_DRV_LOG(ERR, "Trigger reset is on\n"); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > NULL); > } > } > @@ -2867,7 +2867,7 @@ static void ena_update_on_link_change(void *adapter_data, > adapter->link_status = status; > > ena_link_update(eth_dev, 0); > - _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static void ena_notification(void *data, > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c > index 7942b0df6b..8b0441c5cd 100644 > --- a/drivers/net/enic/enic_main.c > +++ b/drivers/net/enic/enic_main.c > @@ -445,7 +445,7 @@ enic_intr_handler(void *arg) > vnic_intr_return_all_credits(&enic->intr[ENICPMD_LSC_INTR_OFFSET]); > > enic_link_update(dev); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > enic_log_q_error(enic); > /* Re-enable irq in case of INTx */ > rte_intr_ack(&enic->pdev->intr_handle); > diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c > index 70972d6717..7c68bbdec0 100644 > --- a/drivers/net/failsafe/failsafe_ether.c > +++ b/drivers/net/failsafe/failsafe_ether.c > @@ -602,9 +602,9 @@ failsafe_eth_lsc_event_callback(uint16_t port_id __rte_unused, > ret = dev->dev_ops->link_update(dev, 0); > /* We must pass on the LSC event */ > if (ret) > - return _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + return rte_eth_dev_callback_process(dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > else > return 0; > } > diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c > index e6043e1455..5771d83b55 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -2621,7 +2621,7 @@ fm10k_dev_interrupt_handler_pf(void *param) > true); > > dev_info->sm_down = 0; > - _rte_eth_dev_callback_process(dev, > + rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC, > NULL); > } > @@ -2635,8 +2635,7 @@ fm10k_dev_interrupt_handler_pf(void *param) > if (err == FM10K_ERR_RESET_REQUESTED) { > PMD_INIT_LOG(INFO, "INT: Switch is down"); > dev_info->sm_down = 1; > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > /* Handle SRAM error */ > @@ -2703,8 +2702,7 @@ fm10k_dev_interrupt_handler_vf(void *param) > > /* Setting reset flag */ > dev_info->sm_down = 1; > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > if (dev_info->sm_down == 1 && > @@ -2732,8 +2730,7 @@ fm10k_dev_interrupt_handler_vf(void *param) > fm10k_vlan_filter_set(dev, hw->mac.default_vid, true); > > dev_info->sm_down = 0; > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > /* Re-enable interrupt from device side */ > diff --git a/drivers/net/hinic/base/hinic_pmd_hwdev.c b/drivers/net/hinic/base/hinic_pmd_hwdev.c > index ac2a72e388..41c99bdbf8 100644 > --- a/drivers/net/hinic/base/hinic_pmd_hwdev.c > +++ b/drivers/net/hinic/base/hinic_pmd_hwdev.c > @@ -1362,9 +1362,9 @@ static void hinic_lsc_process(struct hinic_hwdev *hwdev, > ret = hinic_link_event_process(hwdev, rte_dev, status); > /* check if link has changed, notify callback */ > if (ret == 0) > - _rte_eth_dev_callback_process(rte_dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(rte_dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > > void hinic_l2nic_async_event_handle(struct hinic_hwdev *hwdev, > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 80efd06cd9..563f21d9df 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -6846,7 +6846,7 @@ i40e_dev_handle_aq_msg(struct rte_eth_dev *dev) > case i40e_aqc_opc_get_link_status: > ret = i40e_dev_link_update(dev, 0); > if (!ret) > - _rte_eth_dev_callback_process(dev, > + rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC, NULL); > break; > default: > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index be4b28fa45..8531cf6b12 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1378,7 +1378,7 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg, > switch (pf_msg->event) { > case VIRTCHNL_EVENT_RESET_IMPENDING: > PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event"); > - _rte_eth_dev_callback_process(dev, > + rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, NULL); > break; > case VIRTCHNL_EVENT_LINK_CHANGE: > @@ -1425,7 +1425,7 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg, > } > > i40evf_dev_link_update(dev, 0); > - _rte_eth_dev_callback_process(dev, > + rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC, NULL); > break; > case VIRTCHNL_EVENT_PF_DRIVER_CLOSE: > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > index 7bf1e79410..03c2070c3f 100644 > --- a/drivers/net/i40e/i40e_pf.c > +++ b/drivers/net/i40e/i40e_pf.c > @@ -1363,7 +1363,7 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev, > * do nothing and send not_supported to VF. As PF must send a response > * to VF and ACK/NACK is not defined. > */ > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, &ret_param); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, &ret_param); > if (ret_param.retval != RTE_PMD_I40E_MB_EVENT_PROCEED) { > PMD_DRV_LOG(WARNING, "VF to PF message(%d) is not permitted!", > opcode); > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c > index 34c31a153a..29e4cae10c 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -187,7 +187,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, uint8_t *msg, > switch (pf_msg->event) { > case VIRTCHNL_EVENT_RESET_IMPENDING: > PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event"); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > NULL); > break; > case VIRTCHNL_EVENT_LINK_CHANGE: > @@ -202,8 +202,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, uint8_t *msg, > vf->link_speed = iavf_convert_link_speed(speed); > } > iavf_dev_link_update(dev, 0); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > break; > case VIRTCHNL_EVENT_PF_DRIVER_CLOSE: > PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event"); > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index c8b16c7f87..724b2ee26c 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -1314,7 +1314,7 @@ ice_handle_aq_msg(struct rte_eth_dev *dev) > case ice_aqc_opc_get_link_status: > ret = ice_link_update(dev, 0); > if (!ret) > - _rte_eth_dev_callback_process > + rte_eth_dev_callback_process > (dev, RTE_ETH_EVENT_INTR_LSC, NULL); > break; > default: > @@ -1379,7 +1379,7 @@ ice_interrupt_handler(void *param) > PMD_DRV_LOG(INFO, "OICR: link state change event"); > ret = ice_link_update(dev, 0); > if (!ret) > - _rte_eth_dev_callback_process > + rte_eth_dev_callback_process > (dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > #endif > diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c > index aa37c11861..810568bc54 100644 > --- a/drivers/net/igc/igc_ethdev.c > +++ b/drivers/net/igc/igc_ethdev.c > @@ -540,8 +540,7 @@ eth_igc_interrupt_action(struct rte_eth_dev *dev) > pci_dev->addr.bus, > pci_dev->addr.devid, > pci_dev->addr.function); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > } > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 337ce90fbf..0f065bbc04 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4659,13 +4659,11 @@ ixgbe_dev_interrupt_delayed_handler(void *param) > ixgbe_dev_link_update(dev, 0); > intr->flags &= ~IXGBE_FLAG_NEED_LINK_UPDATE; > ixgbe_dev_link_status_print(dev); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > if (intr->flags & IXGBE_FLAG_MACSEC) { > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_MACSEC, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_MACSEC, NULL); > intr->flags &= ~IXGBE_FLAG_MACSEC; > } > > @@ -8674,8 +8672,8 @@ static void ixgbevf_mbx_process(struct rte_eth_dev *dev) > /* dummy mbx read to ack pf */ > if (ixgbe_read_mbx(hw, &in_msg, 1, 0)) > return; > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > - NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > + NULL); > } > } > > diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c > index 67b5bef44f..ed5f96b1a4 100644 > --- a/drivers/net/ixgbe/ixgbe_pf.c > +++ b/drivers/net/ixgbe/ixgbe_pf.c > @@ -832,7 +832,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > vfinfo[vf].clear_to_send = true; > > /* notify application about VF reset */ > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, > &ret_param); > return ret; > } > @@ -844,8 +844,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > * if 0, do nothing and send ACK to VF > * if ret_param.retval > 1, do nothing and send NAK to VF > */ > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, > - &ret_param); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, &ret_param); > > retval = ret_param.retval; > > diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c > index 19af9359c9..6786b12ab5 100644 > --- a/drivers/net/mlx4/mlx4_intr.c > +++ b/drivers/net/mlx4/mlx4_intr.c > @@ -124,9 +124,9 @@ mlx4_link_status_alarm(struct mlx4_priv *priv) > MLX4_ASSERT(priv->intr_alarm == 1); > priv->intr_alarm = 0; > if (intr_conf->lsc && !mlx4_link_status_check(priv)) > - _rte_eth_dev_callback_process(ETH_DEV(priv), > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(ETH_DEV(priv), > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > > /** > @@ -207,8 +207,8 @@ mlx4_interrupt_handler(struct mlx4_priv *priv) > } > for (i = 0; i != RTE_DIM(caught); ++i) > if (caught[i]) > - _rte_eth_dev_callback_process(ETH_DEV(priv), type[i], > - NULL); > + rte_eth_dev_callback_process(ETH_DEV(priv), type[i], > + NULL); > } > > /** > diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > index 3d3dd2e862..7256c1bcfe 100644 > --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c > +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > @@ -732,7 +732,7 @@ mlx5_dev_interrupt_device_fatal(struct mlx5_dev_ctx_shared *sh) > dev = &rte_eth_devices[sh->port[i].ih_port_id]; > MLX5_ASSERT(dev); > if (dev->data->dev_conf.intr_conf.rmv) > - _rte_eth_dev_callback_process > + rte_eth_dev_callback_process > (dev, RTE_ETH_EVENT_INTR_RMV, NULL); > } > } > @@ -808,7 +808,7 @@ mlx5_dev_interrupt_handler(void *cb_arg) > usleep(0); > continue; > } > - _rte_eth_dev_callback_process > + rte_eth_dev_callback_process > (dev, RTE_ETH_EVENT_INTR_LSC, NULL); > continue; > } > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index eb55bd7f99..55cdc37f00 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -6085,7 +6085,7 @@ mlx5_flow_aging_check(struct mlx5_dev_ctx_shared *sh, > if (!MLX5_AGE_GET(age_info, MLX5_AGE_EVENT_NEW)) > continue; > if (MLX5_AGE_GET(age_info, MLX5_AGE_TRIGGER)) > - _rte_eth_dev_callback_process > + rte_eth_dev_callback_process > (&rte_eth_devices[sh->port[i].devx_ih_port_id], > RTE_ETH_EVENT_FLOW_AGED, NULL); > age_info->flags = 0; > diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c > index d186ddeabd..66d1966f29 100644 > --- a/drivers/net/netvsc/hn_rndis.c > +++ b/drivers/net/netvsc/hn_rndis.c > @@ -292,7 +292,7 @@ static int hn_nvs_send_rndis_ctrl(struct vmbus_channel *chan, > */ > static void hn_rndis_link_alarm(void *arg) > { > - _rte_eth_dev_callback_process(arg, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(arg, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg) > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index c556dedab6..4f03691989 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1460,7 +1460,7 @@ nfp_net_dev_interrupt_delayed_handler(void *param) > struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > > nfp_net_link_update(dev, 0); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > > nfp_net_dev_link_status_print(dev); > > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c > index 76c69294d0..808b761b96 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -227,9 +227,9 @@ octeontx_link_status_poll(void *arg) > octeontx_link_status_update(nic, &link); > octeontx_link_status_print(dev, &link); > rte_eth_linkstatus_set(dev, &link); > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > } > > diff --git a/drivers/net/octeontx2/otx2_link.c b/drivers/net/octeontx2/otx2_link.c > index 12bf6c3231..439ec4fa89 100644 > --- a/drivers/net/octeontx2/otx2_link.c > +++ b/drivers/net/octeontx2/otx2_link.c > @@ -82,7 +82,7 @@ otx2_eth_dev_link_status_update(struct otx2_dev *dev, > rte_eth_linkstatus_set(eth_dev, ð_link); > > /* Set the flag and execute application callbacks */ > - _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static int > diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c > index 987a6f1e13..aecb98261b 100644 > --- a/drivers/net/qede/qede_main.c > +++ b/drivers/net/qede/qede_main.c > @@ -650,8 +650,7 @@ void qed_link_update(struct ecore_hwfn *hwfn) > struct rte_eth_dev *dev = (struct rte_eth_dev *)qdev->ethdev; > > if (!qede_link_update(dev, 0)) > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static int qed_drain(struct ecore_dev *edev) > diff --git a/drivers/net/sfc/sfc_intr.c b/drivers/net/sfc/sfc_intr.c > index 80feab68f8..da32d393c2 100644 > --- a/drivers/net/sfc/sfc_intr.c > +++ b/drivers/net/sfc/sfc_intr.c > @@ -89,9 +89,9 @@ sfc_intr_line_handler(void *cb_arg) > sfc_notice(sa, "link status change event: link %s", > sa->eth_dev->data->dev_link.link_status ? > "UP" : "DOWN"); > - _rte_eth_dev_callback_process(sa->eth_dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(sa->eth_dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > } > > @@ -131,9 +131,9 @@ sfc_intr_message_handler(void *cb_arg) > exit: > if (lsc_seq != sa->port.lsc_seq) { > sfc_notice(sa, "link status change event"); > - _rte_eth_dev_callback_process(sa->eth_dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(sa->eth_dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > } > > diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c > index 959c8e4ddc..83d9488360 100644 > --- a/drivers/net/thunderx/nicvf_ethdev.c > +++ b/drivers/net/thunderx/nicvf_ethdev.c > @@ -83,9 +83,9 @@ nicvf_interrupt(void *arg) > nicvf_link_status_update(nic, &link); > rte_eth_linkstatus_set(dev, &link); > > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > } > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index fa365605ef..ce32be9ce3 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -832,7 +832,7 @@ new_device(int vid) > > VHOST_LOG(INFO, "Vhost device %d created\n", vid); > > - _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > > return 0; > } > @@ -889,7 +889,7 @@ destroy_device(int vid) > VHOST_LOG(INFO, "Vhost device %d destroyed\n", vid); > eth_vhost_uninstall_intr(eth_dev); > > - _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > + rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > static int > @@ -968,7 +968,7 @@ vring_state_changed(int vid, uint16_t vring, int enable) > VHOST_LOG(INFO, "vring%u is %s\n", > vring, enable ? "enabled" : "disabled"); > > - _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_QUEUE_STATE, NULL); > + rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_QUEUE_STATE, NULL); > > return 0; > } > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 4f2fa0d943..dac0f23052 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1489,9 +1489,9 @@ virtio_interrupt_handler(void *param) > > if (isr & VIRTIO_PCI_ISR_CONFIG) { > if (virtio_dev_link_update(dev, 0) == 0) > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > > if (vtpci_with_feature(hw, VIRTIO_NET_F_STATUS)) { > vtpci_read_dev_config(hw, > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index 815fba2f55..fa80e75a5b 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1417,9 +1417,9 @@ vmxnet3_process_events(struct rte_eth_dev *dev) > if (events & VMXNET3_ECR_LINK) { > PMD_DRV_LOG(DEBUG, "Process events: VMXNET3_ECR_LINK event"); > if (vmxnet3_dev_link_update(dev, 0) == 0) > - _rte_eth_dev_callback_process(dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > + rte_eth_dev_callback_process(dev, > + RTE_ETH_EVENT_INTR_LSC, > + NULL); > } > > /* Check if there is an error on xmit/recv queues */ > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index f8d63c7e17..066751f287 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -549,7 +549,7 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev) > rte_eth_dev_shared_data_prepare(); > > if (eth_dev->state != RTE_ETH_DEV_UNUSED) > - _rte_eth_dev_callback_process(eth_dev, > + rte_eth_dev_callback_process(eth_dev, > RTE_ETH_EVENT_DESTROY, NULL); > > rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); > @@ -1486,7 +1486,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > } > > void > -_rte_eth_dev_reset(struct rte_eth_dev *dev) > +rte_eth_dev_internal_reset(struct rte_eth_dev *dev) > { > if (dev->data->dev_started) { > RTE_ETHDEV_LOG(ERR, "Port %u must be stopped to allow reset\n", > @@ -4090,7 +4090,7 @@ rte_eth_dev_callback_unregister(uint16_t port_id, > } > > int > -_rte_eth_dev_callback_process(struct rte_eth_dev *dev, > +rte_eth_dev_callback_process(struct rte_eth_dev *dev, > enum rte_eth_event_type event, void *ret_param) > { > struct rte_eth_dev_callback *cb_lst; > @@ -4122,7 +4122,7 @@ rte_eth_dev_probing_finish(struct rte_eth_dev *dev) > if (dev == NULL) > return; > > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_NEW, NULL); > + rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_NEW, NULL); > > dev->state = RTE_ETH_DEV_ATTACHED; > } > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > index 5dfe9fdf1a..23cc1e0959 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -821,7 +821,7 @@ int rte_eth_dev_release_port(struct rte_eth_dev *eth_dev); > * void > */ > __rte_internal > -void _rte_eth_dev_reset(struct rte_eth_dev *dev); > +void rte_eth_dev_internal_reset(struct rte_eth_dev *dev); > > /** > * @internal Executes all the user application registered callbacks for > @@ -841,7 +841,7 @@ void _rte_eth_dev_reset(struct rte_eth_dev *dev); > * int > */ > __rte_internal > -int _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > +int rte_eth_dev_callback_process(struct rte_eth_dev *dev, > enum rte_eth_event_type event, void *ret_param); > > /** > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > index a85986a2a2..b6630dfabe 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -228,17 +228,17 @@ EXPERIMENTAL { > INTERNAL { > global: > > - _rte_eth_dev_callback_process; > - _rte_eth_dev_reset; > rte_eth_dev_allocate; > rte_eth_dev_allocated; > rte_eth_dev_attach_secondary; > + rte_eth_dev_callback_process; > rte_eth_dev_create; > rte_eth_dev_destroy; > rte_eth_dev_is_rx_hairpin_queue; > rte_eth_dev_is_tx_hairpin_queue; > rte_eth_dev_probing_finish; > rte_eth_dev_release_port; > + rte_eth_dev_internal_reset; > rte_eth_devargs_parse; > rte_eth_dma_zone_free; > rte_eth_dma_zone_reserve;