From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 258AFA04C8; Fri, 18 Sep 2020 11:01:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 357581D159; Fri, 18 Sep 2020 11:01:31 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9E4431C2E7 for ; Fri, 18 Sep 2020 11:01:29 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E221B20050; Fri, 18 Sep 2020 09:01:27 +0000 (UTC) Received: from us4-mdac16-10.at1.mdlocal (unknown [10.110.49.192]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id CDBDE600A7; Fri, 18 Sep 2020 09:01:27 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.48.234]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3893A220090; Fri, 18 Sep 2020 08:59:23 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DD3B5780069; Fri, 18 Sep 2020 08:59:22 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Sep 2020 09:59:17 +0100 To: Bruce Richardson CC: , References: <20200916164429.244847-1-bruce.richardson@intel.com> <20200918084136.GD1583@bricha3-MOBL.ger.corp.intel.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <2e1310d7-4e94-40f1-b5eb-ed827645be0b@solarflare.com> Date: Fri, 18 Sep 2020 11:59:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200918084136.GD1583@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25672.003 X-TM-AS-Result: No-23.130400-8.000000-10 X-TMASE-MatchedRID: hwsFDxVJcFnmLzc6AOD8DfHkpkyUphL9SExQHIFQcSsjRiu1AuxJTJsz uduG4YrxF7uMtOT7Yi/pYK2wc1TVdXMp9PZvqqsO9FQh3flUIh6teS443ymeUXt4azXv2W1ZK8L fiwWKYyP8uRjv83Q4NoiO16p825Ov80tbt9isD183aW/7bl6SZ8GcvcBoab2j4mJSqMd68jRWQQ fMvQmocxFjIqInsEvXt++Qx0U6098Bm1BZMJ5EIvw4wQxTs7Jm45mEQknxFDalCu6kKVgvEjMDQ zZFyyDniVJBkgB5slJQWiVMsVW1lXUP4kIIgasjB8FxO/BQHsKIWGvfT9ZpjJGJXR6jRFu40TV/ E4Hoomn5veT98pykgosBL5BIR4CRdBxnS9vVxvbG9W0D68BZzGsuPcPFgEg3srDwfHQQaK15a5j lCfYvEgLA9WbYzv8Qs94yZ+1wHKis2ZrnO9hFIn9EwA0OW8QlwJ63yQFkSDZUjspoiX02F4I/Ut NSjQv4C8FJm6bDnba0F0wsmVGCn4G/yDOSYBKbdDJl3p3e8vn+NefZIdSZXBw0HKhKjTfp5wxIy yhRieNmsbBXXbl2Z9NDXCGw7ssWtw+ir2TPiIpYcYljwpu4xAe5TGeGLGZPadstfHk0/23nRVN5 IqBTNqP/sGOIX0TwFayYyGVv6iQUlxTH728zzxjDRPpHuqhaIiTd2l7lf6E4j6y4YLH4VXpFpKk cmr8A/7Yc/sgfKhMp/r1N/8mFUgzyMxeMEX6wOX/V8P8ail1ZDL1gLmoa/PoA9r2LThYYKrauXd 3MZDUD/dHyT/Xh7Q== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--23.130400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25672.003 X-MDID: 1600419687-1HNonkyqpMB3 Subject: Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/20 11:41 AM, Bruce Richardson wrote: > On Thu, Sep 17, 2020 at 08:59:26PM +0300, Andrew Rybchenko wrote: >> On 9/16/20 7:44 PM, Bruce Richardson wrote: >>> As flagged previously on-list, there are a number of macros used to specify >>> what libs and drivers are enabled in the build which differ from the >>> equivalents used with make. This patchset is one possible approach to >>> fixing these, but as part of the investigation some issues were hit where >>> I'd like additional input to ensure we are ok with the approach taken in >>> this set. >>> >>> First, a problem statement: >>> >>> * While the make build defines generally followed a pattern, there were >>> many instances where the defines were unique. These can be seen in the >>> values defined in patch 4. >>> >>> * The NIC PMDs had two separate standards for the defines - some (the >>> physical device drivers) tended to have the _PMD at the end of the >>> macros, while the virtual drivers had it in the middle. Since the >>> majority seemed to go with it at the end, meson chose this option. >>> However, as can be seen from patch 4, a number now need special handling >>> for compatibility >>> >>> * This "_PMD" at the end made its way into other device classes, such as >>> crypto and event, but it appears that the standard for these classes from >>> make is in fact the opposite. Therefore we have had for the last 2+ years >>> conflicting macros for crypto, compression and event classes. >>> >>> * There is also the question of how important compatibility for these >>> macros is, especially since we have had numerous incompatibilities >>> without it being reported before. There is also the issue of the >>> deprecation process for macros, since these are not part of any ABI. >>> >>> What's done in this set: >>> >>> * Firstly, and missing dependencies on apps or examples had to be fixed, >>> where a dependency was missed because it was never needed due to the code >>> being stripped out because of a missing macro. >>> >>> * Secondly, since it is likely that use of the defines from make is more >>> widespread than those from meson, the defines for the crypto, compression >>> and event classes are changed to align with the make values. Just in case >>> though, temporary code is added to drivers/meson.build to redefine the >>> old meson values too, and a deprecation notice is added for these. The >>> hope is that we can then remove this temporary code in the next release, >>> leaving us with just one macro style for each driver class. >>> >>> * Thirdly, we add an additional set of backward compatibility macros for >>> the ~30 special-cases, where the meson macro template does not match that >>> defined for make. Again, this is intended to be temporary and a >>> deprecation notice is given for the macros in that file. >>> >>> * Finally, we replace all instances of the old macros in the codebase with >>> the newer versions. While the work done in the first four patches (steps >>> 1-3 above) should be ok to backport, this final patch is not suitable for >>> backporting. However, it is relatively simple to produce a new patch for >>> backporting which allow either old or new values to be used in macros. >>> >>> >>> Open issues/considerations after this patch: >>> >>> * We still have inconsistencies in our driver macro and naming templates. >>> This is just a nice-to-have, but if people are ok with generally having a >>> breakage in our macro defines, we could clean this up a lot further. >>> Notice how 'net', 'regex' and 'vdpa' have '_PMD' at the end, while most >>> others have it before the name. Notice also that many device classes have >>> the class at the end of the template, while bbdev has it in the middle. >>> $ git grep config_flag_fmt -- drivers/*/meson.build >>> drivers/baseband/meson.build:config_flag_fmt = 'RTE_LIBRTE_PMD_BBDEV_@0@' >>> drivers/bus/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_BUS' >>> drivers/common/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON' >>> drivers/compress/meson.build:config_flag_fmt = 'RTE_LIBRTE_PMD_@0@' >>> drivers/crypto/meson.build:config_flag_fmt = 'RTE_LIBRTE_PMD_@0@' >>> drivers/event/meson.build:config_flag_fmt = 'RTE_LIBRTE_PMD_@0@_EVENTDEV' >>> drivers/mempool/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL' >>> drivers/net/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' >>> drivers/raw/meson.build:config_flag_fmt = 'RTE_LIBRTE_PMD_@0@_RAWDEV' >>> drivers/regex/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' >>> drivers/vdpa/meson.build:config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' >> >> As a generic direction I would vote for standard names which are >> based on directory structure: >> - RTE_LIBRTE_ETHDEV >> - RTE_DRIVER_NET_SFC >> - RTE_DRIVER_COMMON_MLX5 >> - RTE_DRIVER_BUS_PCI >> > > Definite +1, and it would be good if we standardized the .so names like > that too. > > The open question is how much backward compatibility needs to be maintained > for macros (and also too for .so names)? With this patchset, I've aimed > very much to keep strict compatibility for now. I think it is really good. Technically it does not look hard to provide backward compatibility for macros, so I'd keep it up to but not including 21.11 (next LTS?). Same for .so names, if it is not a problem. If we approve the decision on naming, all new entities must follow it from the very beginning.