From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28D62431FE; Wed, 25 Oct 2023 23:30:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5EC34029A; Wed, 25 Oct 2023 23:30:31 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mails.dpdk.org (Postfix) with ESMTP id 279C74014F for ; Wed, 25 Oct 2023 23:30:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=damecuBrRqi7Cc2RA00Na/3a+3ocs0sMccpOKPPNwnRzsUJbr6w8YUWBGhitOPPxlFlPm9Pa0mTXgbfHxGc2GFktjgHBHZaYojrM0v2mZ+XkJTvk2jP1QIaXhQ4PD7Z/ED4J1k1ETF3toTXnJZzDy91XDwzl+QHd9Xq0YW+Lho7uYlifh20EOkT12A1w/I96ERRgaBXxnl+tLqrsiHn1iU9dGfMiGFW0mC7n2QZAxzOvW7HZyOM/u0gyX1x/N9eoZ0m5FZB9ruhHukWJsdmWUj5g3cNy5ClIWvmvRGCihJkF274vq1ZVtToO1ysZSNuZFZO55XRBod9ezDJEfZ2dSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g5QXSz19SKVa7Xyhzgv8y89tUd0DWqHEu/m1LywEfbc=; b=fu1S2vD3TglsEbI3fgFNXHat5pL+xf4blJNPNQYQLpgL7LHXQQrEUvbHT9PB8CMB1oPOImHlshNLkhyKy55CqLnFgo+BF5fjuzz9n7kKUPihPtJZ5/lmchu2OsIFRkTwojZgUKi4ws4NszyghqMbTufZZCpjWLKjvSSIkVfv3L5jF/tDV6M5B+WBZh+T4Sn+ZedLVwD3I3vAIyn50fy9PkVm84JdSRXdvcmKBpG34O6iAz2lm3YHwutK7R+AWK/33YvugZXJ7xRpWrldnkYMehbthMFitG+4TdYOLS9u4fYP6sR91cd3n4lrVxLoZRLrFJuIh7Fn4J/uNaRE9686LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g5QXSz19SKVa7Xyhzgv8y89tUd0DWqHEu/m1LywEfbc=; b=5XLKAJoIdC5Wus7o1cUPx94dHJWYqMdjwNgNR0EndFZq36R8/Ne+SV53wRRTKC14JsdOX76FVWWbFy1XRU1WIXEDmptu5IsDIHPN9Y7m373/mdZy8qMdO6CujL+cmxXw0DyhvjipPk/Q0WPzG53nOUDD/3ERn1VeOY1cSC1QOcw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB8967.namprd12.prod.outlook.com (2603:10b6:806:38b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Wed, 25 Oct 2023 21:30:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Wed, 25 Oct 2023 21:30:26 +0000 Message-ID: <2e1a714d-8b61-4fd4-acd9-02a83785f32f@amd.com> Date: Wed, 25 Oct 2023 22:30:21 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] net/ena: hal upgrade Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org, rbeider@amazon.com, atrwajee@amazon.com, amitbern@amazon.com References: <20231025133609.17931-1-shaibran@amazon.com> <20231025133609.17931-2-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231025133609.17931-2-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB8967:EE_ X-MS-Office365-Filtering-Correlation-Id: 482d9701-5a9a-495b-ed24-08dbd5a19a6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +61gmaUNtnAVmOqfZBtbT4EfxXk4LTDMBSY1gcSPFmi+GdkNnFOVFBGQ32HAT4qux8UbD8LkExH/rfbyBFaJPBYwouagO6hvED8bR4XcV3W5Ycatk2ZBg5XMQ5+Nsh4+0L6f62lLnyQr9KUFcwoCcYAiNPohK22Kv+j1IHh/RWvcYeTdgNVstdWSPhqsEZIq7LbVF/w6Hca+TOnYAAiLxeJbMf9uid0tkQuJq69fpw+Bd/Q6j3fRM1Ila01jm4PHMQzVNB7HELetl4E/L7FjAI6lHpHS9bpYW8JSvDYgW7DG15rcgUV9sRMCzoqCTW9EoGZdv2vLGyCYi4uaVwIvvf+4BqoVlhTP52xmvuaLBoGM1Z6adbexCNDQRsW+wY4SRToqYw8eqzwVGbzAp92yvCUA2BipiRuSv2uod/y6b0an4XQlMBx9kCBjNU4bZCuUl/dfVsZ5pXfYEsqGDNoP5T/STfZbC6NtodHAGoDMLVLWhTDaSUuQFLXpJcqpew27XtotOAmyLGxOP04q6XIAwyaqXyvtWSSFbuoZAhCROfFH0JiP7fWG+OZUlNjIvGe5Dqgk2NsCfTuKvQnUrHpUgXIE7P+B9Hwnyk0hMtypXqlq/LCIfEQRYt48FlbdaWTf64NqzS76KbEgzanqNJARmHsBhca/+nDc7cet+uHriQGnAvOSnUh692BEEOCGKn22 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(346002)(366004)(39860400002)(136003)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(2906002)(5660300002)(31686004)(41300700001)(44832011)(8676002)(8936002)(4326008)(2616005)(38100700002)(83380400001)(66556008)(316002)(6916009)(66476007)(66946007)(36756003)(6666004)(53546011)(6506007)(26005)(86362001)(31696002)(6512007)(6486002)(478600001)(46800400005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWdLVTB4UTF2MkpMdEdyeUFHVVk1cHJWbGZPcWZCZHlrcHZjRTJPWXFzU1R3?= =?utf-8?B?NW9qcnd2QWE3d3l2bVdJVXREVEJhSWs0NzJPQ1N1SkRlNFdzaHZFWFNrZjdZ?= =?utf-8?B?dXhBb1pMREo2TFZEcjVaUXhPd0wwdWRsM3REbS9zbEVGMjhSRTl5VUF2NTJR?= =?utf-8?B?NXNJRG1ia2E5aTZUVGdiK2dicHc1NW5XcEFpRWNsbUNvelB0VUMwRlB5bkVT?= =?utf-8?B?K1lPV2VvWWE4R0xQY0wvY0IrZkdKclpHelZ3WVNjNFVoaGZOODJDM0hYeisr?= =?utf-8?B?STAyM0NyOE1tNHZXWkM1MDd4RXdWeXhmLy8zYjZVWHlmcEVKK2RESmhmZVl1?= =?utf-8?B?RDJ1bnRWUDZoRE9YMEtxcVZaV1hRa0k0bW56V1NWZDhsMnB5ZnlHQUNPODA0?= =?utf-8?B?dk1GUjYzU0VaVlduT3JDV29ESk5zNkFrQWF4eGg5YWhJSUgxcWQvQ29heURv?= =?utf-8?B?Q2pKSVpVQ09VVGQ0KzVuRHBNQlZ5bGx2N0JCWU0xNWZhNWNDejBSclovaXUw?= =?utf-8?B?RUxGZXJTTDQyMjBhcTd2emkyVlZYaGg0WVZqemlSN0xzZVFZbkRBa1ZuN1hi?= =?utf-8?B?QktTYVU3bmZjQk9FZUVyek1vbjhFQXJ3bkcwbDlYZ0FJSDlYNHlielhSaUJT?= =?utf-8?B?dE9CMkhsTFhTc0VuQzJ6TjBmQXJPM2NhSEhFN09mZ2dvSFIyOTV1WG5sM1hJ?= =?utf-8?B?T1plMkh4QSt3N3JhL3UxSy95clY4NlBuT2FseWVsTE1SZlpZSHAwN2Y3NnB4?= =?utf-8?B?QXJuV1VKbXJ6djM4WFU5MHdDeGpQYk4rVVRYVWlHSll4QVlBL04zNzd5NklN?= =?utf-8?B?MUwrYk5LaHpFQzRRUllnMTJnQkVZQXF2aDFlZ2JYcDBwTFl6Nk0wY0FsOGJQ?= =?utf-8?B?aWpnREZjSEhzamJYWGMyKzFYZzkvUENYbTBYVjRtYW1EMnlqS29HV0NDbndE?= =?utf-8?B?WDN3N0xtcHNiRk9pZzVyVXp2bWd1L0RPUnNlTWthaWdSNDYzL1RoTVdtbENn?= =?utf-8?B?YU0xUTZtV3Z1UnJYdTlabzhON3hTaU9zRGt0My9CZmM4TXY5M21yczZLZGVH?= =?utf-8?B?Q01xMWsrcmZuWkRuc3RKZnpxaHB0UG5iaUJvSXJVdExtbVo4azRvSGVxc3M4?= =?utf-8?B?TzhzdWU2WlkxS0JVMGFwc1lEU3VlSElibmVVaU93eXVpbXlRM3JTaEhyWWZ1?= =?utf-8?B?ZkR2TEtmUXBNWU5kenV1a3JPa3dXSEZLSFFtZkJxcjdlQktMNHFacm9ENHZl?= =?utf-8?B?LytkcDBxQUg0Z3lST2ZqTUg0REdLeExMVittUFROK1ExSFFHWC9WZWEyVlhm?= =?utf-8?B?UVc0SEZUTlhqYkI1aWZERlcxSnF6L1hsL0lUNnFiQzYzYVBqYWVnS1VSTldR?= =?utf-8?B?OGxmbFdhOTBhSGpHRFU0bEg5a0FaNVUydG12Y0lTZk0zVzluQktVZ0trYitG?= =?utf-8?B?UUFEYlA4bmNhWk5ub3huaEhaeGJ3Y2pCemM2Q0ZrS2VPbGFUcjdqdlF6S3pR?= =?utf-8?B?ZWRFWWlSVEc2UG9RUGl2REk5Y2RVVnhtR1N6ZmlZUXQrSmFrb0FXdW90b25r?= =?utf-8?B?QlQ3WWpkaWJQUDQ0eG9LVGpPZWlIUHNtcFlLSHJGRUVpY2hVa2dSUVA0aHRx?= =?utf-8?B?S1lPY0JObTJUeHk1QzMwREdBSFd6SnBQallZS0pNeTdrK2VZUytVem45c3Rm?= =?utf-8?B?MXVieXFSdkdna0xzUDc0MGU4MlphOVgwcHd0SEgvdkFhM2M2ZlZPV2VEa1I5?= =?utf-8?B?dm5LOHJrS2VkdTdwRml4ZUZPUG1IcE5BSjhwK1gwZ1hxY3k2ZVhwenBueU9Q?= =?utf-8?B?Y3JWYlZFU0loQUNONE9TL2NVVU1jYmNjamFXRWJud1ZUekFydExISXdHeFQr?= =?utf-8?B?aGNBSmJrOUh4cy84eFRJUE9yMTFBUzZQcEFWbGZJMWZKUmZtd3MrS0RuN09w?= =?utf-8?B?SWNQeVZ6T2ZxSEtLb2VwaU5OcjdmLzRSYlNMeDNaWWFLS1dtc2E4NkhueVdU?= =?utf-8?B?VHphUjhRdlN5Zlpld2xwQTBEZ3lYM2FxZkVrZlVYYUdEYWl0WUZNKzdiWG5U?= =?utf-8?B?WWxkZTEybTczZCtmVUpCYnBOaStYQmRDSWRoeFZaZWxpTU8ra1FWSXF1Z3hS?= =?utf-8?Q?eXao=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 482d9701-5a9a-495b-ed24-08dbd5a19a6f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 21:30:26.4943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /2q6ldvPeQBshjmDNsTK/1cy9T6uO/p6UyGmd4Sg3+t5hPqWRnqpvKHBaPBdP/++ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8967 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/25/2023 2:36 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > ENA maintains a HAL that is shared by all supported host drivers. > Main features introduced to the HAL: > [1] Reworked the mechanism that queries the performance metrics > from the device. > [2] Added support for a new metric that allows monitoring the > available tracked connections. > [3] Added support for a new statistic that counts RX drops due > to insufficient buffers provided by host. > [4] Added support for Scalable Reliable Datagram (SRD) metrics > from ENA Express. > [5] Added support for querying the LLQ entry size recommendation > from the device. > [6] Added support for PTP hardware clock (PHC) feature that > provides enhanced accuracy (Not supported by the driver). > [7] Added support for new reset reasons for a suspected CPU > starvation and for completion descriptor inconsistency. > [8] Aligned all return error code to a common notation. > [9] Removed an obsolete queue tail pointer update API. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > --- > doc/guides/rel_notes/release_23_11.rst | 4 + > drivers/net/ena/base/ena_com.c | 499 +++++++++++++++--- > drivers/net/ena/base/ena_com.h | 197 ++++++- > .../net/ena/base/ena_defs/ena_admin_defs.h | 198 ++++++- > .../net/ena/base/ena_defs/ena_eth_io_defs.h | 18 +- > drivers/net/ena/base/ena_defs/ena_gen_info.h | 4 +- > drivers/net/ena/base/ena_defs/ena_regs_defs.h | 12 + > drivers/net/ena/base/ena_eth_com.c | 45 +- > drivers/net/ena/base/ena_eth_com.h | 30 +- > drivers/net/ena/base/ena_plat.h | 8 +- > drivers/net/ena/base/ena_plat_dpdk.h | 49 +- > drivers/net/ena/ena_ethdev.c | 16 +- > 12 files changed, 915 insertions(+), 165 deletions(-) > > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst > index 0a6fc76a9d..e3b0ba58c9 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -144,6 +144,10 @@ New Features > > * Added support for Network Service Header (NSH) flow matching. > > +* **Updated Amazon Elastic Network Adapter ena net driver.** > + > What do you think clarify as: Updated Amazon ena (Elastic Network Adapter) net driver. > + * Upgraded ENA HAL to latest version. > + > Updates should be ordered in vendor in the driver group, so can you please sort it based on 'Amazon'? With current release notes, it makes before Intel driver updates. > * **Updated Solarflare net driver.** > > * Added support for transfer flow action ``INDIRECT`` with subtype ``VXLAN_ENCAP``. > diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c > index 5ca36ab6d9..880d047956 100644 > --- a/drivers/net/ena/base/ena_com.c > +++ b/drivers/net/ena/base/ena_com.c > @@ -38,6 +38,12 @@ > > #define ENA_MAX_ADMIN_POLL_US 5000 > > +/* PHC definitions */ > +#define ENA_PHC_DEFAULT_EXPIRE_TIMEOUT_USEC 20 > +#define ENA_PHC_DEFAULT_BLOCK_TIMEOUT_USEC 1000 > +#define ENA_PHC_TIMESTAMP_ERROR 0xFFFFFFFFFFFFFFFF > +#define ENA_PHC_REQ_ID_OFFSET 0xDEAD > + > /*****************************************************************************/ > /*****************************************************************************/ > /*****************************************************************************/ > @@ -70,7 +76,7 @@ static int ena_com_mem_addr_set(struct ena_com_dev *ena_dev, > dma_addr_t addr) > { > if ((addr & GENMASK_ULL(ena_dev->dma_addr_bits - 1, 0)) != addr) { > - ena_trc_err(ena_dev, "DMA address has more bits than the device supports\n"); > + ena_trc_err(ena_dev, "DMA address has more bits that the device supports\n"); > Original wording looks better to me, 'than' instead of 'that', but we can get another opinion from a native English speaker. <...> > diff --git a/drivers/net/ena/base/ena_plat.h b/drivers/net/ena/base/ena_plat.h > index 2583823080..a3649e0cb6 100644 > --- a/drivers/net/ena/base/ena_plat.h > +++ b/drivers/net/ena/base/ena_plat.h > @@ -14,14 +14,16 @@ > #else > #include > #endif > +#elif defined(_WIN32) > +#include > #elif defined(__FreeBSD__) > -#if defined(_KERNEL) > +#if defined(__KERNEL__) > #include > #else > #include > #endif > -#elif defined(_WIN32) > -#include > +#elif defined(__APPLE__) > +#include > #else > #error "Invalid platform" > #endif > As far as I can see only ena_plat_dpdk.h exists, other ena_plat_*.h files not exists at all in dpdk driver, would it be possible to strip those lines for the dpdk version of the ena_plat.h to not confuse about the support. If this creates additional maintanence burden, OK to continue as it is. <...> > @@ -107,6 +110,7 @@ extern int ena_logtype_com; > #define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8) > #define U64_C(x) x ## ULL > #define BIT(nr) (1UL << (nr)) > +#define BIT64(nr) BIT(nr) > Can use existing RTE_BIT64 / RTE_BIT32 macros <...> > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 7345e480f8..b764442dbb 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1171,7 +1171,6 @@ static int ena_start(struct rte_eth_dev *dev) > struct ena_adapter *adapter = dev->data->dev_private; > uint64_t ticks; > int rc = 0; > - uint16_t i; > > /* Cannot allocate memory in secondary process */ > if (rte_eal_process_type() != RTE_PROC_PRIMARY) { > @@ -1209,11 +1208,6 @@ static int ena_start(struct rte_eth_dev *dev) > ++adapter->dev_stats.dev_start; > adapter->state = ENA_ADAPTER_STATE_RUNNING; > > - for (i = 0; i < dev->data->nb_rx_queues; i++) > - dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; > - for (i = 0; i < dev->data->nb_tx_queues; i++) > - dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; > - > return 0; > > err_rss_init: > @@ -1229,7 +1223,6 @@ static int ena_stop(struct rte_eth_dev *dev) > struct ena_com_dev *ena_dev = &adapter->ena_dev; > struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); > struct rte_intr_handle *intr_handle = pci_dev->intr_handle; > - uint16_t i; > int rc; > > /* Cannot free memory in secondary process */ > @@ -1261,11 +1254,6 @@ static int ena_stop(struct rte_eth_dev *dev) > adapter->state = ENA_ADAPTER_STATE_STOPPED; > dev->data->dev_started = 0; > > - for (i = 0; i < dev->data->nb_rx_queues; i++) > - dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; > - for (i = 0; i < dev->data->nb_tx_queues; i++) > - dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; > - > return 0; > } > Above queue state related changes are coming from other patch in this release, I guess removing them is a mistake, can you please double check?