From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40DD5A054B; Thu, 16 Jul 2020 15:41:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 661931D584; Thu, 16 Jul 2020 15:41:46 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 792E81D568 for ; Thu, 16 Jul 2020 15:41:44 +0200 (CEST) IronPort-SDR: c5xlW70+bTdzxPv816ZebgLWLTbzF9WMOuHxWtYCmqDixNBeQTRtIdQgXf52uJZvdtwy6YusIU eVoKupaIKdSA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="146888190" X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="146888190" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 06:41:43 -0700 IronPort-SDR: X5NthC9E3URW4pFq3tSuNMD6+ln+3Ryc0E1BvZaVuatNR7mE43hymr3qs/5KfHkVNqWYpX2BDS 5XdTp7FmgVAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="430497117" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.27]) ([10.213.226.27]) by orsmga004.jf.intel.com with ESMTP; 16 Jul 2020 06:41:42 -0700 To: Stephen Hemminger Cc: dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> <20200715132910.5aaa11ed@hermes.lan> From: "Burakov, Anatoly" Message-ID: <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> Date: Thu, 16 Jul 2020 14:41:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200715132910.5aaa11ed@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > On Wed, 15 Jul 2020 14:28:17 +0100 > "Burakov, Anatoly" wrote: > >>> -#define SKIP_MASTER SKIP_INITIAL >>> -#define CALL_MASTER CALL_INITIAL >>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL >>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL >> >> Presumably this is a generic header, should we introduce GCC-specific >> things there? > > It works with Clang as well. Likely ICC but don't have that. > What about MSVC? -- Thanks, Anatoly