From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0057.outbound.protection.outlook.com [104.47.38.57]) by dpdk.org (Postfix) with ESMTP id C3DB72C17; Thu, 8 Jun 2017 13:22:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lURBOaE7KDvhCcDbJbWxugz3YSfWGvyAr1VgK3pxbBw=; b=ZvRz2wjLiaQ6FWL7SRdWHCQxgJyiHz9z8zf0g+W9aGCzroc6PWpZc0r5KJz6TWTR6FxLPxkekORARsWr3jRYhUh9IT78VMPqzCNwrqQ4Qk+QcGAp9sf8ZX+AM8wFsJLCONhmOPdDh+bRyUHLrT82Z7/7DCFcvqHhRsMiLbqOiHk= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.89.1.6] (14.140.2.178) by DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.10; Thu, 8 Jun 2017 11:22:05 +0000 To: Olivier Matz References: <20170511103044.14298-1-santosh.shukla@caviumnetworks.com> <20170608120816.48c25965@platinum> Cc: dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com, stable@dpdk.org From: santosh Message-ID: <2e41c851-f328-5101-43d2-211290f852d3@caviumnetworks.com> Date: Thu, 8 Jun 2017 16:51:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170608120816.48c25965@platinum> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MA1PR01CA0112.INDPRD01.PROD.OUTLOOK.COM (10.174.56.156) To DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR07MB3098: X-MS-Office365-Filtering-Correlation-Id: 5d52c651-aef6-4a82-d6f3-08d4ae60997e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM5PR07MB3098; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 3:PeM7zGa76wDDIwSQa/WNT1S9Auu8iSI6WBIOldjGzjg38Zjp2Qz5UQJqY5DFVel5fxfiZvSkvPqV4gswFSV/a2mPN2iWbvhMF/0Af/I3JrgmzbcF2ziPW1yNa5aweTRZBdEasSdn7O9XpuEwKaPzdfVor41crL1FxmgQhksPFhePoL7qp8eb1UefPAryFgWaABkMm436FJ9F2bInG6UuPzJPAVCxhO1Zd5C1hwT7hFzk2m4t+55ZJozmbVm0LzAI9H70xqhDPVTKNlfUt4kuHSIA7yCwqinML95DxmKQ47zuCH4Z/As1rg7lgo4gup92nhCox2YjJkxOWbAYjnlsKA==; 25:I3JiTaPfWNtX9d6WBhyt8drQXknBcNuYs2h/iCKKzc7Z2+Ma5NwI7eoQE1BPl/XKIleoMivAYL3ko3PmAJ8HMpDMlYgPoeNkx+ZHoPYgGla9Da7+E7mEjfYGTja0CYxW8DKhm/8/WEBLOSsZOK7GuuBL4WYkjmANoKw5EggLM2sMi7sxRRqhKbqowldmfJeV7cknnU66LLRNjzz7UeZU9Z7f7KslKyQibqNL4F16py2lyu4hD0Vkiot9PQ+7YvC0Nr1p5SIgRKVEs+qVQEGgaHzJlaTH39heT+PMUGuCC2BuymtvE9lXZmEtJXy0I1DeQKrarvhu4H6EWi1kc6DsbeOlsTp7g1nf2fBHfOCZM6Rdcmq9EoUnq/x37rZE9snFiGyk3MRrsNULa7GnmYruS+Rnbk80EUIioqJLsLqXb0Ob5Ejk5GFjCWyG4a8QYZlreLStkRG4QI9OWG3J0o6+p4T9FRBSEG8FoHnIAdWB/x0= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 31:cVIPIwOTUbUrjW4OU7ENGZDiSeTrLpYixFn7nDVIXeNjG8kOe4jQAsMuwWbqi9fjIHlE9vuzy+xMv85LxVGFIGTIX51jMb8wI1krKR5eEuTvFEV+dUzAF2rtJ820Nbtmu9gxL2/n4INnhsYdFWQCzbRAtfFA2f2vBJM7zBNc6lW2Xf3w1yPvreQN3/IJRpbb5rPVsR5VVSRf8LEqOUkJoFp1+LNBhRc5nX9hk8IAZoJzf8XViZVaCvNP+HEJBpU9; 20:Vy5rRcS//wu/qaUWVRez2tARPanaw0fgr/6Mnzi0lHWOuf9FAh+LBjW+ifSa/UCA8fF8rKWPQ8lrsN6p7JrWnizei2PQs6eD/Esp1OAHKiy010bt7Ntx9gUmg73IjYIj//0jsKOqL4Y0nbmm3vurwaSvHsV2V0e1x9wQB6zJu8ppgxipKuBIaTqPYljcOLxt5t1n0aoIRJbs/8Fg5d4pQHPsTCL0UeL25wslMU0gHaf5gfKQHZKSYG9KhnAeiu6jPaC8L70ki1sqoKvVQ9EVfM6Gl85Vp/mvslioqwCzVNgJD4dStaZhW8OdBSHsd4zKusHAuNFoLY56pUkP++u7DrUwWgTyvoHuu2cJh6DD946R3gKlDZ07UpBa+TvyHxrQebnItan9cC4/ba2hV6gsfA5QGYCuw+e9Bl/cMuD9vgDi5b7bTHW9Q9EW/s6qEHqKMGV/olF+EHK4RV7AEyf8zEGFiiirUVJR/uIq4v9kSbcYF+1L4dAUF98uIi4nYteFJSzFLjKS8aDaw62SL/YsvLAFNPeleHQLeAuQ7As1suHIBWszOVf1eeTO+iJsK4H5v8U5+NyDSB6yc29hTJkljvQ88rbjI81qhoVR7sF5as0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3098; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3098; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR07MB3098; 4:jtepOXFlmIOv3rO/xtFASjbkIBFRNpqi5Rx5zW?= =?Windows-1252?Q?E+eWO83ZsU2ygy1x6pdoiIX55ayViDPgxg9q3EYon2JNJQU4pm6b8s9k?= =?Windows-1252?Q?xHvT19I2k2Z86FtWMDx6kzJcH45HkWZdJbQ+f4X0ta++d61ummUIbJBC?= =?Windows-1252?Q?asml9uj9KSbpbRdWI+wiUfitjKJdmfkJJs45Kb/QNL17+B5P7lm9CDBm?= =?Windows-1252?Q?PbG2bGysZfNaObiyBQDViqiD1EX0LjSVHmyGGGocNMdITB/Ap7KNoG2x?= =?Windows-1252?Q?lsRC4HKAilkfrE+6+uizRiP0eCTyEDNbFxvhY1kZj3LJYnYMYra2hTP2?= =?Windows-1252?Q?H2/UNxX1gEOCVu0yUTCjIT3EHrbHU0A2wGEuiGc90kt8R6VemeKzXd63?= =?Windows-1252?Q?LmKW6DCxc1waRnPUOQgNnhSBjDbhMGXsFgaG+BvEN3Q0Nl4xwMuceNZf?= =?Windows-1252?Q?mg8A7sWdtLT+RL08dn3aS/gYmDw53HtRS9CGP7PJtkPjDB5/Hb3NlTti?= =?Windows-1252?Q?m/I1rOghPGwquudPDn2jvkcwQtox6o/HYCmv0w6GBaSzBYQSNqb7aIHu?= =?Windows-1252?Q?yiprZKM4v+lnfqPGWKueD9SMFBqL+L+pJgwehDm+vt3LzqgamTPnVLQR?= =?Windows-1252?Q?oJDPfZnIrRSOPUFcAOqYNFaGVCegYdukz7k4gAz6aaFZcIH46ivjO5Nh?= =?Windows-1252?Q?V1Ez64gE7NOLXUGctBq+9HR4Lgry0hITMmtgdiGFkg7em0dD/dNAzO7N?= =?Windows-1252?Q?gZsaLE1oFOpV5ZB2kK91tpQHubElqVrf6XuaAD1n51PzS4srsYoeWuQa?= =?Windows-1252?Q?OLi1zhwxxvbgBoO9vhla/m4tL4RBXQU564QRLLsvIw48//QwhdlJ42Jb?= =?Windows-1252?Q?RSu+4dtByXzKpgi647JZ9bd1swfcPp1IRSVx3eLjNnwxQz+MVCj4YW4O?= =?Windows-1252?Q?GvN9QAJW+LfRLl/UUEfemYD9dGRVkh9Ur1UPus/BNRsc4zLtRztvaRWf?= =?Windows-1252?Q?aUaF9bGyXhogu9GoLAd+gcpeJe8i8J2MdwxQvZcAx8y5IqhTEybt7CGN?= =?Windows-1252?Q?UI12I0VFnTfG9s0K9Em3Ctpxc8ZOuLd11/TfROE4gaTxvJGc65g+KyaY?= =?Windows-1252?Q?VTuX8OTlTLrBUVE5lOKfix2Mwi9YuLxIYdRk2FlgoEmHMpt2arz6qsaN?= =?Windows-1252?Q?37KMOPwCcnBLmFQQrEjLxugUNiZ9I=3D?= X-Forefront-PRVS: 0332AACBC3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39850400002)(39400400002)(39410400002)(39450400003)(377454003)(76104003)(24454002)(2950100002)(65826007)(6666003)(53936002)(81166006)(230700001)(36756003)(23746002)(6246003)(47776003)(5009440100003)(65806001)(66066001)(65956001)(5660300001)(8676002)(229853002)(64126003)(31686004)(7736002)(305945005)(42186005)(86152003)(2906002)(478600001)(4326008)(31696002)(8656002)(25786009)(72206003)(110136004)(6486002)(38730400002)(50986999)(33646002)(90366009)(42882006)(77096006)(3846002)(345774005)(54356999)(6916009)(76176999)(189998001)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3098; H:[10.89.1.6]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR07MB3098; 23:mJA+SPJAJ/SOcsF6Gx/fXAGA+0Aj1xXhjnp8l?= =?Windows-1252?Q?cZMPWLPJQQqN99QtQZRqZRH02z39S+6TSfCnKpab7i5kojVodTRYn3U9?= =?Windows-1252?Q?AfKYjo0dwiwcAlvLPmsKDLwyY7xKeDjqc/rHNkRURDKlaly/KN/zWVRn?= =?Windows-1252?Q?839lxZ/Lmfp3UvZqWCtVj+A7Wdl7C6m+muoLNBbjmot0tVza7HPjO6cc?= =?Windows-1252?Q?fVkdNumtDwzku2qicb+AmPZa8TRsiSRPvO/xs+0lo5keTf7J4e/Ie1Ez?= =?Windows-1252?Q?9u5AOV87PCD9mrVDi8He4dNbMwRc1MmvbWL4msVMX+EJS5CXG3xpNvkL?= =?Windows-1252?Q?vx/7RWL3Lyf2Jf0zKB87fzJZvRqep8b1blkf7jIDJQtixJVcBEnj1Qpt?= =?Windows-1252?Q?wT/TJB/BR0K/7w9/hiYZPTWtJnFqNFo6JCIF+zj8cRdjwgK1KXbpREo6?= =?Windows-1252?Q?NKTVcIwz3mVGj2Y1aDOfJOs4tGPXihA3QoirFxJpEnP6YkKezwmqcN71?= =?Windows-1252?Q?ikN6GqfwLG7BXmaJkmFugJAp5N4Uxs8ZOoMWjhlpNZBisW905/FjO6Bl?= =?Windows-1252?Q?oJ0BFEJTM1FvMaPzBefzsR/Pv0SuMBnMpOqMqhtfZBwxL4LDrq9aBLX/?= =?Windows-1252?Q?3mZLcw8Q8sewfddL7jUgc4pVGunLYq49yPzfZfA1nl6hSEjsGQR7B5e1?= =?Windows-1252?Q?VjcpbDk5K8UQmc4EDW25zpojw9mXBfPtCl9sg2DBsdBqgwbcIN56MQ4h?= =?Windows-1252?Q?krhlO10V9G9Z4VXxaURlIT1iZeoxbVRmftbdFVhLSBtYbjmGb/5kOc0I?= =?Windows-1252?Q?kz1CMh3VEzpjN18C8zcONq7KxyJthnF/4rK1487cmf/jtLIhIdo5Fg5m?= =?Windows-1252?Q?U3KnF1fzwugJ3KJtyn2oXzTO1Jxzgj1o8C7nE8QXHY7gC2jHaFcU8Xl0?= =?Windows-1252?Q?DcE9spX/pjOkzCzgH+TNoQGw2rH1taqi8ktjDVMw2b0kZw7CaXfhcS2j?= =?Windows-1252?Q?iveF29Og4XxJMcwx85o6sPPYO1esuLORifBH5y6IoB3ytUZXmit6EOei?= =?Windows-1252?Q?2BsMBkn1y7MOT40lQNnvlulRz2zk005bupOX9GJmoa8GC6zZoUVDbndD?= =?Windows-1252?Q?60pwXphn4I0zTpTtTAoh9AhTddClK3AJDOm1Th8r2VfSJN7VNuC+1SlL?= =?Windows-1252?Q?b++juKY/vyFYzZ9QrXHFT2GVjjpP6KVKntxVc2nqVhhFxJKLkiVeroXJ?= =?Windows-1252?Q?2q0aUIqk7cZDRCSc6/4Z1Nfrb4BwoRXrLpeSQthz1h1zOg94mq/4wXRi?= =?Windows-1252?Q?FDlyL6NZosLxCzS60JUPPu68zb3lJcbbf16UIS0Cu7hRvnFb4BIuhSmv?= =?Windows-1252?Q?1kpNYu7AVmoaO9BQZDogg7VEvJhcCAGdFn4GDJaNsHzcIOK5PhdWB0Xa?= =?Windows-1252?Q?ShVnkyq8kh7PCX4fJbBoq0RSQuzd+SPThoEZuqBcAkrqo04KZc8XqLj9?= =?Windows-1252?Q?/M6XkM=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 6:FOs1z02p2Vx2PM2TYV+aVZOvlrjHv9IKCSZV7UxrI+oJ7lkcdXsvGQ39jkzDJoKI6eWF6E8RFzmQ0DCJe/+p30dDsdbJsqqvEBYyK2TNWPZP3dhDOFPZrFaKEgS2nl+gdkfTw+OGizGzifmy9TGdxV3Cxw8U5b2Ao1Km8AS7pHBlpo87KeclUez4TAtbD5q5OBv850PHd+TkYk4G4J+JDB5k2Xu4FGwOGfzW1FUgE6UmzkMgdyooHIprMod6KaQWcpYP+L1muZz/b1yQb4YMjbTJ4coNPSyaV3Ih37HJYAJOp5dtQhEJO5cSddMJjGEEre52Q7jExNDi6pQAxOXapOZ8Y274jKHPJFy60HxkukDx+UhOvicbgDHDm/r/79GysYglBOK3uhkR+szBK7NNaxx3zyiAJLAmpwBXcDNBJ5zP2Y+Pc/+io7v0WpYN//MUl+SxKxEuZ0bA1Ny3RL/Xf9Z6WMgIDidK0K1cSct/pMbSdZ9edN0lkfeaEUD/ZhmGHzqzj+JO2mDgOMQew9KIGQ== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 5:kZGh/tqDman5zR918K+ZBuw5tyYgVAt7EsdMq8eHxxYOHei88z+bHW16tN4C+wR4p1eLebr/chwSWNItykvoCUqo4mzhPn1WsdmU4+rKmP/nCUFhJHW+KalIV/QvzcZbeNtALa8BtiIDypkZ/IQHBM2KxhMiuOcz6+mVpevbllUWOuySPVQ3aKvNpUpB97sKvqFzpMW7d5urymkG63chkGwjp3FDZdB0jn7kMkd2OvgVa2c6gtRrX0z7LjZTALE30DRP0vsY7qXCdEveoGCIoAVyEBaQJUUQMRRBnX44KRJtTUfRlr/niz3U6D1FqgRsgSdFAyBBbRqQ/BWt5i5rn4qeOy9EdXHGAGXNehp5BA47bhhzib+nKpIfMmfQC8Ya9YLabCfYd95Srh5uVe6niOk172gIPUXGNo8UIfGBGwDg/NgKhi7GJjRanl1fOlyY345ZbF1hFb/0x+GMGsD2L7ySP8R4hLzarMivqHjNPmNmxFQonDYrexUk5lYo0PKI; 24:s/3UzHWNmOzZcvaye9XYswEl1DPFEYSphqqfxXGyE21jpExKkim6HY3I7SGIwJt0aoSG/ZWHjOJmKqBAuIx1owWdwldpd57XeOAW/1w8UKE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 7:ZOvx7dhAi7w6zPwIgIyA85wbbBIfIcYgHhz50X4UYkTeCP53HLD0pHnlUawYGZ1YVrJnRAsbcNaIfRREhWcDiB6NDCmosAQxwdaUWnsvr2bRAz10GyRW+Uvvq51hJx3CeCu9/9vad6pxbpNo0c8Y5RPJnPhxE0zqBEY29dQf3RhhCMR5gdJbDKMxcd555clnREq7pQ1A7H6SWcKk+E0/rk/72/g6b6hKRML6Eg2oIozzLKN/mxVP1mAWEwqKttKcTQvI2r2nWGCShlSALQBXkotU5H17rp/BYxAKIVgS7XuoZGmya8mzPiHOmHijnrK+vo9cwcT9k13FIYrDH2DyEA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2017 11:22:05.5464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3098 Subject: Re: [dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 11:22:09 -0000 Hi Olivier, On Thursday 08 June 2017 03:38 PM, Olivier Matz wrote: > Hi Santosh, > > On Thu, 11 May 2017 16:00:43 +0530, Santosh Shukla wrote: >> Cc: stable@dpdk.org >> Signed-off-by: Santosh Shukla >> --- >> test/test/test_mbuf.c | 100 +++++++++++++++++++++++++------------------------- >> 1 file changed, 51 insertions(+), 49 deletions(-) >> > Thank you for doing this fix. > > My only comment is that commit introduces a memory leak, which > is fixed by your second patch. > > The behavior before your patch was to allocate the pools once > but never free them. > The behavior after this patch is to allocate the pools each time > the test is started and never free them. > > After your 2 patches, the behavior is good. > So I suggest to merge them into one commit. What do you think? > Yes. Will send v2. Thanks. > Olivier >