From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9B70A0C4B; Mon, 8 Nov 2021 10:02:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D40440DF7; Mon, 8 Nov 2021 10:02:45 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D84FF40040 for ; Mon, 8 Nov 2021 10:02:43 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10161"; a="293021769" X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="293021769" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 01:02:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="469540754" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 08 Nov 2021 01:02:42 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 01:02:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 01:02:41 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 8 Nov 2021 01:02:41 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 8 Nov 2021 01:02:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fatJwVgmiHo2z4zUBbF7oeMkPImek6TJLQA/4IIYGSjdjgdOZnNvkTKRIEW4yYsJths9ipX/K60pXuu0PkVpG9hTN4Sbr60S80q6Gy4gr3ewVRrAJWdXaY6sHnpo2Ve8n6dlrFtjiNzW6/TVB0Zu+SQMIn8/xtrOY85zLdzAyPC6geAMYmsfj70lWW1NUnSCPKOorWBo8OQBHu7vTsH08nBqNyRMcF1G2ob/Mt8cI/IeUYHnNMavd0eK44mvDk5OJkFoH4TndWWvmcDeT9edlynJ2hFFI+96MYMBcflq4THHGOOPyucmiKnQC73rZQSGFWpinEyQt52qjLxqMOBkGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gdqz15TwJmSlyM2SUVfAF1qCdwE54o/7PROzY0Ga0DU=; b=L2KoE4kBDSWnUhNK9U2Tf56/lmdXveja5Da3Ohd+2XKeqm1iXmcQI0YgwsidtUWCMyxOw2ngs9J4nQ2en5JigryXLHrnuWIo3zyU4SeTwO6l1JpW19alw+9xfj+fHPGCBGx7yBBvJsTmbt2SXz1NTpt8kXHiiMQlgw1VgYXY44rzvBps4gD0j1Wx4o4CVQuDRoCGt1hooDBLEy1tZFsHI9Zg53F7xeC8bBoeisCMQV64uz3slzz1l0yjJzItuI0cnRPa8zWKXxNXjCV4r0G/R7R6cLdh5eu0P6c0hruUpGlHcBDCYyMlTMXFQVmbHeqhtMDjxX36WSMLYEBurrHSmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdqz15TwJmSlyM2SUVfAF1qCdwE54o/7PROzY0Ga0DU=; b=A5X+vwDPag9gqrXXZPYQrh2dpwdeo42DpT+czSuGc0cHA2gcDoxXOND7zL4vbYRKzl1lyPni5gu/CLa0VhhfEDaG5vtQcEXUC0TiGNP7NNdPn/Y0KpcieLdrSEfjOaCSHstfUpnFog+M15pi8EhQQ3B0OwBWfYwkj+FhjVLeEGs= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Mon, 8 Nov 2021 09:02:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 09:02:36 +0000 Message-ID: <2e45c683-4dd9-6ec9-0b1f-1baba3de3c26@intel.com> Date: Mon, 8 Nov 2021 09:02:29 +0000 Content-Language: en-US To: "Wang, Jie1X" , "dev@dpdk.org" CC: "Zhang, Yuying" , "Li, Xiaoyun" , "Yang, SteveX" , "Guo, Junfeng" , "Zhang, Qi Z" References: <20211103030705.211093-1-jie1x.wang@intel.com> <20211104092947.244962-1-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Mon, 8 Nov 2021 09:02:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c05de05f-c60d-4d71-55a4-08d9a2968239 X-MS-TrafficTypeDiagnostic: PH7PR11MB5863: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: twRFl3gIwgznqVhyFFxDctaySbtn5CpOl4MmnGRxoYw5RSZirjFgCrzBrfFlUaMBRahNNSPfBwn11KE5MnbpdsJlzwCFtxz3y6/r4nOlqoJmEXTwkwwSk3ov2aRr460/r62kpNaVECGVzn4PzUg/ARXW4l+dMdPYLyZVYIJeb8lhlEgbUVs72YcMoaIb3Ks3pMiF6HE+a55sgzRaSXvb1AuG8aBdKn/M7cWFxMlLBxE/0mnO2y0nyJWT2vLYK8bWpnYYHfvOT5eKxVtMXSde8wBI4k8u/oLKborqxPqJR8cVa65PukVVBTFsP3E0+o+Q+55x0o0j5Bsmf5vPb+yiWGPfumcLEUNitNndjkMPYA/ZRxc5tlXyYqtQJr3i1GOsRhMTkRy85nYDgWvJiXVl9HiO50IPEOYDOiFBmyqYhVjFkLbw+LykynzuCjr2+QmiYR1hYlYV/6IIzvYs28mVsbR1PkXVa0xhLLrhfm2mTCw6HcWFIs8FnuRXX0OkcZ43feLxGEO/rSWMOu6QkmkhHWTiMtPim46o3sMIAZ89xUVp5HUFRKBkk21WUlQ9KYonaDSDDVonIvdu8Odk/vnNzwkbdU+8cBSRIpmvgyGECiWIRDcr8agFP9GrH4lJTlkkZMmUN02pkt9sD8TDJ9EFwc1pITSgJao2fqjTvRTqEXr2/f8hr8gUOkhXppNlhtL/K731EUZcfhWCt5LPi9bzlA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(66946007)(110136005)(6486002)(31696002)(2906002)(956004)(44832011)(86362001)(107886003)(6666004)(83380400001)(36756003)(5660300002)(4326008)(186003)(2616005)(53546011)(31686004)(316002)(8676002)(508600001)(16576012)(26005)(8936002)(54906003)(38100700002)(82960400001)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S085cEM2MVJYZjZvdmJVQmtHamEyVHMveWh0clhYU3J1WHcxWHVLd2hIYTZR?= =?utf-8?B?OU5hWkpJbnFmeU44d0JCdlhrQzlLRDNDa0tqYXJwTGN4QmRiaFhsRHB0OUwz?= =?utf-8?B?ZzNZWlVwdDZpRWs4eldIZWl0anJFZnZwdXVDNTc4TmdhUmZlMi9xVkFqV3Uz?= =?utf-8?B?ejJuNHVHbU5EZkRpQkUwUWtvYmw0TFRIY2ZYdFlYWmNwN0N6VlFkYTJrSTFl?= =?utf-8?B?bkpYSkx3a3dOaUxnMk5VVTNNNXlwMzc3ZjJ1WGMycU4yRW51YjJYLzBYUWV4?= =?utf-8?B?bHVtMURDSEI4MFZXRUdpRkZkb1Y5dFpuTnU3V2UwMjg1MDN2dEJ1dDcrNWg2?= =?utf-8?B?Si9Gb205Q0NIb0JaRndhVDRYaXJDUnYvTkYydk1zS0Y5ZmFKcVE3NXJwdlFx?= =?utf-8?B?QUFqTlpFdkFFVmNiaEkwSXh5eDNEUmZ6bGdGWWp6OVZLLy90NFQ0U2tMZ21F?= =?utf-8?B?SE9sUmNJdzV2c2lRc3FDeWJiUUJZeTVhU0h0aFlhYWk4MGg4NjltMHZOUjlm?= =?utf-8?B?VkNidVF6cUVFMU8ra2U3aG0ydW1lUmhNN0NOVGF5L3BmQW12WTlGUTlCUU4y?= =?utf-8?B?RENPWSs3M0RXMUNpUDVEYjRQb0M2SEpUVmFHanU3eHIxejlYMEZTbzQ4NXhT?= =?utf-8?B?REFSY0UrQjZMQmhXWi9vYWVkbTJlZml2MU5pUUN6a0NlYnpvdStQMW5xbHFm?= =?utf-8?B?S0NNVW5pRFdUOGk3NHdmaWwxblJ5NEg5NHZ4RlFwY2c2bnpQRGsxc3M1YnVo?= =?utf-8?B?WGFnaVdXRThMVER3SzZnMFZDTDJIbHE0SDg2cit6aTVnbW5XeU5UY05uWGNP?= =?utf-8?B?T3daN2UwRDRmQXhSYjJjaFFpVHFUWWxhSkp6STZvNU9NWE5QTnhtdHJmOHpr?= =?utf-8?B?Yjd6UDYwVDAxT3owb0dPUGlkVnRuek5GYkR0N1o3R2tRcnVJeDNGaWpaanZx?= =?utf-8?B?bGhhNzV6QVcyMGJqTjAwQWpHMm9BZGhOR2Jxb1JrQmQ5d3ZuNTlEVGRjZ0Y0?= =?utf-8?B?aUJXSmtnWVgyVjJyUzBIeDhDT2M1blYrZkt3ZmtScklHT2hBc3dyY1lPK3E2?= =?utf-8?B?MFJMZTV0WDJXQjYzQ045eFpUVGZVSTkrVGFWWTJMOUdQcmJiMEd6Zi9TbFNG?= =?utf-8?B?Y2xHNHhtbzl5N2g5bk5qUUJMeFN1M3hEWHdEUmxkZlI5eEJFTWRZeWM4bEIv?= =?utf-8?B?TXFRb1FUOGx2aVdWOU40b2oraGZFY0ovVVFiemRMZ0hxbmpTcnBvME9LbHVN?= =?utf-8?B?L240UkRkL2tNUTkzckRmSTFUYmx5VjdJTGRidjJpMytnRlhBYXJac2RZZHhU?= =?utf-8?B?dXhySjRBUWpZUWl3S2VtMFd4ZGNVa3A2ZFlianhhSTIvRUlYRURPVS9WQVJW?= =?utf-8?B?eUtselVncDhPdXdCRHpPL3VrYUZrMnFpeHVjbTZlTnpwc1o5aGdxYllqMGkw?= =?utf-8?B?TnN6a2R3d0QwOWMyTWZsL0FMRnR1ckk4M3BKVlVpbEU1amdSTWwzNzNJd2NT?= =?utf-8?B?MURzOW84TGQzeGJNa1A4M0huUmt2UHNYV0hDcGZNdmM4WENJSm5xY2FZMnpJ?= =?utf-8?B?ZjVKaXMvTThiZ0w1L1ZheXRvaXFmSGxHcWNFd3BoVFkyTzRjZUZiQkNDWjhN?= =?utf-8?B?SzNwUkpJYWJxY01jMkdSWlZJOXB4Q3JPcDZMUHhvc3VvbERJVTk3K3p3Y05h?= =?utf-8?B?TEtGN01lWExWa1ViNXRRRlpuaVFOMjU4ODh3MmRmWXJCdzJtTkVWZnQzM3pt?= =?utf-8?B?QlRNdFVtZDRjMEgxVXFyTS9YZEdFNk0vNWZUcjhUbnYwMXAxVVl6M2Yyd3Q1?= =?utf-8?B?Y3YwdzdUcDdjcXYrS3czRWRNMXYxTEpDa3I5Y21LdjJ6OHZ0NjdQN05tK0Ey?= =?utf-8?B?S1VUSkxDeURueklXTEd5NU5oNkJoTTI2THhEQ1A3UkFxZjhBZGtkRnE4RVVU?= =?utf-8?B?ZUlFdmFYc1drU3RCbWNjd01HM0YvZGIwZHdrNmY0d2M4S0Z1akVRY1pCSnkr?= =?utf-8?B?dEIvY3BVclRqNGo4NU5uaUE4eVY2cm1rcStycEwvTkQ4TFZMSG1LdVNMcWwv?= =?utf-8?B?dGxTazBmTERybEJuTFM5Wi9hK2d3a083Q3VWQWY3Zi9COG10TjZ3MGp3Tkdr?= =?utf-8?B?UHB2YUMzdVZ3UVQ1UkZJUDFUZlZjN0F3eW93RTFhS1diR1FjdklHcDZtMmJH?= =?utf-8?Q?15zmjrSrO+/xruF37BFzPmw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c05de05f-c60d-4d71-55a4-08d9a2968239 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 09:02:36.6073 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CztZJ0t4D0/Ee2RHCpsCzVM81epFamvB4mjy9T4eUZHN50xgg8fvhtzvv3Zw9ob7C7egSuMz5kzjuh0g6P61QQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5863 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix set Rx offloads RSS hash off X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/8/2021 7:24 AM, Wang, Jie1X wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Saturday, November 6, 2021 12:24 AM >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: Zhang, Yuying ; Li, Xiaoyun >> ; Yang, SteveX ; Guo, Junfeng >> ; Zhang, Qi Z >> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix set Rx offloads RSS hash off >> >> On 11/4/2021 9:29 AM, Jie Wang wrote: >>> When we set Rx offloads RSS hash off in cmdline, then we start port, >>> if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple queues >>> mode), it will load RSS hash in driver and sync to port. >>> >>> After setting Rx offloads RSS hash off, this patch removes >>> RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mode to fix this issue. >>> >>> And after setting Rx offloads RSS hash on, this patch also adds >>> RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mode. >>> >>> Fixes: c73a9071877a ("app/testpmd: add commands to test new offload >>> API") >>> >>> Signed-off-by: Jie Wang >>> --- >>> app/test-pmd/cmdline.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index >>> d08a1c9777..f8277e4443 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -16176,10 +16176,16 @@ cmd_config_per_port_rx_offload_parsed(void >> *parsed_result, >>> port->dev_conf.rxmode.offloads |= single_offload; >>> for (q = 0; q < nb_rx_queues; q++) >>> port->rx_conf[q].offloads |= single_offload; >>> + >>> + if (single_offload & 0x80000) >> >> I don't why you used immediate value, but you mean >> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' here. >> > > I will update it in next version. > >>> + port->dev_conf.rxmode.mq_mode |= >> RTE_ETH_MQ_RX_RSS; >> >> Why enabling RSS when 'RSS HASH' offload is enabled? In this case if RSS is >> disabled I think it should fail. >> >> Can you please describe again what problem you are solving? >> > > If 'RSS HASH' offload is disabled in the first, the mq_mode RSS is disabled. > Then 'RSS HASH' offload is enabled in the second, so that we should enable RSS here. > >>> } else { >>> port->dev_conf.rxmode.offloads &= ~single_offload; >>> for (q = 0; q < nb_rx_queues; q++) >>> port->rx_conf[q].offloads &= ~single_offload; >>> + >>> + if (single_offload & 0x80000) >>> + port->dev_conf.rxmode.mq_mode &= >> ~RTE_ETH_MQ_RX_RSS; > > When 'RSS HASH' offload is disabled, that mq_mode RSS should be disabled too. So that it will not enable 'RSS HASH' offload in driver. > I am not clear with this statement. "RSS HASH" can be disabled without disabling 'RSS', indeed that is the reason to have this offload. And most of the Intel NICs don't support disabling "RSS HASH" anyway. Again, can you please clarify the real problem you are solving?