From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B070AA04FD; Mon, 23 May 2022 10:43:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0A5D427EB; Mon, 23 May 2022 10:43:25 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2067.outbound.protection.outlook.com [40.107.223.67]) by mails.dpdk.org (Postfix) with ESMTP id 2CBBD42685; Mon, 23 May 2022 10:43:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyzW/1bYnUKkCkAtabuVu2kvfWjOR0ZoZqGbCi4v2M0aMWCjaDhkfA85okAiE8nOY4mIPxfAZl8VnHmEJWk9P4HW80Z4VNUioUoS28rRayn9e69J7PELZIZg9xeFHY5uXBK0VE3MtJVbsTVNU1R5Y1ZTsuzB1toTJfDH40YVBHP5FR9phghF/AGoi3gqU8MeCOpGa66TTNTqSrLvIVuhCBifZ9xdXsFyyWTgur0jiBI5iOKiQzDzjjVorgO/doHMxSrQ28jVNc2u9sQVqAkkzg2JEBgLwEXFSCkEC+J0PGD+lM6MOhLAVuuWL1sT9JlgE+v4OtfGZs0vLYxHvcgbSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fV6PxfdfRz/UgMWQ4/zFjm7pDE5sqJUQphyw5vAdUAw=; b=U1+d+rAXDvPNqsS1UlBFxkfgvOO3bvPQreeB5TNcOZxhjvgtDzmW2alV2+c9pM0YrxMIDJfNIL95zLeB5MXFoPSGXRiKR/qwkQosDRnBpZ7fgbaFuEG3RpLT1cjkss/kOTVjrdXhxkRBRAf9Y0FcDs2Jcdh/4VL5K3te/XAsw+CRnqCnibyxk4ybjmDnM290TLtrilK6mq0idTu1JonYNHhWsYs86x9b4f2aZ5j6WvYo7hzp024DppMdNTpN9PEsuo6hgRiwC7ckAcAv/AzRJqgZHK3hAAUp7pffwsTJQmS9pw2taWoSaryc2Ro+G7tqaH/uYmVQ4Gre0aIqSpThEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fV6PxfdfRz/UgMWQ4/zFjm7pDE5sqJUQphyw5vAdUAw=; b=oksGxzMy4oc9ca/Adu5G6Sh/8dbou7B24BM5bUtie8tgXAnCuqdlo39DrL+qD+nV9tW1QF7y+DcwmdjKNvtWrhhvk6HnrjWkdLdtJMCYiUNNh77kjedyzPgbW7XYQpGkzX493A0XfMv3wANQk/oJIvthdTs4acYlBrZfZ+tZN60= Received: from BN6PR1101CA0015.namprd11.prod.outlook.com (2603:10b6:405:4a::25) by SN4PR0201MB8726.namprd02.prod.outlook.com (2603:10b6:806:1e9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 08:43:22 +0000 Received: from BN1NAM02FT003.eop-nam02.prod.protection.outlook.com (2603:10b6:405:4a:cafe::71) by BN6PR1101CA0015.outlook.office365.com (2603:10b6:405:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18 via Frontend Transport; Mon, 23 May 2022 08:43:22 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT003.mail.protection.outlook.com (10.13.2.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 08:43:22 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 23 May 2022 09:43:20 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 23 May 2022 09:43:20 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com, g.singh@nxp.com, mingli.yu@windriver.com Received: from [10.71.117.73] (port=58513) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nt3eq-0003Uf-Q5; Mon, 23 May 2022 09:43:20 +0100 Message-ID: <2e53a12c-dda4-bce8-3b6f-60c2c00f5056@amd.com> Date: Mon, 23 May 2022 09:43:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] kni: fix compile error Content-Language: en-US To: "Min Hu (Connor)" , CC: , Ferruh Yigit , Helin Zhang , Gagandeep Singh , Mingli Yu References: <20220521070642.35413-1-humin29@huawei.com> From: Ferruh Yigit In-Reply-To: <20220521070642.35413-1-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ef84d51-e725-44e6-5f89-08da3c984b4c X-MS-TrafficTypeDiagnostic: SN4PR0201MB8726:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x5a4HN6FIH4fAhLqfdNDQv1WPClVhYyjq5wjwjjjNygLXxi0jLdmPYQcyIARnLBkPix1On7sSYjhdJqg920eaWCpsYtCz8x4G597pjjSO/XQPQr9rMc/mUin4OxcU58Mn/VFuvhPuaJkFTifkXV4NMw1UGAypB1yRnv+ziAqloIEDZsfs7xKYDc6gpa3HuopuvcRcOaK1WP7Gv/zjbgdaA6M1RycbDCn1aQuH+olK+oDHOUIQCUHngkh7Pn+KWRUOEmtS9lNOUYLi81kS6qtfEesO9IHGp0SnZ28prQB3rNa7SlUqiJR/v5wxo1bi4Ze5qJlWqcb8MSRobNSlMTYRd938BSZeJUdCJ3XssU5/dYt+csEuKweE+OxIM6FTlFbk+X2lqwSdM6m5gfkjWxfH8M2Za70JQcwsFSCjKYbXjzbPw37mKwm3drxFa+pNMJkoapFZQUxiDuV1ydEKQU3NJ5XoMkNjk0ChPZxxLiiLx66Pa7iCOLYfwOY/EVixq2NtXbs2GLT0SYKXe6Qnp+6+YoJI7/945u4xvGyWfvUduC026io40mFrDuugD8tfTl9VoF/JecIqOdFdAeENupTbv6sUecrcyoRbBy0iMPP27xNv5xQjhKIbDBy+nc7b8NY85LMweJzoM7rE/7x/ledJjIbEG2TwdYAcajU62RUUGOH+X+XOLW7s/4cGiHBASJpv1sNlUsfDPSnxq3nti3yGpFJSTp7ve+i+y290XYQxgJPrg09cj5QyuyUAjCjHs2p390nwoBcv2+QUrqtGwgLfso//F3w2OyqS9vQi/96GX34W/bEEgzU193dXdQp42mp X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(40460700003)(36756003)(47076005)(2906002)(5660300002)(31686004)(35950700001)(356005)(7636003)(83380400001)(44832011)(31696002)(53546011)(316002)(110136005)(54906003)(9786002)(336012)(8936002)(82310400005)(8676002)(4326008)(70586007)(70206006)(26005)(2616005)(966005)(86362001)(508600001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 08:43:22.0463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ef84d51-e725-44e6-5f89-08da3c984b4c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT003.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB8726 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/21/2022 8:06 AM, Min Hu (Connor) wrote: > [CAUTION: External Email] > > When kernel version change into 5.18 from 5.17, 'netif_rx_ni' is discard. > It is replaced by 'netif_rx' and this API is also supported in the > version below 5.18. > > This patch fixed it. > > Fixes: d89a58dfe90b ("kni: support chained mbufs") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > kernel/linux/kni/kni_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c > index 29e5b9e21f..e19f03285e 100644 > --- a/kernel/linux/kni/kni_net.c > +++ b/kernel/linux/kni/kni_net.c > @@ -441,7 +441,7 @@ kni_net_rx_normal(struct kni_dev *kni) > skb->ip_summed = CHECKSUM_UNNECESSARY; > > /* Call netif interface */ > - netif_rx_ni(skb); > + netif_rx(skb); > Hi Connor, There is already a patch for this [1], can you test & ack that instead please? Same for Mingli's patch [2], @Mingli, can you please test and ack the [1] instead? [1] kni: update kernel API to receive packets https://patches.dpdk.org/project/dpdk/patch/20220421085931.2429443-1-g.singh@nxp.com/ http://inbox.dpdk.org/dev/20220421085931.2429443-1-g.singh@nxp.com/ [2] https://patches.dpdk.org/project/dpdk/patch/20220511112334.3233433-1-mingli.yu@windriver.com/ > /* Update statistics */ > dev->stats.rx_bytes += len; > @@ -779,7 +779,7 @@ kni_net_set_mac(struct net_device *netdev, void *p) > return -EADDRNOTAVAIL; > > memcpy(req.mac_addr, addr->sa_data, netdev->addr_len); > - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); > + memcpy((void *)(netdev->dev_addr), addr->sa_data, netdev->addr_len); Why don't you use new helper functions instead? I can see not using helper function is causing other problem as well [3]. [3] https://patches.dpdk.org/project/dpdk/patch/20220407082544.21282-1-humin29@huawei.com/ > > ret = kni_net_process_request(netdev, &req); > > -- > 2.33.0 >