From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D1A8A058A; Fri, 17 Apr 2020 13:03:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B564E1E49F; Fri, 17 Apr 2020 13:03:57 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 40EBF1DBD8 for ; Fri, 17 Apr 2020 13:03:55 +0200 (CEST) IronPort-SDR: cfeUp+bqxxhSca5hge6TtvTQ+nudCCZFxCMiK5PrQ0Repk0sjAjgYEoKPaJ9anWCY/XAdoYTK3 euRlCGr6nLHA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 04:03:54 -0700 IronPort-SDR: RU0Ep4u39Lgy0nj9jD4fne+qH4dtzXW/fNywZTx9PAvoKgheMMcWFWmUeUbNCwG48HRhBJoYVD muYGYbSgH+eA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,394,1580803200"; d="scan'208";a="454694800" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.192.248]) ([10.213.192.248]) by fmsmga005.fm.intel.com with ESMTP; 17 Apr 2020 04:03:52 -0700 From: Ferruh Yigit To: Ajit Khaparde Cc: Venkat Duvvuru , dpdk-dev References: <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <8320ae09-1b90-63c6-e61e-5891d54daef0@intel.com> <8fc7449b-ccf3-b99a-47c0-18640764df4f@intel.com> Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <2e54fe5e-8e52-dcc5-81a7-40a6c5ec650a@intel.com> Date: Fri, 17 Apr 2020 12:03:52 +0100 MIME-Version: 1.0 In-Reply-To: <8fc7449b-ccf3-b99a-47c0-18640764df4f@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/17/2020 9:37 AM, Ferruh Yigit wrote: > On 4/16/2020 6:51 PM, Ajit Khaparde wrote: >> >> >> On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit > > wrote: >> >> On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: >> > This patchset introduces a new mechanism to allow host-memory based >> > flow table management. This should allow higher flow scalability >> > than what is currently supported. This new approach also defines a >> > new rte_flow parser, and mapper which currently supports basic packet >> > classification in receive path. The patchset uses a newly implemented >> > control-plane firmware interface which optimizes flow insertions and >> > deletions. >> > >> > This is a baseline patchset with limited scale. Follow on patches will >> > add support for more protocol headers, rte_flow attributes, actions >> > and such. >> > >> > This is a tech preview feature, hence disabled by default and can be enabled >> > using bnxt devargs. For ex: "-w 0000:0d:00.0,host-based-truflow=1”. >> > >> > v3==>v4 >> > ======= >> > 1. Fixed some more compilation issues reported by CI >> > >> > Ajit Kumar Khaparde (1): >> >   net/bnxt: add updated dpdk hsi structure >> > >> > Farah Smith (2): >> >   net/bnxt: add tf core identifier support >> >   net/bnxt: add tf core table scope support >> > >> > Kishore Padmanabha (8): >> >   net/bnxt: match rte flow items with flow template patterns >> >   net/bnxt: match rte flow actions with flow template actions >> >   net/bnxt: add support for rte flow item parsing >> >   net/bnxt: add support for rte flow action parsing >> >   net/bnxt: add support for rte flow create driver hook >> >   net/bnxt: add support for rte flow validate driver hook >> >   net/bnxt: add support for rte flow destroy driver hook >> >   net/bnxt: add support for rte flow flush driver hook >> > >> > Michael Wildt (4): >> >   net/bnxt: add initial tf core session open >> >   net/bnxt: add initial tf core session close support >> >   net/bnxt: add tf core session sram functions >> >   net/bnxt: add resource manager functionality >> > >> > Mike Baucom (5): >> >   net/bnxt: add helper functions for blob/regfile ops >> >   net/bnxt: add support to process action tables >> >   net/bnxt: add support to process key tables >> >   net/bnxt: add support to free key and action tables >> >   net/bnxt: add support to alloc and program key and act tbls >> > >> > Pete Spreadborough (2): >> >   net/bnxt: add truflow message handlers >> >   net/bnxt: add EM/EEM functionality >> > >> > Randy Schacher (1): >> >   net/bnxt: update hwrm prep to use ptr >> > >> > Shahaji Bhosle (2): >> >   net/bnxt: add initial tf core resource mgmt support >> >   net/bnxt: add tf core TCAM support >> > >> > Venkat Duvvuru (9): >> >   net/bnxt: fetch SVIF information from the firmware >> >   net/bnxt: fetch vnic info from DPDK port >> >   net/bnxt: add devargs parameter for host memory based TRUFLOW feature >> >   net/bnxt: add support for ULP session manager init >> >   net/bnxt: add support for ULP session manager cleanup >> >   net/bnxt: register tf rte flow ops >> >   net/bnxt: disable vector mode when host based TRUFLOW is enabled >> >   net/bnxt: add support for injecting mark into packet’s mbuf >> >   net/bnxt: enable meson build on truflow code >> > >> >> Hi Ajit, >> >> If there will be a new version, I suggest following commit titles, if they make >> sense can you update accordingly? >> >>  net/bnxt: update HSI structure >>  net/bnxt: update HWRM prep to use pointer >>  net/bnxt: add TruFlow message handlers >>  net/bnxt: add initial TruFlow core session open >>  net/bnxt: add initial TruFlow core session close >>  net/bnxt: add TruFlow core session SRAM >>  net/bnxt: add initial TruFlow core resource management >>  net/bnxt: add resource manager >>  net/bnxt: add TruFlow core identifier >>  net/bnxt: support TruFlow core TCAM >>  net/bnxt: support TruFlow core table scope >>  net/bnxt: support EM/EEM >>  net/bnxt: fetch SVIF information from firmware >>  net/bnxt: fetch VNIC info >>  net/bnxt: support host memory based TruFlow >>  net/bnxt: support ULP session manager init >>  net/bnxt: support ULP session manager cleanup >>  net/bnxt: add helper functions for blob/regfile ops >>  net/bnxt: support process action tables >>  net/bnxt: support process key tables >>  net/bnxt: support freeing key and action tables >>  net/bnxt: support alloc and program key and act tables >>  net/bnxt: match flow API items with flow template patterns >>  net/bnxt: match flow API actions with flow template actions >>  net/bnxt: support flow API item parsing >>  net/bnxt: support flow API action parsing >>  net/bnxt: support flow API create >>  net/bnxt: support flow API validate >>  net/bnxt: support flow API destroy >>  net/bnxt: support flow API flush >>  net/bnxt: register TruFlow flow API ops >>  net/bnxt: disable vector mode on host based TruFlow >>  net/bnxt: support marking packet >>  net/bnxt: enable meson build on TruFlow >> >> Ferruh, >> These look ok to me. >> Do you want me to respin the set or can you handle it this time? >> I am fine with both. > > Hi Ajit, > > Let me check if I can fix the build errors quickly, if so it is easier for me to > handle myself. If I can't fix them I will ping you. > Fixed and pulled.