From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shreyansh.jain@nxp.com> Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0059.outbound.protection.outlook.com [104.47.38.59]) by dpdk.org (Postfix) with ESMTP id B29F02C4F for <dev@dpdk.org>; Tue, 17 Jan 2017 14:36:47 +0100 (CET) Received: from BN6PR03CA0072.namprd03.prod.outlook.com (10.173.137.34) by BN1PR0301MB0740.namprd03.prod.outlook.com (10.160.78.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Tue, 17 Jan 2017 13:36:46 +0000 Received: from BN1AFFO11FD044.protection.gbl (2a01:111:f400:7c10::108) by BN6PR03CA0072.outlook.office365.com (2603:10b6:404:4c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Tue, 17 Jan 2017 13:36:46 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD044.mail.protection.outlook.com (10.58.52.191) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Tue, 17 Jan 2017 13:36:45 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0HDah22006363; Tue, 17 Jan 2017 06:36:43 -0700 To: Ferruh Yigit <ferruh.yigit@intel.com>, "david.marchand@6wind.com" <david.marchand@6wind.com> References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com> <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484647774-28984-10-git-send-email-shreyansh.jain@nxp.com> <efeef9a6-05b7-6637-aec0-fa3dcbd2d7bb@intel.com> <DB5PR0401MB20543DA5450E4EB550F06001907C0@DB5PR0401MB2054.eurprd04.prod.outlook.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com> From: Shreyansh Jain <shreyansh.jain@nxp.com> Message-ID: <2e6605fe-b351-b406-1629-d8b2eb3d5fb4@nxp.com> Date: Tue, 17 Jan 2017 19:10:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <DB5PR0401MB20543DA5450E4EB550F06001907C0@DB5PR0401MB2054.eurprd04.prod.outlook.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131291338059072094; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39860400002)(39850400002)(39450400003)(39840400002)(39380400002)(39410400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(377454003)(13464003)(199003)(189002)(2906002)(31686004)(356003)(4326007)(23746002)(189998001)(229853002)(86362001)(54906002)(38730400001)(5890100001)(2501003)(65956001)(77096006)(305945005)(65806001)(47776003)(4001350100001)(92566002)(83506001)(5001770100001)(97736004)(230700001)(54356999)(105606002)(68736007)(50986999)(76176999)(8676002)(104016004)(626004)(5660300001)(81156014)(31696002)(8936002)(81166006)(106466001)(93886004)(36756003)(85426001)(64126003)(65826007)(33646002)(6666003)(2950100002)(50466002)(30001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0740; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD044; 1:ofx8Brl5GEtSaGS9Wf72qKh8qra71FXFmjMtGmLECnVkqBlV4QhP6dKZ3Qqp/jhe1IIXsRyAYwlFTkkCGscN5iiDA0d3CSZBTJMLQLCwKWceiXg3c47PzR8gxa4gjZlQW+i5BI3lMf/TJufhhjcaP6jaBSkH/I+//NtEj/tkgYHBA4QHxygWU6ywW9wioJWlWcYKkfiGlsSXjrQWjy6wfqwq+K4AowIZxluWP7VNIpUHSdrYKWF+/XeYqCmkL33mdKAcyhqd48ffdedasInk1MTmp4qeYE426uHv+G7diQCrwVqzT/QCXUZvJ+PxySpLHKtYOEjdrU7a0BevWd2RuBNDqLFs/QVKRhbHh1kAM5pA89BeMEcs1+T8hsXtCIUVxYCEGN0pNOlzcHHrakfG8SoBd3LDNWQMigfma51GiC/GU6jU+JQtYVhDGBKFly5QghL79QKJge5dzx6314o6w5std6oIJDvkiZd+llkM9vc/NcYhR5wRjFc/7MFhWVuwyy+6lZCHTKXJjX5BdwQCB3JDEk6ejIcJn83Kdp21hEeCUzM6uwagA+xVhIyQIGvrM7m1O3aGlqhv0Le/Fz8BAx1+HHol6pOtuGdmbrVq4kUHiqpn5xc+lvIicCBVI71Q X-MS-Office365-Filtering-Correlation-Id: d9484d3c-977f-45af-c25e-08d43edde18f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN1PR0301MB0740; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740; 3:5ipMJTOkcbUHHk7mYWfYFFC9Jhf5O/HwW+LEnxS6WNsidcsuClecET6QUOG0Fm2fG0OadGyw0OO/plPb5D4JehY3Bh64lTebcJXAGHo7ofTDkCXnloawFQWECmHMh0t5fDE+JgKQ1bIf4dkCKWSLm8o1ni7pAph0V4he4TSbwAmeTAVL96tt6a2pFhvdQUqOsjz7xWbbmi/gJM/yuoE85h4cE8o9UIhP2MgfzeegaCiuCuLGMoJVdG98E8PgkyUjh6XAoaQdAmR+pFndgGkhDy2MQiwLRlHl4v0qfUJG49lQNwYGvN0y7jlglLA0W4D3jEjizH2Q+vHNWyHcbwLreIRdI8WxXGqVr3V0PgHpXzWW2UNM6SCRg8ADW6q32Lm8; 25:08+wiZzKSw5BhJoNYsf5dJWpOsGuVF4tDzNH7BinEM/y8TnBK+ohlNpbL7yDXPPYyvFNbohbFm6aBFelIxknsNPijhfS+by7pL/kbwmKnTXvvWZO3NDyyMinVLLNhdXUT0ppuhvubhYQJdZXMhPRyrjQQ6fFPNgxKBaLClYfcHGmgGM0BneTQA+43zW5qBbbSsoe8PvdL3LaTnPn/uYxdyCtzG6YSKEoKMx/Qe3zBNfjYnzW7pmGU6F2glJyYVLZbahcTpy28RkrHhgBgu76lP06YUkR38uc6GJE80Te70BmgwpUSeToeX/mtiEoJSQa8IgZLjtq447mrWEesPw2/3dPbg1uYfZZmwwR3zmo0RZay5HY9C3bMBR7qD2AJbH1CsvTfQi/u9DKHVQ8KEcEuXXmgsdCXdwN83Ye1brnW29CDEJoDVtI4GuUpFekYti9bPN5QXYr5yzGCQUbcd7aaQ== X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740; 31:RUF5bHlpHQfqdy+Tr06RQgIU3DBFnn/cevto4OOu3aUu1Hw49lDUUb82ocl48tXdW/LyEqxNA5P7lDayWS2uWouA+ybs/V3NdHp0j+Q3/cJej++AzujhAfLQEwdci8YbeVSUbTY3Y8+Thoq81GavPbYO7+xqXDFOV4u+tlX20hvSgEOlBv04JMM+7evzJCb2penW6i6V/cyuZ7LX2g6mZG5nW41kwZNIkzJ92hVWm2UAmDmGxJjwTu0ogDN0LCVMGV0RgHFbMIoi5BMoHDIl0w== X-Microsoft-Antispam-PRVS: <BN1PR0301MB074089962B218E39F77F4661907C0@BN1PR0301MB0740.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:BN1PR0301MB0740; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0740; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740; 4:pkNuC40YtcG/619R5Sf7/qvBosLp8qYEpQxuyEdL6EMeualejplsO+UeZ1DqeuoVmqk9JpEPFEBj6G8BOSYcI57RoaYHE0hhbuuaBzhwgt2UJGR85nYaj2jQFDbN0zdttbWR6lByHKkYLEZsa4OIegUmqtYX/3VaKhzT+Px0So4lWjxQXgx7ONvmnRCOB/d77bnHiyWoOsew6H6bS+lSz5oiCtf1GC/Xtvccug1yvfiDaVtjqrvIQI3hbUcyckSUPQtk2F3wuaeKcz7RitOzfw0rTA4fen892Ao0I+v5xgONX/fz1pG4PhVbdKpss2AdsqVGnzEzSycuy49ujExRdOD4LKUw1UHSuJY+YdpAk9fOxChpU7rLgZzyKBcRWM7iYxPp4C++WEm8hQYA/EDtYWsenLU8j6GhWfBINF40yokeKIg8rAaQJb1pHSXRu3cXSF438ipy1DT8Kcxyyy/arukBO+BJJfFkrrEPz8nAoXtwhlYrRgWP8Say+bxlXvbiHbKo7MF3Mi1j+04EM5Mh+FQ/OpDlURGqHJ/UJAA0/bL2ZtY82oIY1zbic4Fl2m+MoebT9JplszvXGoSFuFQULVbL3ShwEQ9L4JQoABxSCNnQr0Reorte62rAJUOge0C1utV+kKxZ9tS05tzK5xhxJ6RXLJssiz/pygzcoNprjxotdICcpZ8kYUfuMxtQ+ncdCQc/cVirZABrFa4Ndt142lmByfNhyt+m6tuLlGNqPLb+cIqdhcNPGQB/qu5/wUAmwG/B8oDTxasCei3RpatwbQ== X-Forefront-PRVS: 01901B3451 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0740; 23:RgRXztABSES31Z8UO02LYPW/jfDZHO4E+tw?= =?Windows-1252?Q?TCBQ/0e9gpAWjdxB/W1XDDLHCIjeyM1EJwzxahOLmwk2C3uwSVT5CbaO?= =?Windows-1252?Q?7jKl0PCeQH/gxhztKYMA6CQpfA0JsHUXkfBc6f2JZtx84+1jjpc10Bav?= =?Windows-1252?Q?TK12r+CII4B6Q0gSKUSGYKYxor3ASu3K/YEbCQzcZiXsmYLdPaMCJfKw?= =?Windows-1252?Q?CN3IoQ0y1EfxIlKOUqNdW0F/6CQQNrKKF2uN8L1F04kkW+2xApIte2kQ?= =?Windows-1252?Q?ZGDmrcAkznT1CfI4BArcTSwbdOaFcHUt5hOMtKqP+hJ/Cb4//2j2rDLg?= =?Windows-1252?Q?IDPR+HSRvL1pYYX7TDEpv5VT1eVfWxBreNoEJDnjEB7ibwDt2YNHyyfN?= =?Windows-1252?Q?gJxEgP3UNKjWBwuLLAuMZGygUdYfyc2I8vZ6yS9VXigIAhFHi+bAXZy4?= =?Windows-1252?Q?YYkckMWMxFoEKGP5+KuYeAO5lYWvBrZvKl8Sy/rygaPrFHDnwS69xhMm?= =?Windows-1252?Q?kphixpeBhrVklOYAxhbHhMU+QrRNFwFV7cHWyl4w4rDck+wO52qHllFE?= =?Windows-1252?Q?sDduB9X0oXNpqyteKjqOlYeMM14UdtvK5ttAyUQSH+gX/32oT3p0cNoW?= =?Windows-1252?Q?8iBvSDmxdcJb8WLYxCSFXwhTnK9SPO9yNjTqhu2lBtZL6cuxY2axvm1P?= =?Windows-1252?Q?fVz0GfwI8QTDKavjL/wOOS2XS/eSrUxJO00dzuoCZnWfOl/OYTSnoaAd?= =?Windows-1252?Q?Ae8ayyNTeCBT0/FBwW686V6gWQnj7Jbyns4OQTxF6foeiZTfJPm013V7?= =?Windows-1252?Q?Y3qelgzU7m/K7BrFndNbPzJpj1uNn8niQZyaDOp6KCu2YOdS2UfJASyj?= =?Windows-1252?Q?DSBOZDm7VaOtLvPGo8u6DvKOg9FdaiRjLtj1vtkCzO8yLi3qne5mJl69?= =?Windows-1252?Q?+E20017JbwL1J7fSD+K18ukVIl5SU1mc84YnxAagfvPZvUCJ4f65WmRq?= =?Windows-1252?Q?Kqd/AUcj28K0arN8/fOGrvIgDrRaL7y2n4M7cJ6BJSQNc6A5uWVIlPc4?= =?Windows-1252?Q?lb4vxUoUYncA01PAJaYhxO08/bCVdO0PATvDMKn2+aEhQahAc+LP9mGZ?= =?Windows-1252?Q?xSu8rZywdmZzu0YAfQFkH2m1Ba88MNSPYByEMPxW7hsE/CW7+V4NVf05?= =?Windows-1252?Q?eeEwgpjN6dOuHa44YUChIlMP9hrj60q0FPUBitZ8fvVkpYFjuMhlIZiR?= =?Windows-1252?Q?pXDyFgO/aTP3A+Rhc5L/vBOiX5BrsfjIRUhIwU6AtKgvMPO/SttnA+yv?= =?Windows-1252?Q?Ke6rvqqZ+1FTHROWhn0fakeKoP4nO47RC6uPV47QHq9ozeTmCKL/hYmK?= =?Windows-1252?Q?iPfb1mVDXAzbPTqqr0u/r47UHOytu6tyWf9pgLuL0QMPWyYzH9VwS+lu?= =?Windows-1252?Q?8+HLb+jYSq4rmPrUMcpIem5pAKiGhQzGoRg9QgdodQ9vKTsOnguPjSQF?= =?Windows-1252?Q?xZqWkhHYTQpPrk16GGXMBaAsK1Cwido/aI6kda6cTEYnYWWMF4iG6ZAv?= =?Windows-1252?Q?8dfGikfGHzN9Z7rGCahrqEgSzyBhTiM1hG7H6pSRBFli5bU3uXY+Vep3?= =?Windows-1252?Q?3/dBJtNEXTsD26rzSIuaUDAExy7St4PwEbQq+JGIe7UlTFgrm/VuvqQU?= =?Windows-1252?Q?czWNfK6j6yZscjtAUdOt5J1ZJdWB3uaZZdYGu6XpR4QSggs82R7CCgoB?= =?Windows-1252?Q?192R4kYm5Q0nt4l1Dbg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740; 6:GeOZyFM9RU3GC2MJMEq1c17oD5nsrxHmO/AhZ6kybEtxbSkr4UUcT3Le/S3KRetIQEtBS8q3erNeTx6W8O/l07VKLrQkRaI+yexyb7VYTQTybrzIU+pF6FYIRq/qTgFMWvbb1MgnfS27kRjRN9dSqndDduxvX31mSBvUuPohqJrSHAvty/o+8MveQx0EY8lVKBzIRrgQAA0NvkcdAlro/jiN9shJrdk7EKMsTcTyAwXC1Xv3dJmC9CE7tDysYALX0nuR8xb/AdImqzMrF4oqPa3OSPEQt+E7e8CFFDXRdSVyb5MicL0AUYy2gNnYCKiXXZe5ofFOypd435Z2XDmO6uoa9+X+0bXr7Z0XPHFrq2lRRW7is+TBLeJqND0IWkgcl3IcJoKMvfEDAudggi4gkXmpBNVnKTxEdieUaJ8/LgBI1sBBNm7CwYWMl5EnY+UQ; 5:pwB8R7AiKg/z54TKKvFAm/nNU5IcGm3+3qkh8i+Kpubz0WBrkzn1ekJBJORTPdwRN3sdFdFS5ediPKdNkNZh18JPWCLWvP09OcCzdPNw1lKnzpbKY4eu00MB8/4xwlqNlHA/3J8o17/DPNTEjhXM555M8xyeHSR7pASZC1Jw710EvsHdrLtw4Gp5yLjE3EQY; 24:Az1bSRJqjWR0i9j6CG9DUe8WylPthGvuwlFPyn/t5HvDsHzlW8Ei3XIaUfqMU39BOwgrqmzqPcxWRlqRWww/PVYLniKm9u6DcJFEbQqm8B0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740; 7:5lnGNNCFFjfajpjyJXfs8cfp7w999raN5iKEsBt8y2sR4Q4fFNi94aTnKj8ABEGNYng9pWAFrYMcMoDYQogDZii0fDDndWpcGThSOiL223LGrpgAw9N2Zqh14qEoR0ysu0MXgTgtSHBapZXYxWxuJy1W8MbQNmEjiuseeElE5aPa3OLzmGTbQCVQ3BR1WRgQ5kj0W/CN6cBWlFNkgwWkdZl7KzkdQXCT88cpKoOOqMHLVtkLqHdVDKq8CkBeAYnmZ+lG/0Ia2dJGTNndzLmZzXODVnjnFULvxDcXtD0YptdfwqTeX3wKsw5vympeHAVLTpup7hiMqZsvWrk93rkFdqGlLVcn+nVf18YYbXtHboXHk3m7jbsmYBwyzmcgQT+/9gbDvaAlN1980ErxVrN1NOjwzRV1/j2wx0DMbPs3sSIm7WhQmVuZ0MbpaVTgzPtPHV1SY2JeN6W0nSjM2Xg/hg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2017 13:36:45.6732 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0740 Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 17 Jan 2017 13:36:48 -0000 Hello Ferruh, On Tuesday 17 January 2017 04:34 PM, Shreyansh Jain wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Tuesday, January 17, 2017 4:18 PM >> To: Shreyansh Jain <shreyansh.jain@nxp.com>; david.marchand@6wind.com >> Cc: dev@dpdk.org; thomas.monjalon@6wind.com >> Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on >> bus >> >> On 1/17/2017 10:09 AM, Shreyansh Jain wrote: >>> Given a bus, attach and detach callbacks allow the implementation to >>> handles calls from EAL for attaching or detaching a named device. >>> >>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com> >> >> <...> >> >>> +/** >>> + * Search and detach a PCI device from PCI Bus >>> + * Implements rte_bus->detach >>> + * >>> + * @param device_name >>> + * Name of the device to search and detach >>> + * >>> + * @return >>> + * 0 for successful detaching of device >>> + * >0 if device not found on bus >>> + * <0 in case of error in removal. >> >> These are the return values expected by rte_eal_dev_detach(), but >> rte_eal_pci_detach() is not following these right now, which is causing >> failure on detaching virtual devices. >> >> Fix is not complex, it may be an option to fix this as a separate patch >> after this patchset applied. > > Ok. I will have a look and fix it. > If possible I will push v8; keeping it pending is lower preference for me. I have sent a v8 to fix this (issue was indeed there). I have not used reviewed-by from you on v8 9/9. > >> >>> + */ >>> +int >>> +rte_eal_pci_detach(const char *device_name); >>> + >>> +/** >> >> <...> > >