From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF163A00C2; Fri, 9 Dec 2022 09:44:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9765940E0F; Fri, 9 Dec 2022 09:44:26 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by mails.dpdk.org (Postfix) with ESMTP id 00C9D40E03 for ; Fri, 9 Dec 2022 09:44:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZenzKXSv64Z/gph8SVC6VL7BLOURjza2b32gwQaJqZ74NLom6OAdedODkQGaiA97sMu3TwpujukFahkAMto557YbBRVClVPMQ3fG/1tAfCupc7BXVe0pH/EVCFC+emxOiONlz48KvcPYqD/gOIXzM4APzibghNozZfJLqrhZCdxKdTDLfbJzxXlX1y18EUP1/6SR/M3fxzLaZB8ZMsGbUTJ/0bjznOol15kdYaHhNiYCjBTLsZN0jk56/ca6bI6nj9mvAVqZVQivdbxYKZT2uZ5l2XvKKh+3JaiOLXqQ5zD+w7QDyMNZraqzY06BpWj7VcA5b56QycBWzdM8cKDLzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVKMG2tC+eecO6lXb0ExKpPB4sdfJE26k2Ec2PbX864=; b=dJmTin7SRwVbIEWugK6TAiCH1RwCVvPGHEVtFCD8TjXLAGfKEsODZWZCvF5/q+ifTA1TSZJFiKx78yXqFapbV/0aE59lFshQ5q8GD1fwujonDx5fCg+LTnjg1fNkQalmENGGBVSrQTd11cXJPqoE9CfNfjADB0VpWXBh3O1cmI3sFaB+TXK2JkmhrgWTm2kC1I2EEqsfX0XY5SUno/J9Bmv1VBA77Ob/so3Vk+HVJk/Kdh5BD/l9PNOub6Whisrau/mUnCqSlC5unjtMvkoYo5kZmxiPD+FxoPR1AVWnoErXNUmZT3puAWJr3xhgecX5OgSnDwEA5RIbA/YNeP3ooA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVKMG2tC+eecO6lXb0ExKpPB4sdfJE26k2Ec2PbX864=; b=vvqQJDnj1uoSNzjwMjQ8adKsJ5M2r1FpURel6olBdIURx4AINcFGcAjyhryHFfSnyM+Rt4+FXjVAk0iUnJ6vn4D4q9EBSH6xLz49eRwIK/rHH2+Az/z39bh82VjBSsPkrwUtiRtsYdzhzy44d950HV6JjKR1+eQpL7ibVpQSkM8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6525.namprd12.prod.outlook.com (2603:10b6:930:32::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 08:44:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Fri, 9 Dec 2022 08:44:22 +0000 Message-ID: <2e710082-6aa0-5b74-cc27-989b03b32bbb@amd.com> Date: Fri, 9 Dec 2022 08:44:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference Content-Language: en-US To: David Marchand Cc: Thomas Monjalon , Bruce Richardson , dev@dpdk.org, Akhil Goyal References: <20221206122341.3046688-1-ferruh.yigit@amd.com> <20221206122341.3046688-2-ferruh.yigit@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0414.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6525:EE_ X-MS-Office365-Filtering-Correlation-Id: a70d5265-6f21-4825-8181-08dad9c191a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jhWa7XosIYf7UGJEHlFPkxx/ZhI54DCDxwMciK3espA2ghtj4lGXBT5+A5EXPwyQQe/Y0oWSfDHUpVZkVFmdlEYQxprhNwyCzTpoi4Y/RiVSfAFYrWtcIaq7VC/Hl90BQzFQz05JB0dSnqHyql4KWQlo36Ks5PXuJzuVMBjokgQsvsbj0hvfDD4q3iiJd8bY8Tey6eSGMl+W4D75pttNhHBU7+bdwG7TIqmQ8kWync5unsRWjq+tCrVRB2S+d+UMAzHuN9S5atMnS8nWk2GuxYLAHUSkW8CCwS1/PkLxHOogsh/sgl7+mY4W8lMaUZIzWVAPzFLkgrwkfcOr15MJ9aLkskAOUMFeON3FkVgVtP05Ro12nRVyrTbeoc4I6M4uGKFvk3uV/OKsN52M04M6vQr4J9rgxmEd4t/wHlrvoxopuCBEh4cppLHQbbVgnwd2cfn2+RbtKAIuGDlUkF557KNebYWlXP7Rq/EO3rF7TA4uzmpIJSMCcSDmD89kFRPM7BxjRYbBNO3zrIr2hyCLbkzkT9sQwZmOZmQ9SL+W++CUY9gUHFj60fk/7FjFkY6uQ8gsRwL3Ororn8cDyzpb88RUFjs1hRgIBMh4rxrjEWbCZZOPtA5DVFHjZ461e3vlc0JKHn1NB7nGd5/rdzg4wlyGlcY8OzaLLICMtBqGDxWA6IbS7zRb1vTKAWIIL2KrwQbePytSKt6Fn4Wm7V346C7rZHPMAGO5+ydmN65PMecRBcBgQlUavsuISJKch8qR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199015)(31686004)(66476007)(66946007)(8676002)(4326008)(44832011)(41300700001)(66556008)(316002)(8936002)(2906002)(5660300002)(478600001)(36756003)(6486002)(186003)(6512007)(53546011)(54906003)(26005)(6916009)(6506007)(6666004)(2616005)(83380400001)(31696002)(38100700002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0pVNGtNYjVxbmdjNWE5K2NLaDAyeWxOREpyQStueGFmeE94VVRQUFpKcXRE?= =?utf-8?B?QlRpUktBbTJBV3o2RW03TVU4WEVWTjhIWnRmUmtISjZjNWtRUFNPVXJSQTRy?= =?utf-8?B?WTNmVUhkTDFEa3czU1FuZThvZ2trais2b1dCd05pSDY0OU80cEJNQWsrcTBi?= =?utf-8?B?R1pCY2J0Sy96YmJWbDk4cldIOFhxSEYwWEZ1amhiU092YWdPVGludDJ1RVRr?= =?utf-8?B?UE5UeTRuYUVvN2lqRCtJbDF4S2JvZE14dTI4eFEzTkdrZTNHcVdHYkkxTjhF?= =?utf-8?B?M0tDbzl2bHM0M2NhS2FaQUdnQXJ5MTRBTmpmaGdzSlUzTVo1cUUyNWFVWFhH?= =?utf-8?B?cHFNaE5nL2k1S0RLRjVSRVFBaWZ0eDVLbmVlNTZqZUlubjMxcEFkcnQva0hQ?= =?utf-8?B?N1MzSTkrbDkwNmdoM1R2WnJPS3NjckI2NENQNHljT1pSQUI1WUVkVHBsNkpS?= =?utf-8?B?TnRIT2ZudFJXalZ5VVFtSGZQbDRwREtnWFZhVU5FT3RGelAzRmJiZ2NGQnVB?= =?utf-8?B?QXpmWXpyQmxJNVJ4TE9SWmJVeUtBR1RtNnRUTnJPTVFXRHlMRDBYK0RFNHhS?= =?utf-8?B?SXZWLzlRaytvVjFiK1hnSWhxNzZoeWlmYWkxNVBKL1JYMTZSVFY3WkdQR1BE?= =?utf-8?B?M2JLRFdmTmJFL1QyWFpqQ1duaUw2MkYyOGVpUVBjR3BBTS8zRmhsMzN3K1l5?= =?utf-8?B?eG1VUW1OVW0xMGlPcFVya3VvNlc1OWNLQk9wd1BaellWWkRMdnNLcHpZeWFv?= =?utf-8?B?V0RRVzk1Rk4zdkNaL1RZOURDdjRVUUxaLzNvZEVSZmkwSkF4REdxOS9PSE9a?= =?utf-8?B?LzRRMEFvdlo5TlpsZW9YN1hPM0twRmxSaExyS2pWZkVsTTI1TVBRN1FrSThE?= =?utf-8?B?bDRPMWpmMHRFNS9odVAxRFZkbHFGdDBnY3lFNE0xNW9KNDMxWmxnQ2lpU1dL?= =?utf-8?B?cnd5ZnByMFluSk5NMEhPYzVkeHZaRHBPR205SWUxQmxVYjBoU1lEcWRyNmJh?= =?utf-8?B?S1lYT0s5YzB5T1M2bDVzLzF5clBaVkgyeUR6WlpyN0xtbHBoOUVIcVFLanRy?= =?utf-8?B?cU15VnF0dUVYTGhneDJwaG1yaGVuTkxkWXVUa2JETlBCVmpkM2dCVEV2YTQw?= =?utf-8?B?elk2aUdLUjJOTUZTWHZDR1BCRzY2aTJHYmo5V09oZmdhSEVuMHNZQ0svNFdL?= =?utf-8?B?K2R3VnVPRkNzODQ2RWEzYlFBOWxudnlpVWYxZzV6U3c0N0syelBYSE0zdHZG?= =?utf-8?B?WDltSXRKV2FvQm9SWnpldVJKV2x2cmxDbkpSbzluNW4wOE5PT1ZTeWNvZWxN?= =?utf-8?B?NjVSWjRqcm1yS0N5ZlRLQUJLVTlBbXNCSlgzSy9jRUtQTWFYVUZFaTJ0djFE?= =?utf-8?B?aVdQZFVvQ25qNVdCai9iOExjV0NVTUFmaHd0N0MwZ3haWThwaTdNQnhBUXFq?= =?utf-8?B?aGNaWm1jbEgyWXFYaTFwWmxqSks0TGNEaTFOZEtsZUN5QUNTaG1qc3JYN2h4?= =?utf-8?B?eWh2Wmx2SGJQNnltZTVjK3VWK2gwSy9jUTd3M2VzN1o4SWZXOTVqeHVybTRY?= =?utf-8?B?UzV5ZWJRSVA5Y0JaYk1RS1BDRTFseGV3U1pWYVUzYU8vRXBLTi9XZktwRzBy?= =?utf-8?B?OWJiMWtUN1dEc3hGby9XQTdzZzFZMWtLRkkybk9CclBKYVBOYUpTR252Z05i?= =?utf-8?B?VGJHZTEzZVlHTUNjL1dQTDgzR1FoOGtCaStQNk9abkdOS0J1QzBDaUdPVHZj?= =?utf-8?B?NURPek9QY1ZPLzBYdTVRbmNHRkhHbnFTUENOK1ErUGNhZjdONHlyUFcrTUlq?= =?utf-8?B?d0d2a295N082TEEweGt3dVBhTGM0azlrc1Uza21VdDRlMzh4aEE5dk5zK0pQ?= =?utf-8?B?QkRUdHNoeUhGLzdlM2FSMEdsNmRlVitSd2YyN2xnZmdIdE5nM1dvclVVeFlx?= =?utf-8?B?UzhreTNWZmNyMzUyaW1uMjhCQjlhd1pabFR5VHdoY1p1SHBKajZkSmozV2oy?= =?utf-8?B?QTV2SHNZdVdTWVo0dnRrS3NqOGlIZGlQYWdNbnNmMlphVVhqTnBQS05KKzVH?= =?utf-8?B?Nnd1aGFrV0xWWE5tdllJV0FQdHhXMlAwenRDUjhKSGs4QjlEQTArMFozbUho?= =?utf-8?Q?imv1mw9kEYDN6kZmtwNlX5u/Y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a70d5265-6f21-4825-8181-08dad9c191a1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 08:44:22.4355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zqq5jJ54uQreZJRXLfye8seCazPlk8+voukgW2I9Zl4/sOMyq0Ihh1hbZ6f2eY08 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6525 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/9/2022 8:22 AM, David Marchand wrote: > On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit wrote: >> >> By default 'test-meson-builds.sh' script clones the repository which the >> script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') >> as a reference for ABI check. >> >> This patch enables selecting different repository to close for reference >> using 'DPDK_ABI_REF_SRC' environment variable. >> >> It is possible to put these variables to 'devel.config' config file, or >> provide via command line, like: >> ` >> DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > > DPDK_ABI_REF_SRC could be passed as a remote repository. > This should remove the need for any "git remote" configuration. > > $ DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable > DPDK_ABI_REF_VERSION=v22.11.1 ./devtools/test-meson-builds.sh > +1 to 'DPDK_ABI_REF_SRC' accept either folder or remote git repo. Can you send a v2 with your sign off added, or do you want me send a v2? > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 406bf4e184..48f4e52df3 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -18,8 +18,8 @@ srcdir=$(dirname $(readlink -f $0))/.. > # > # - DPDK_MESON_OPTIONS > # > -# - DPDK_ABI_REF_SRC > # - DPDK_ABI_REF_DIR > +# - DPDK_ABI_REF_SRC > # - DPDK_ABI_REF_VERSION > # > # - DPDK_BUILD_TEST_EXAMPLES > @@ -186,10 +186,14 @@ build () # > [meson options] > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > if [ ! -d $abirefdir/$targetdir ]; then > - abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} > # clone current sources > if [ ! -d $abirefdir/src ]; then > - git clone --local --no-hardlinks \ > + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} > + abirefcloneopts= > + if [ -d $abirefsrc ]; then > + abirefcloneopts="--local --no-hardlinks" > + fi > + git clone $abirefcloneopts \ > --single-branch \ > -b $DPDK_ABI_REF_VERSION \ > $abirefsrc $abirefdir/src > > >> DPDK_ABI_REF_VERSION=v22.11.1 \ >> DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ >> ./devtools/test-meson-builds.sh >> ` >> >> When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did >> previously. >> >> Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that >> other repo as a new 'remote' to the exiting git repository. > > >