From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06C0EA00C5; Thu, 30 Apr 2020 18:24:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B44A51DC1A; Thu, 30 Apr 2020 18:24:10 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 70E871DC12 for ; Thu, 30 Apr 2020 18:24:09 +0200 (CEST) IronPort-SDR: Khg98GHqrxP8Wlcrl37AZFrLQEXIZ5mdmb4ELDlKy4qUToE5MuBQi0IHggVS6rBsP/xNw/6i+2 rwMLFCskTM4g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 09:24:08 -0700 IronPort-SDR: jKsYOwifoIfOdCvI6h5WtlmWrWqBL/8ehAvk2KyzW1fzawgk5HKsaZN8HWVYAXMrTQ0/B2U89/ dIKMEa5AJEJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,336,1583222400"; d="scan'208";a="337358673" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.249.32.101]) ([10.249.32.101]) by orsmga001.jf.intel.com with ESMTP; 30 Apr 2020 09:24:07 -0700 To: David Christensen , dev@dpdk.org References: <20200429232931.87233-1-drc@linux.vnet.ibm.com> <20200429232931.87233-2-drc@linux.vnet.ibm.com> <5c626659-7d00-c527-bb07-cdf29eaa5ce1@linux.vnet.ibm.com> From: "Burakov, Anatoly" Message-ID: <2e86c130-6c69-8525-b130-3d784a30b234@intel.com> Date: Thu, 30 Apr 2020 17:24:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5c626659-7d00-c527-bb07-cdf29eaa5ce1@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30-Apr-20 5:22 PM, David Christensen wrote: >>> Enclose ppc64 specific SPAPR VFIO support with ifdef's. >>> >>> Signed-off-by: David Christensen >>> --- >> >> Why is this needed? > > It's hardware specific to the PPC64 platform.  I don't know of a > situation where the IOMMU would be present on other hardware.  Even > running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 IOMMU > which isn't supported in DPDK. > > Dave Yes, but generally #ifdef's are there for detecting compile-time conditions. Is there anything specific to that code that would cause trouble when compiled on other platforms? -- Thanks, Anatoly