From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E25DFA0524; Tue, 13 Apr 2021 03:20:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 629B4160958; Tue, 13 Apr 2021 03:20:14 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id D5483160957 for ; Tue, 13 Apr 2021 03:20:12 +0200 (CEST) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FK74Z5vb4zPqdF; Tue, 13 Apr 2021 09:17:18 +0800 (CST) Received: from [127.0.0.1] (10.40.190.165) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Tue, 13 Apr 2021 09:20:04 +0800 To: David Marchand , "Min Hu (Connor)" , Shepard Siegel , "Qiming Yang" , Xiao Wang , Rosen Xu , Maxime Coquelin CC: dev , "Yigit, Ferruh" , "Mcnamara, John" , Ciara Power References: <1618051221-19962-1-git-send-email-humin29@huawei.com> From: fengchengwen Message-ID: <2e9be75e-ff17-756c-074f-9c87b4fc8bbb@huawei.com> Date: Tue, 13 Apr 2021 09:20:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 0/7] support set thread name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/4/12 15:19, David Marchand wrote: > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: >> >> This set of patches support set thread name for debugging. >> >> Chengwen Feng (7): >> net/ark: support set thread name >> net/ice: support set VSI reset thread name >> vdpa/ifc: support set notify and vring relay thread name >> raw/ifpga: support set monitor thread name >> examples/performance-thread: support set thread name >> telemetry: support set init threads name >> examples/vhost_blk: support set ctrl worker thread name > > Rather than add those calls, can maintainers check if their component > can use ctrl threads instead? > rte_ctrl_thread_create ensures both that the name is set, and that the > ctrl thread won't run on the same cpu as "datapath" threads. > > I also saw some issues with components creating threads. > I'll post a series addressing those later (net/ark, net/ice not > detaching/joining created threads + telemetry not checking > pthread_create failures). > > There already have reviewing patches: ([dpdk-dev] [PATCH v2 0/2] fix missing check for thread creation) to fix telemetry not checking pthread_create failure. Please review it, thanks