From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7423A052A; Tue, 2 Feb 2021 13:30:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EB4424029B; Tue, 2 Feb 2021 13:30:47 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7E8A9240295 for ; Tue, 2 Feb 2021 13:30:45 +0100 (CET) IronPort-SDR: MM1ZyQ9Y7iRkc/YwQnrmVaBtldJOxlddUtbG1zHILAPRrVJzfORISXX3PeP56dKtEP0MIzBnQQ cmxAMS2g+yuA== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180068378" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="180068378" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:30:43 -0800 IronPort-SDR: n17ZlXIUDx9kVoMbdEiG5w6QSk39P+C3Wy9Du2bqJY7446McFx8gqmk21h0/WmxvJ2tqwYvS2w dVZbpVXUtVrg== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391444238" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:30:42 -0800 To: Andrew Boyer , Thomas Monjalon Cc: dev , Alfredo Cardigliano References: <20210129224434.71536-1-aboyer@pensando.io> <4842644.BW4ZEuPtVA@thomas> From: Ferruh Yigit Message-ID: <2ea7be7f-1f7c-ff26-fc52-5372e58bad92@intel.com> Date: Tue, 2 Feb 2021 12:30:38 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net: redefine array size macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/1/2021 10:32 PM, Andrew Boyer wrote: > > >> On Feb 1, 2021, at 5:28 PM, Thomas Monjalon > > wrote: >> >> 29/01/2021 23:44, Andrew Boyer: >>> Replace copies of size(arr)/size(arr[0]) with RTE_DIM(). >>> Eventually all of these macro definitions should be removed. >>> >>> Signed-off-by: Andrew Boyer > >>> --- >>> drivers/net/atlantic/atl_hw_regs.h                | 2 +- >>> drivers/net/axgbe/axgbe_common.h                  | 2 +- >>> drivers/net/bnx2x/bnx2x.h                         | 2 +- >>> drivers/net/bnx2x/elink.h                         | 2 +- >>> drivers/net/ena/ena_ethdev.c                      | 2 +- >>> drivers/net/enic/base/vnic_devcmd.h               | 2 +- >>> drivers/net/hns3/hns3_ethdev.h                    | 2 +- >>> drivers/net/i40e/base/i40e_osdep.h                | 2 +- >>> drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +- >>> drivers/net/thunderx/base/nicvf_hw.h              | 2 +- >>> 10 files changed, 10 insertions(+), 10 deletions(-) >> >> Thanks for the cleanup. >> >> In the title, the prefix "net" means librte_net. >> Here, it should be "drivers/net". I know it's confusing :) >> >> Please check other patches in the series, >> they are versioned as v2 and numbered 4/13 and 6/13. > > Thank you for the review - do you want me to resend or can you fix it up yourself? > I can fix the title while merging, thanks for cleanup, Reviewed-by: Ferruh Yigit > The 4/13 and 6/13 are fixups that Ferruh asked for, while he applied the rest of > the series. I made the 4/13 a v2 replying to the original 4/13 and the 6/13 a v2 > replying to the original 6/13. If I messed it up, my apologies! > > -Andrew