From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D41A9A499 for ; Fri, 12 Jan 2018 13:25:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 04:25:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="18680390" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2018 04:25:00 -0800 To: Wei Zhao , dev@dpdk.org, Shahaf Shuler Cc: orika@mellanox.com References: <20171226094905.83277-1-wei.zhao1@intel.com> <20171227083215.112330-1-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: <2eba0d66-e5ec-2ae3-9cfb-6ed1479984c7@intel.com> Date: Fri, 12 Jan 2018 12:25:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20171227083215.112330-1-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 12:25:03 -0000 On 12/27/2017 8:32 AM, Wei Zhao wrote: > This example do not has the process of set up tx queues, but > some NIC start up process will be blocked if this is no tx queue > and only rx queues. So add tx queues setup process in main code. > > Signed-off-by: Wei Zhao <...> > @@ -149,7 +149,18 @@ init_port(void) > /**< CRC stripped by hardware */ > .hw_strip_crc = 1, > }, > + .txmode = { > + .offloads = > + DEV_TX_OFFLOAD_VLAN_INSERT | > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM | > + DEV_TX_OFFLOAD_SCTP_CKSUM | > + DEV_TX_OFFLOAD_TCP_TSO, > + }, > }; > + struct rte_eth_txconf txq_conf; > + struct rte_eth_dev_info dev_info; > > printf(":: initializing port: %d\n", port_id); > ret = rte_eth_dev_configure(port_id, > @@ -173,6 +184,21 @@ init_port(void) > } > } > > + rte_eth_dev_info_get(port_id, &dev_info); > + txq_conf = dev_info.default_txconf; > + txq_conf.offloads = port_conf.txmode.offloads; Hi Wei, Shahaf, When new offload method used for txmode, shouldn't ETH_TXQ_FLAGS_IGNORE set, otherwise txq_flags assumed to have valid values, no?