From: Remy Horton <remy.horton@intel.com>
To: Wan Junjie <wan.junjie@foxmail.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics
Date: Thu, 28 Feb 2019 13:55:03 +0000 [thread overview]
Message-ID: <2ed002f6-f1c6-9bca-d5d9-4b146627b736@intel.com> (raw)
In-Reply-To: <tencent_FF2D9BC79C8EABBAC2BEFD5770FC93356B07@qq.com>
On 28/02/2019 13:28, Wan Junjie wrote:
> Bitratestats test fails even without my patch. The reason is that
> metrics lib has no de-init process. Harman Kalra has submited a patch
> for this.
> Check https://patches.dpdk.org/patch/50451
Ah forgot about that patch. :S
> As for metrics lib, the array block of metadata may be better on cache
> side. Since rte_metrics_update_values is called periodicly in bitrate lib.
Quite possibly, at least for smallish datasets like bitrate.
>> Signed-off-by: Junjie Wan <wan.junjie@foxmail.com>
Acked-by: Remy Horton <remy.horton@intel.com>
next prev parent reply other threads:[~2019-02-28 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 6:16 [dpdk-dev] [PATCH] " =?gb18030?B?zfK/ob3c?=
2019-02-22 13:56 ` [dpdk-dev] [PATCH v2] " wanjunjie
2019-02-22 15:03 ` [dpdk-dev] [PATCH v3] " wanjunjie
2019-02-22 15:39 ` [dpdk-dev] [PATCH v4] " wanjunjie
2019-02-26 16:10 ` Remy Horton
2019-02-27 17:19 ` [dpdk-dev] [PATCH v5] " Junjie Wan
2019-02-28 11:53 ` Remy Horton
2019-02-28 13:28 ` Wan Junjie
2019-02-28 13:55 ` Remy Horton [this message]
2019-04-02 0:27 ` Thomas Monjalon
2019-04-02 0:27 ` Thomas Monjalon
2019-04-02 0:30 ` Thomas Monjalon
2019-04-02 0:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed002f6-f1c6-9bca-d5d9-4b146627b736@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=wan.junjie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).