From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CF6F337B4 for ; Thu, 28 Feb 2019 14:55:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2019 05:55:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,423,1544515200"; d="scan'208";a="303277584" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.178.163]) ([163.33.178.163]) by orsmga005.jf.intel.com with ESMTP; 28 Feb 2019 05:55:04 -0800 To: Wan Junjie References: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com> <1551287944-27314-1-git-send-email-wan.junjie@foxmail.com> Cc: dev From: Remy Horton Organization: Intel Shannon Limited Message-ID: <2ed002f6-f1c6-9bca-d5d9-4b146627b736@intel.com> Date: Thu, 28 Feb 2019 13:55:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 13:55:07 -0000 On 28/02/2019 13:28, Wan Junjie wrote: > Bitratestats test fails even without my patch. The reason is that > metrics lib has no de-init process. Harman Kalra has submited a patch > for this. > Check https://patches.dpdk.org/patch/50451 Ah forgot about that patch. :S > As for metrics lib, the array block of metadata may be better on cache > side. Since rte_metrics_update_values is called periodicly in bitrate lib. Quite possibly, at least for smallish datasets like bitrate. >> Signed-off-by: Junjie Wan Acked-by: Remy Horton