From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C493A0501; Sun, 8 May 2022 15:45:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 256CF4068F; Sun, 8 May 2022 15:45:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0D34F40395 for ; Sun, 8 May 2022 15:45:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652017504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ca/Lg3oxX6bu0iN6hmHOeG7gc0PAHbiZG0r1rW6m+SM=; b=dKfG1AjC7rdT3/7vay7QIivOaocp9mF6Lw4PjEouV9qoe0mKXaQm2Ex/d5EL0PxrTpjHFF LHmBLK2E2xajx+sJqZZvL02SEZ5jveADOca2hX9WDN09tay8xWjrG2p1dbrYfGbSP9YRbt ukMReCprnsH0WONtNPEs/52HuV/FQyE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-330XqLWyOEWr7bctrr-nWA-1; Sun, 08 May 2022 09:45:01 -0400 X-MC-Unique: 330XqLWyOEWr7bctrr-nWA-1 Received: by mail-qv1-f71.google.com with SMTP id e3-20020a056214110300b0045abb0e1760so9410234qvs.3 for ; Sun, 08 May 2022 06:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ca/Lg3oxX6bu0iN6hmHOeG7gc0PAHbiZG0r1rW6m+SM=; b=qnnYZXY1jUQerki6xgpR7EEYdc90Zb8E0O1A0L1EP1HtH8FdmsNyc8UdCdM880wKN1 V+8Hn9DIW6iyfeeKZoG94iMhHOfJkNgC7OWYrWa9wgj/AILHGbU636xSG+d+GC82zpIS qCTdFeGq2yg7YmDE+Y9hkUoW5JsRQ+HJuN2QU34GfMOVMMmosHJGEEl/djv8xCZNtzN7 +B20eVb3bUIqW4S3M0MBJswF/cx//f3pHQ/ihFz0uwae3wD/QzgxxaQOw1ldXUa3RcCF 56D2tKD5Omsr/cLx1q6Sc2wX7xsB+UEIraCEJK5j8bIGMDHGdyWrhEn/OgOVLozxrDRN 4NWQ== X-Gm-Message-State: AOAM530UJg+ExYVPSANAX/oAX/v9ivxtofle+2vQB14MAZB3yCqoa6aH QpAvKFX13E0AgKwHBmDCg2V4Ez7VBn1KwYStJbQ2SY0MXWIHldZomlBgMus15sRVYL8Z8IYMUs6 joSU= X-Received: by 2002:a05:6214:5094:b0:45a:b985:5a78 with SMTP id kk20-20020a056214509400b0045ab9855a78mr9766236qvb.54.1652017500965; Sun, 08 May 2022 06:45:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPcWP98ls9hjBXieMosJ5v+eTluEKVuum59N9DcIoZqtaSxa6qNnkfetsAixeCJc1kFbz8vg== X-Received: by 2002:a05:6214:5094:b0:45a:b985:5a78 with SMTP id kk20-20020a056214509400b0045ab9855a78mr9766224qvb.54.1652017500807; Sun, 08 May 2022 06:45:00 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id s5-20020a37a905000000b0069fc13ce216sm5439195qke.71.2022.05.08.06.44.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 06:44:59 -0700 (PDT) Subject: Re: [PATCH v2 4/5] baseband/acc100: start explicitly PF Monitor from PMD To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, david.marchand@redhat.com References: <1651083423-33202-1-git-send-email-nicolas.chautru@intel.com> <1651083423-33202-5-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <2edd7798-1a60-dc53-9a71-db2f88dc9b25@redhat.com> Date: Sun, 8 May 2022 06:44:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1651083423-33202-5-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/27/22 11:17 AM, Nicolas Chautru wrote: > Ensure the performance monitor is restarted in case this > is reset after VF FLR. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++++ > drivers/baseband/acc100/rte_acc100_pmd.h | 6 ++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index b03cedc..b588f5f 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -263,6 +263,10 @@ > & 0xF; > } > > + /* Start Pmon */ > + acc100_reg_write(d, reg_addr->pmon_ctrl_a, 0x2); > + acc100_reg_write(d, reg_addr->pmon_ctrl_b, 0x2); This looks like an acc100 bug fix, so it should be split from the acc101 pathset. Where this code is added is fetch_acc100_config, a function that does reads. Though convenient, this is likely not the best place to put the writes Tom > + > /* Read PF mode */ > if (d->pf_device) { > reg_mode = acc100_reg_read(d, HWPfHiPfMode); > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h b/drivers/baseband/acc100/rte_acc100_pmd.h > index 6438031..f126cc0 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.h > +++ b/drivers/baseband/acc100/rte_acc100_pmd.h > @@ -475,6 +475,8 @@ struct acc100_registry_addr { > unsigned int depth_log1_offset; > unsigned int qman_group_func; > unsigned int ddr_range; > + unsigned int pmon_ctrl_a; > + unsigned int pmon_ctrl_b; > }; > > /* Structure holding registry addresses for PF */ > @@ -504,6 +506,8 @@ struct acc100_registry_addr { > .depth_log1_offset = HWPfQmgrGrpDepthLog21Vf, > .qman_group_func = HWPfQmgrGrpFunction0, > .ddr_range = HWPfDmaVfDdrBaseRw, > + .pmon_ctrl_a = HWPfPermonACntrlRegVf, > + .pmon_ctrl_b = HWPfPermonBCntrlRegVf, > }; > > /* Structure holding registry addresses for VF */ > @@ -533,6 +537,8 @@ struct acc100_registry_addr { > .depth_log1_offset = HWVfQmgrGrpDepthLog21Vf, > .qman_group_func = HWVfQmgrGrpFunction0Vf, > .ddr_range = HWVfDmaDdrBaseRangeRoVf, > + .pmon_ctrl_a = HWVfPmACntrlRegVf, > + .pmon_ctrl_b = HWVfPmBCntrlRegVf, > }; > > /* Structure associated with each queue. */