From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 755F46CBB for ; Tue, 11 Oct 2016 11:22:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 11 Oct 2016 02:22:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,476,1473145200"; d="scan'208";a="771236143" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.94]) ([10.237.220.94]) by FMSMGA003.fm.intel.com with ESMTP; 11 Oct 2016 02:22:18 -0700 To: John Daley , bruce.richardson@intel.com References: <20160929205639.1175-1-johndale@cisco.com> <20160929205639.1175-4-johndale@cisco.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <2f02ca98-8250-0c27-7ae4-5e23839521d6@intel.com> Date: Tue, 11 Oct 2016 10:22:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20160929205639.1175-4-johndale@cisco.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 09:22:37 -0000 Hi John, On 9/29/2016 9:56 PM, John Daley wrote: > 1300 series Cisco adapter firmware version 2.0(13) for UCS > C-series servers and 3.1(2) for blade servers supports more > filtering capabilities. The feature can be enabled via Cisco > CIMC or USCM with the 'advanced filters' radio button. When > enabled, the these additional flow director modes are available: > RTE_ETH_FLOW_NONFRAG_IPV4_OTHER > RTE_ETH_FLOW_NONFRAG_IPV4_SCTP > RTE_ETH_FLOW_NONFRAG_IPV6_UDP > RTE_ETH_FLOW_NONFRAG_IPV6_TCP > RTE_ETH_FLOW_NONFRAG_IPV6_SCTP > RTE_ETH_FLOW_NONFRAG_IPV6_OTHER > > Changes: > - Detect and set an 'advanced filters' flag dependent on the adapter > capability. > - Implement RTE_ETH_FILTER_INFO filter op to return the flow types > available dependent on whether advanced filters are enabled. > - Use a function pointer to select how filters are added to the adapter: > copy_fltr_v1() for older firmware/adapters or copy_fltr_v2() for > adapters which support advanced filters. > - Apply fdir global masks to filters when in advanced filter mode. > - Update documentation. > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar > --- <...> > > +void enic_fdir_info_get(struct enic *enic, struct rte_eth_fdir_info *info) > +{ > + info->mode = enic->fdir.modes; This cause a icc build error: .../drivers/net/enic/enic_clsf.c(77): error #188: enumerated type mixed with another type info->mode = enic->fdir.modes; ^ Just casting to the enum fixes it: + info->mode = (enum rte_fdir_mode)enic->fdir.modes; Since the modification is trivial, if you agree with the change, we can apply it without needing a new version of the patch? <...>