From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 49E43A052A;
	Tue,  2 Feb 2021 18:48:27 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0B8DB240379;
	Tue,  2 Feb 2021 18:48:27 +0100 (CET)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id 2CC82240373
 for <dev@dpdk.org>; Tue,  2 Feb 2021 18:48:24 +0100 (CET)
IronPort-SDR: 9J3wldpku+GSwIhQIPlAgcQoYU/0dDEdeTXEIlIPQqBqA3JphRi0tL3DoF7NsZBnvzLbmySuyB
 jVSikV5OfYSQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="242412274"
X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="242412274"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 09:48:23 -0800
IronPort-SDR: ghXxPuWlKWGBzXvQq6p27rqzgtdslf+mGpezCrhXdvZKlWdXyU7ULeN9CU5jh/UQzWkzMLp1xh
 2U8cQKoigbhg==
X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391595401"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112])
 ([10.213.226.112])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 09:48:22 -0800
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20210122094800.197748-1-jiawenwu@trustnetic.com>
 <20210122094800.197748-2-jiawenwu@trustnetic.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <2f0836dc-4eac-94cb-b79d-9758ab4104a5@intel.com>
Date: Tue, 2 Feb 2021 17:48:18 +0000
MIME-Version: 1.0
In-Reply-To: <20210122094800.197748-2-jiawenwu@trustnetic.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v1 01/20] net/txgbe: add ethdev probe and
 remove for VF device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/22/2021 9:47 AM, Jiawen Wu wrote:
> Introduce virtual function driver in txgbe PMD,
> add simple init and uninit function to probe and remove the device.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

<...>

> @@ -0,0 +1,12 @@
> +;
> +; Supported features of the 'txgbe_vf' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Multiprocess aware   = Y
> +Linux UIO            = Y
> +Linux VFIO           = Y

The OS name changed, can you please rebase this on top of latest repo?

<...>

> @@ -0,0 +1,137 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2020
> + */
> +
> +#include <sys/queue.h>
> +#include <stdio.h>
> +#include <errno.h>
> +#include <stdint.h>
> +#include <string.h>
> +#include <rte_log.h>
> +#include <rte_ethdev_pci.h>

This header file is renamed, it is 'ethdev_pci.h' now, can you please rebase?

> +
> +#include "txgbe_logs.h"
> +#include "base/txgbe.h"
> +#include "txgbe_ethdev.h"
> +#include "txgbe_rxtx.h"

Can you pleae remove unsued headers and add them as they needed?

> +
> +#define TXGBEVF_PMD_NAME "rte_txgbevf_pmd" /* PMD name */

Is this macro used? And not sure if the comment is useful for this case.

<...>

> +
> +/* Virtual Function device uninit */
> +

Can you please remove the empty line, and other comments are in different 
format, better to align them.