From: oulijun <oulijun@huawei.com>
To: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx
Date: Tue, 27 Oct 2020 14:54:16 +0800 [thread overview]
Message-ID: <2f0dc579-ed54-3227-e414-e506d41d1f3f@huawei.com> (raw)
In-Reply-To: <CAJFAV8xmJ0GSf2CKMeqgcd+Kxmfg9aKNHfmqisX4sDE=-LDmgg@mail.gmail.com>
在 2020/10/26 0:18, David Marchand 写道:
> Hello Wei Hu,
>
>> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build
>> index bf69ad4..ca0f21a 100644
>> --- a/drivers/net/hns3/meson.build
>> +++ b/drivers/net/hns3/meson.build
>> @@ -31,4 +31,9 @@ deps += ['hash']
>>
>> if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
>> sources += files('hns3_rxtx_vec.c')
>> + if (dpdk_conf.has('RTE_MACHINE_CPUFLAG_SVE'))
>> + dpdk_conf.set('RTE_LIBRTE_HNS3_INC_VECTOR_SVE', 1)
>> + cflags = ['-DCC_SVE_SUPPORT']
>> + sources += files('hns3_rxtx_vec_sve.c')
>> + endif
>> endif
>
> This patch is already merged in main, but RTE_MACHINE_CPUFLAG_* have
> been removed, see https://git.dpdk.org/dpdk/commit/?id=84fb33fec1
> I guess SVE support is not working because of this.
>
> Please use compiler flags to check for support.
> If you need an example on how to do this, you can probably look at
> what has been done for Intel vector stuff.
>
> Besides, RTE_LIBRTE_HNS3_INC_VECTOR_SVE is not used anywhere and can be removed.
>
Hi,David Marchand
I have checked. I will send a fix patch for enabling.
Thanks
Lijun Ou
>
next prev parent reply other threads:[~2020-10-27 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:01 [dpdk-dev] [PATCH 0/2] net/hns3: support SVE Tx/Rx Wei Hu (Xavier)
2020-10-14 10:01 ` [dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx Wei Hu (Xavier)
2020-10-25 16:18 ` David Marchand
2020-10-27 3:36 ` oulijun
2020-10-27 6:54 ` oulijun [this message]
2020-10-14 10:01 ` [dpdk-dev] [PATCH 2/2] net/hns3: support SVE Tx Wei Hu (Xavier)
2020-10-14 23:35 ` [dpdk-dev] [PATCH 0/2] net/hns3: support SVE Tx/Rx Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0dc579-ed54-3227-e414-e506d41d1f3f@huawei.com \
--to=oulijun@huawei.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).