From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 55D2F5B40
 for <dev@dpdk.org>; Wed,  3 Oct 2018 20:49:16 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 03 Oct 2018 11:49:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="79619934"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49])
 ([10.237.221.49])
 by orsmga006.jf.intel.com with ESMTP; 03 Oct 2018 11:49:13 -0700
To: Igor Russkikh <igor.russkikh@aquantia.com>, dev@dpdk.org
Cc: pavel.belous@aquantia.com
References: <cover.1538215990.git.igor.russkikh@aquantia.com>
 <8d4e55d6fb6db2567e37c850cbae0e82f079a02d.1538215990.git.igor.russkikh@aquantia.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Openpgp: preference=signencrypt
Message-ID: <2f38c3d4-d6c4-3152-589e-07127d2a710b@intel.com>
Date: Wed, 3 Oct 2018 19:49:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <8d4e55d6fb6db2567e37c850cbae0e82f079a02d.1538215990.git.igor.russkikh@aquantia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 02/22] net/atlantic: logging macroes and
 some typedefs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 18:49:16 -0000

On 9/29/2018 11:30 AM, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>

<...>

> @@ -0,0 +1,31 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Aquantia Corporation
> + */
> +#ifndef ATL_LOGS_H
> +#define ATL_LOGS_H
> +
> +#include <rte_log.h>
> +
> +extern int atl_logtype_init;
> +
> +#define PMD_INIT_LOG(level, fmt, args...) \
> +	rte_log(RTE_LOG_ ## level, atl_logtype_init, \
> +		"%s(): " fmt "\n", __func__, ##args)

You didn't initialize the "atl_logtype_init" at this stage yet.

<...>

> @@ -0,0 +1,31 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Aquantia Corporation
> + */
> +#ifndef ATL_TYPES_H
> +#define ATL_TYPES_H
> +
> +#include <stdint.h>
> +#include <stddef.h>
> +#include <inttypes.h>
> +#include <string.h>
> +
> +typedef uint8_t		u8;
> +typedef int8_t		s8;
> +typedef uint16_t	u16;
> +typedef int16_t		s16;
> +typedef uint32_t	u32;
> +typedef int32_t		s32;
> +typedef uint64_t	u64;
> +#ifndef __cplusplus
> +typedef int		bool;
> +#endif

There is already a patch trying to remove these kind of usage, and replace with
"#include <stdbool.h>", is it possible to do same?

https://patches.dpdk.org/patch/44988/