From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 624C0A04AF; Wed, 19 Aug 2020 10:59:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 729B21BE7D; Wed, 19 Aug 2020 10:59:00 +0200 (CEST) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by dpdk.org (Postfix) with ESMTP id AE1BD2BE2; Tue, 18 Aug 2020 22:46:31 +0200 (CEST) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07IKgvNJ147041; Tue, 18 Aug 2020 20:46:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=owmeEurf5QTw+rteEqAA8pRU7U9SFYLkM8wHeEuV6gI=; b=MXBOBM9Dj89wY8ayqak6hHx0uggAP9LTLxH8A67gNnl8+1Q67PTDFjODSJPqxloBnsLX PpSE9n/KYqHhUsD31WhGIzJzaD7A+4OWMrkAxCfa2OGebQKwEuobMic4MxBYnlrTc3uj tSLg+iqFq4f/eKhgTIPx57ya/5KnO/HkqCblyVR3wpI9xjuMKv7ohCGeF2D2S00bRfAy uS5/qYqv0tVprLBzdOBTHBony6l42rMRJbZJ2hoCbMorA0MocP87mw22V4fpUrQ7m4qf uHng7w1Q9E/SledFqEF7pS1oa9kKyduotBj+V4E8C5JAvIfcVfxE/DLKyxPzCAJSmTAV +Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 32x8bn751c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 Aug 2020 20:46:30 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07IKcwBW135135; Tue, 18 Aug 2020 20:46:30 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 32xsmxq29g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Aug 2020 20:46:29 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07IKkSLb030646; Tue, 18 Aug 2020 20:46:28 GMT MIME-Version: 1.0 Message-ID: <2f41beb4-36bc-4607-89f2-89ec8e4a7ae3@default> Date: Tue, 18 Aug 2020 13:46:25 -0700 (PDT) From: Vipul Ashri To: Ferruh Yigit , "Xia, Chenbo" , dev@dpdk.org, stable@dpdk.org, "Wang, Zhihong" , maxime.coquelin@redhat.com References: <20200807125731.1287-1-vipul.ashri@oracle.com> <20200813162222.1635-1-vipul.ashri@oracle.com> <883a01b6-46f6-0575-61eb-c838ac271b30@intel.com> In-Reply-To: <883a01b6-46f6-0575-61eb-c838ac271b30@intel.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 15.0.5257.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9717 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008180145 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9717 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008180145 X-Mailman-Approved-At: Wed, 19 Aug 2020 10:58:59 +0200 Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All This patch needs to get reviewed by all available reviewers as link came vi= sible now. @Xia Chenbo, As you have already reviewed so here I request you to share yo= ur review vote again and Ack if possible. @Ferruh, Below link is correct patch, I appreciate and thank you very much = for your help. Patch Link: https://urldefense.com/v3/__https://patches.dpdk.org/project/dpdk/list/?sub= mitter=3D1867__;!!GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQ= alUpEoAp3u4diGxyy98kmw$ Regards Vipul -----Original Message----- From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]=20 Sent: Wednesday, 19 August, 2020 0:15 To: Vipul Ashri ; Xia, Chenbo ; dev@dpdk.org; stable@dpdk.org; Wang, Zhihong ; m= axime.coquelin@redhat.com Cc: Edwin Leung Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignmen= t in helper macro On 8/14/2020 6:23 AM, Vipul Ashri wrote: > Hi All >=20 > I tried twice uploading this same patch but it is still not listed under = https://urldefense.com/v3/__http://patches.dpdk.org/project/dpdk/list/__;!!= GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQalUpEoAp3u4diGy8g7= AhJA$ . > Please let me know if I am missing something and required to do some addi= tional steps to submit my patch. Mail list is moderated, only subscribed members can post. Your patches were hold in the administration queue because of that, I have = released them and cleaned up the patchwork (since there were double of some versions) and only left one copy of v3, please check if that is the correct= one: https://urldefense.com/v3/__https://patches.dpdk.org/project/dpdk/list/?sub= mitter=3D1867__;!!GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQ= alUpEoAp3u4diGxyy98kmw$=20 >=20 > Thanks to Xia for reviewing this code! >=20 > Regards > Vipul >=20 > -----Original Message----- > From: Xia, Chenbo [mailto:chenbo.xia@intel.com] > Sent: Friday, 14 August, 2020 6:56 > To: Vipul Ashri ; dev@dpdk.org > Cc: Edwin Leung ; stable@dpdk.org; Wang,=20 > Zhihong ; maxime.coquelin@redhat.com > Subject: RE: [PATCH v3] net/virtio: fix wrong variable assignment in=20 > helper macro >=20 >=20 >> -----Original Message----- >> From: Vipul Ashri >> Sent: Friday, August 14, 2020 12:22 AM >> To: dev@dpdk.org >> Cc: Xia, Chenbo ; vipul.ashri@oracle.com;=20 >> edwin.leung@oracle.com; stable@dpdk.org; Wang, Zhihong=20 >> ; maxime.coquelin@redhat.com >> Subject: [PATCH v3] net/virtio: fix wrong variable assignment in=20 >> helper macro >> >> Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is=20 >> always failing as assignment done using var_ having local scope only. >> This leads to TX packets not going out and found broken due to=20 >> cleanup malfunctioning. This patch fixes the wrong variable assignment. >> >> Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions") >> Cc: stable@dpdk.org >> >> Signed-off-by: Vipul Ashri >> --- >> drivers/net/virtio/virtqueue.h | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/virtio/virtqueue.h=20 >> b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 >> --- a/drivers/net/virtio/virtqueue.h >> +++ b/drivers/net/virtio/virtqueue.h >> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) >> >> /* avoid write operation when necessary, to lessen cache issues */ >> #define ASSIGN_UNLESS_EQUAL(var, val) do {=09\ >> -=09typeof(var) var_ =3D (var);=09=09\ >> -=09typeof(val) val_ =3D (val);=09=09\ >> -=09if ((var_) !=3D (val_))=09=09=09\ >> -=09=09(var_) =3D (val_);=09=09\ >> +=09if ((var) !=3D (val))=09=09=09\ >> +=09=09(var) =3D (val);=09=09=09\ >> } while (0) >> >> #define virtqueue_clear_net_hdr(hdr) do {=09=09\ >> -- >> 2.28.0.windows.1 >=20 > Reviewed-by: Chenbo Xia >=20