From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D748F2C18 for ; Fri, 28 Apr 2017 07:23:51 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 22:23:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="79920062" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.172.161]) ([10.252.172.161]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2017 22:23:48 -0700 To: "Dai, Wei" , Laurent Hardy , "dev@dpdk.org" Cc: "Zhang, Helin" , "Ananyev, Konstantin" , "olivier.matz@6wind.com" References: <49759EB36A64CF4892C1AFEC9231E8D650A662DC@PGSMSX101.gar.corp.intel.com> <1493305422-10611-1-git-send-email-laurent.hardy@6wind.com> <49759EB36A64CF4892C1AFEC9231E8D650A77CCA@PGSMSX106.gar.corp.intel.com> From: Ferruh Yigit Message-ID: <2f543713-9670-d0d7-49c8-4b0aa2d0fd7c@intel.com> Date: Fri, 28 Apr 2017 06:23:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A77CCA@PGSMSX106.gar.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 05:23:53 -0000 On 4/28/2017 1:43 AM, Dai, Wei wrote: >> -----Original Message----- >> From: Laurent Hardy [mailto:laurent.hardy@6wind.com] >> Sent: Thursday, April 27, 2017 11:04 PM >> To: dev@dpdk.org; Dai, Wei >> Cc: Yigit, Ferruh ; Zhang, Helin >> ; Ananyev, Konstantin >> ; olivier.matz@6wind.com >> Subject: [PATCH v4] net/ixgbe: ensure link status is updated >> >> In case of fiber and link speed set to 1Gb at peer side (with autoneg >> or with defined speed), link status could be not properly updated at >> time cable is plugged-in. >> Indeed if cable was not plugged when device has been configured and >> started then link status will not be updated properly with new speed >> as no link setup will be triggered. >> >> To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a link >> setup each time link_update() is triggered and current link status is >> down. When cable is plugged-in, link setup will be performed via >> ixgbe_setup_link(). >> >> Signed-off-by: Laurent Hardy > Acked-by: Wei Dai Applied to dpdk-next-net/master, thanks.