From: "Ariel Otilibili-Anieli" <Ariel.Otilibili-Anieli@eurecom.fr>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: dev@dpdk.org, stable@dpdk.org, "Andrew Boyer" <andrew.boyer@amd.com>
Subject: Re: [PATCH v3 01/10] devtools/cocci, lib/eal: remove unused rte_bitmap_free()
Date: Mon, 23 Dec 2024 11:31:27 +0100 [thread overview]
Message-ID: <2f7a84-67693c00-4d97-4ac1e700@151223839> (raw)
In-Reply-To: <20241222084316.1b2b7eb9@hermes.local>
On Sunday, December 22, 2024 17:43 CET, Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Sun, 22 Dec 2024 02:19:53 +0100
> Ariel Otilibili <otilibil@eurecom.fr> wrote:
>
> > Coverity reports return values of calls to rte_bitmap_free() are not used.
>
> Some existing user code may actually be using this so this would be an API change.
> Therefore this patch can not be accepted for current releases.
Thanks for the feedback, Stephen; I didn't know this API was exposed.
>
> It is worth addressing this in future but:
> - need to go through deprecation process
> - function to be void
> - it should be possible to implement a real free function
> just was never done.
I'll get back with a new series sometime next year. Thanks as well for the hints.
next prev parent reply other threads:[~2024-12-23 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 1:19 [PATCH v3 00/10] devtools, lib, test, net, common: " Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 01/10] devtools/cocci, lib/eal: " Ariel Otilibili
2024-12-22 16:43 ` Stephen Hemminger
2024-12-23 10:31 ` Ariel Otilibili-Anieli [this message]
2024-12-22 1:19 ` [PATCH v3 02/10] app/test: remove unsued rte_bitmap_free() Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 03/10] net/sfc: remove unused rte_bitmap_free() Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 04/10] crypto/ionic: " Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 05/10] net/cxgbe: " Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 06/10] net/mlx4: " Ariel Otilibili
2024-12-22 1:19 ` [PATCH v3 07/10] common/mlx5: " Ariel Otilibili
2024-12-22 1:20 ` [PATCH v3 08/10] net/bonding: " Ariel Otilibili
2024-12-22 1:20 ` [PATCH v3 09/10] net/netvsc: " Ariel Otilibili
2024-12-22 1:20 ` [PATCH v3 10/10] common/cnxk: " Ariel Otilibili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7a84-67693c00-4d97-4ac1e700@151223839 \
--to=ariel.otilibili-anieli@eurecom.fr \
--cc=andrew.boyer@amd.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).