* [PATCH 0/1] buildtools: clear out regex syntax warnings
@ 2024-12-08 2:25 Ariel Otilibili
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Ariel Otilibili @ 2024-12-08 2:25 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, David Marchand, Ariel Otilibili
Hello,
This is my first patch to the list; your feedback is much appreciated.
My aim is to understand the internals of DPDK.
While compiling from scratch, I came across these Python warnings.
Thank you,
Ariel Otilibili (1):
buildtools: clear out regex syntax warnings
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.47.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] buildtools: clear out regex syntax warnings
2024-12-08 2:25 [PATCH 0/1] buildtools: clear out regex syntax warnings Ariel Otilibili
@ 2024-12-08 2:25 ` Ariel Otilibili
2024-12-13 14:07 ` Robin Jarry
2024-12-13 13:10 ` [PING] " Ariel Otilibili-Anieli
2024-12-13 14:40 ` [PATCH v2 0/1] " Ariel Otilibili
2 siblings, 1 reply; 9+ messages in thread
From: Ariel Otilibili @ 2024-12-08 2:25 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, David Marchand, Ariel Otilibili
* invalid escape sequences now generate SyntaxWarning
* therefore changed syntax to raw string noration.
Link: https://docs.python.org/3/library/re.html#module-re
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
index c61f6a273f..fd22d25f36 100644
--- a/buildtools/get-test-suites.py
+++ b/buildtools/get-test-suites.py
@@ -6,10 +6,10 @@
import re
input_list = sys.argv[1:]
-test_def_regex = re.compile("REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
+test_def_regex = re.compile(r"REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
test_suites = {}
# track tests not in any test suite.
-non_suite_regex = re.compile("REGISTER_TEST_COMMAND\s*\(\s*([a-z0-9_]+)")
+non_suite_regex = re.compile(r"REGISTER_TEST_COMMAND\s*\(\s*([a-z0-9_]+)")
non_suite_tests = []
def get_fast_test_params(test_name, ln):
--
2.47.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PING] buildtools: clear out regex syntax warnings
2024-12-08 2:25 [PATCH 0/1] buildtools: clear out regex syntax warnings Ariel Otilibili
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
@ 2024-12-13 13:10 ` Ariel Otilibili-Anieli
2024-12-13 14:40 ` [PATCH v2 0/1] " Ariel Otilibili
2 siblings, 0 replies; 9+ messages in thread
From: Ariel Otilibili-Anieli @ 2024-12-13 13:10 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, David Marchand
Hello,
Any news on the patch? If anything is needed for its review, I am available.
Regards,
On Sunday, December 08, 2024 03:25 CET, Ariel Otilibili <Ariel.Otilibili-Anieli@eurecom.fr> wrote:
> Hello,
>
> This is my first patch to the list; your feedback is much appreciated.
>
> My aim is to understand the internals of DPDK.
>
> While compiling from scratch, I came across these Python warnings.
>
> Thank you,
>
> Ariel Otilibili (1):
> buildtools: clear out regex syntax warnings
>
> buildtools/get-test-suites.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] buildtools: clear out regex syntax warnings
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
@ 2024-12-13 14:07 ` Robin Jarry
2024-12-13 14:11 ` Ariel Otilibili-Anieli
0 siblings, 1 reply; 9+ messages in thread
From: Robin Jarry @ 2024-12-13 14:07 UTC (permalink / raw)
To: Ariel Otilibili, dev; +Cc: Thomas Monjalon, David Marchand
Ariel Otilibili, Dec 08, 2024 at 03:25:
> * invalid escape sequences now generate SyntaxWarning
> * therefore changed syntax to raw string noration.
>
> Link: https://docs.python.org/3/library/re.html#module-re
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Hi Ariel, thanks for the fix!
Acked-by: Robin Jarry <rjarry@redhat.com>
If you have time, I there are other bits that would need the same fix:
buildtools/get-numa-count.py:14: numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
devtools/check-meson.py:54: if re.match('^ *\t', code):
doc/api/generate_doxygen.py:8:pattern = re.compile('^Preprocessing (.*)...$')
Cheers.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] buildtools: clear out regex syntax warnings
2024-12-13 14:07 ` Robin Jarry
@ 2024-12-13 14:11 ` Ariel Otilibili-Anieli
2024-12-13 14:15 ` David Marchand
0 siblings, 1 reply; 9+ messages in thread
From: Ariel Otilibili-Anieli @ 2024-12-13 14:11 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev, Thomas Monjalon, David Marchand
On Friday, December 13, 2024 15:07 CET, "Robin Jarry" <rjarry@redhat.com> wrote:
> Ariel Otilibili, Dec 08, 2024 at 03:25:
> > * invalid escape sequences now generate SyntaxWarning
> > * therefore changed syntax to raw string noration.
> >
> > Link: https://docs.python.org/3/library/re.html#module-re
> > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
>
> Hi Ariel, thanks for the fix!
>
> Acked-by: Robin Jarry <rjarry@redhat.com>
Awesome, Robin!
>
> If you have time, I there are other bits that would need the same fix:
>
> buildtools/get-numa-count.py:14: numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
> devtools/check-meson.py:54: if re.match('^ *\t', code):
> doc/api/generate_doxygen.py:8:pattern = re.compile('^Preprocessing (.*)...$')
>
Good, then; I'll push them in a subsequent series.
> Cheers.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] buildtools: clear out regex syntax warnings
2024-12-13 14:11 ` Ariel Otilibili-Anieli
@ 2024-12-13 14:15 ` David Marchand
0 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2024-12-13 14:15 UTC (permalink / raw)
To: Ariel Otilibili-Anieli; +Cc: Robin Jarry, dev, Thomas Monjalon
On Fri, Dec 13, 2024 at 3:11 PM Ariel Otilibili-Anieli
<otilibil@eurecom.fr> wrote:
>
> On Friday, December 13, 2024 15:07 CET, "Robin Jarry" <rjarry@redhat.com> wrote:
>
> > Ariel Otilibili, Dec 08, 2024 at 03:25:
> > > * invalid escape sequences now generate SyntaxWarning
> > > * therefore changed syntax to raw string noration.
> > >
> > > Link: https://docs.python.org/3/library/re.html#module-re
> > > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> >
> > Hi Ariel, thanks for the fix!
> >
> > Acked-by: Robin Jarry <rjarry@redhat.com>
>
> Awesome, Robin!
> >
> > If you have time, I there are other bits that would need the same fix:
> >
> > buildtools/get-numa-count.py:14: numa_nodes.sort(key=lambda l: int(re.findall('\d+', l)[0]))
> > devtools/check-meson.py:54: if re.match('^ *\t', code):
> > doc/api/generate_doxygen.py:8:pattern = re.compile('^Preprocessing (.*)...$')
> >
>
> Good, then; I'll push them in a subsequent series.
Those fixes are little one-liners worth backporting.
Please add a Fixes: tag identifying the commit introducing the issue,
then Cc: stable@dpdk.org.
If you need more details on what is expected, see
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
and https://doc.dpdk.org/guides/contributing/patches.html#patch-for-stable-releases
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 0/1] buildtools: clear out regex syntax warnings
2024-12-08 2:25 [PATCH 0/1] buildtools: clear out regex syntax warnings Ariel Otilibili
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
2024-12-13 13:10 ` [PING] " Ariel Otilibili-Anieli
@ 2024-12-13 14:40 ` Ariel Otilibili
2024-12-13 14:40 ` [PATCH v2 1/1] " Ariel Otilibili
2 siblings, 1 reply; 9+ messages in thread
From: Ariel Otilibili @ 2024-12-13 14:40 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, David Marchand, Robin Jarry, Ariel Otilibili
Hello,
This is my first patch to the list; your feedback is much appreciated.
My aim is to understand the internals of DPDK.
While compiling from scratch, I came across these Python warnings.
Thank you,
Ariel Otilibili (1):
buildtools: clear out regex syntax warnings
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
v2:
* redone commit message
* backport to stable
2.47.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] buildtools: clear out regex syntax warnings
2024-12-13 14:40 ` [PATCH v2 0/1] " Ariel Otilibili
@ 2024-12-13 14:40 ` Ariel Otilibili
2024-12-13 16:41 ` Robin Jarry
0 siblings, 1 reply; 9+ messages in thread
From: Ariel Otilibili @ 2024-12-13 14:40 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, David Marchand, Robin Jarry, Ariel Otilibili, stable
* invalid escape sequences now generate SyntaxWarning
* therefore changed syntax to raw string noration.
Link: https://docs.python.org/3/library/re.html#module-re
Fixes: 0aeaf75df87 ("test: define unit tests suites based on test types")
Fixes: 25065ef1f6c ("test: emit warning for orphaned tests")
Cc: stable@dpdk.org
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
buildtools/get-test-suites.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
index c61f6a273f..fd22d25f36 100644
--- a/buildtools/get-test-suites.py
+++ b/buildtools/get-test-suites.py
@@ -6,10 +6,10 @@
import re
input_list = sys.argv[1:]
-test_def_regex = re.compile("REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
+test_def_regex = re.compile(r"REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
test_suites = {}
# track tests not in any test suite.
-non_suite_regex = re.compile("REGISTER_TEST_COMMAND\s*\(\s*([a-z0-9_]+)")
+non_suite_regex = re.compile(r"REGISTER_TEST_COMMAND\s*\(\s*([a-z0-9_]+)")
non_suite_tests = []
def get_fast_test_params(test_name, ln):
--
2.47.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] buildtools: clear out regex syntax warnings
2024-12-13 14:40 ` [PATCH v2 1/1] " Ariel Otilibili
@ 2024-12-13 16:41 ` Robin Jarry
0 siblings, 0 replies; 9+ messages in thread
From: Robin Jarry @ 2024-12-13 16:41 UTC (permalink / raw)
To: Ariel Otilibili, dev; +Cc: Thomas Monjalon, David Marchand, stable
Ariel Otilibili, Dec 13, 2024 at 15:40:
> * invalid escape sequences now generate SyntaxWarning
> * therefore changed syntax to raw string noration.
>
> Link: https://docs.python.org/3/library/re.html#module-re
> Fixes: 0aeaf75df87 ("test: define unit tests suites based on test types")
> Fixes: 25065ef1f6c ("test: emit warning for orphaned tests")
> Cc: stable@dpdk.org
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> ---
Acked-by: Robin Jarry <rjarry@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-12-17 8:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-08 2:25 [PATCH 0/1] buildtools: clear out regex syntax warnings Ariel Otilibili
2024-12-08 2:25 ` [PATCH 1/1] " Ariel Otilibili
2024-12-13 14:07 ` Robin Jarry
2024-12-13 14:11 ` Ariel Otilibili-Anieli
2024-12-13 14:15 ` David Marchand
2024-12-13 13:10 ` [PING] " Ariel Otilibili-Anieli
2024-12-13 14:40 ` [PATCH v2 0/1] " Ariel Otilibili
2024-12-13 14:40 ` [PATCH v2 1/1] " Ariel Otilibili
2024-12-13 16:41 ` Robin Jarry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).