From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77BEDA0C41; Wed, 15 Sep 2021 18:48:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63F7841149; Wed, 15 Sep 2021 18:48:29 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 22B944014F for ; Wed, 15 Sep 2021 18:48:26 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="202537868" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="202537868" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:48:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="471003757" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 15 Sep 2021 09:48:26 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:48:24 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:48:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:48:23 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:48:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ki0xXj9Lgu79oH49NRYpBRtZVIYdejTMN66bxZdIzbWypY13vNjBUUzq5yQ8/2e8IyicopGjUUM2v7kJ/Sl4bN+6AyvFn7TGrXTXDq/5k9cRArQ3y6LFYEhIJR/ASRFJhtcPrupcr5Zz9NuWxr/PIpQo8pAl/OIfjNyMO+fCIPmdFagNUt4uE6mxcniw8A/HVCBTpIYN0gJhgoVT3b6VRQyAxL1izGNe0q5vUAF+P06WOxDCPnipxwqVDk/C6YECjXOrIBGQc2Oe6D2aBZgoO/CWSsez6NsB1z20tiSinzCHqbyaIBHhfoK+DvfzUk/tFcUOsKOAXk0PySVSnsD4MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z9c0YQM5C0IXr+k6PjSZShc5wZZEGmzJYPiKKLLLVH0=; b=YjUO4/fW7KvEE789RY+oLTHEr3PATIcKkKxHHn4LInJwfQMs2mUfn+79GrumkQnGkhuGQKbNiT/0JtBoysOTjyMOY1OcO1sg/S/SuQP/yAvhln6PBBoSo89i/CsfogLrYQ6VZhSX4lt3vYZ2m4moRe8xODNkUpM6leN5Yr1D85QazSvjy5KPcrp53VjDg2LqKqvfRUgkHeqTKGdAwUCWpRj/fM/WqxH4faaEkrimlhzicOA0mNj7rTOkquLIxdOfdQNFDDRq+qHgm5coEMyur/QQp9bEJBNIdAr9e/VwX/tsS2/rJubBorWC3VeE7/PU8vYvfAYoFS9B8hPj0ax9+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9c0YQM5C0IXr+k6PjSZShc5wZZEGmzJYPiKKLLLVH0=; b=oEVokJzTqp4YFLFYFZsPdXCHWysY4c59Xg4vvA6Gv6SSVGOqMXzDW8/gVVJHr1eP4WoAXJ2i/54oofKJozLxtbj/BqrOklrgoNhGj2fRIgdAaoUk+uzYL2oOYb7XrZ1IJnl8eRZNju7hoxX49F+IcZ9a+J1IwaYhUH7F8vx754g= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 16:48:22 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:48:22 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-4-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2f8af97b-d0cd-cfe9-60d4-bf5940829925@intel.com> Date: Wed, 15 Sep 2021 17:48:17 +0100 In-Reply-To: <20210908083758.312055-4-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0248.eurprd04.prod.outlook.com (2603:10a6:10:28e::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0248.eurprd04.prod.outlook.com (2603:10a6:10:28e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:48:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e6610f2-c02b-4edc-3f9e-08d97868a0d8 X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p7l7LDFG5+Dp/244xtr8+COS7wMWIzqLIeKBlAgeYU5gyABW+UxsZNzhJbkt/z9hARt26SF4Jg3y25FwWlwtBtSBZ+a0prKn+NqyOXIhNIUzk10+PPluIPkUao2OwGNwB+IODLar+rkzoX/XV4qmD2I03PzoE4bR0pZh0V++KlcG09BfUZykSgTnvAVGqsAThrHxH3h+PgFeVNwZT24AB1FTVlaFOlLZO5xLflYKetzYz5TmJ4C0uxdbw2OOHZ+EFSZrdCKD8FeSUYSmJutv33MCitUCG4woq7iPEt2Q+NGMYsw4/hPWg2/cW5rN+LLC+467DKGEFLxbr4jrSvY7F/Hd5KeTeCp1r6ZMTikzENF9KYDaAkG2Qe+Io+aPb0awEzkcrBvCsEGdWcuqvoE9QHNBM9D5jct6hibjbIZFQtx5s9BX/tACU9GkSqeTTObDnI5p/2ZdT5JJw4JM9xFMAcHRscUtyDEqQKfP7WPhCG6tcvrS31Xr2II9S3DEL36vxN+4BnV/2HVM8k9mPWVgQRd5ZTJBwKzjiQcR8j++7WESH4L57pnQ+9F46TCHHYWkQXtEsjy1/nVKG88vwcTVSQQcYmyXGMxcf3vK9GD25ItvZrOQxq0Fl/B6PILuriscRc0SxybaV6CCbPckmzTI934QeuKBsRkJxiCyIWHTfzH8wNiT9YlMKmlf5wxRnIwEE1L0MCYrzm9vcOl7WYCWJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(478600001)(6486002)(5660300002)(8936002)(36756003)(6666004)(31696002)(86362001)(2616005)(956004)(44832011)(2906002)(38100700002)(66946007)(186003)(66556008)(66476007)(8676002)(83380400001)(316002)(26005)(53546011)(31686004)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0N0dzBvUlg0c2t1Z1VxbCt2dlJCYXUxdEI1QjVqTVRlWUpybys0QitURkNI?= =?utf-8?B?dDljalpPM0sybEl6YzlHcEtLUjFsR2N1WXJGU01XR2YzUGFwQmtaaXhGQ2M1?= =?utf-8?B?eEVVR29rRzk2K3NZYzg3MDVSeEd6R0dpZTcyWG9xNjZCczM4VEVvcmFTbDFG?= =?utf-8?B?bmdTcE9nOGpEbU9PZ0NhbHYxL1VNcDdkMnRGMndhN3JOek13TUhDWE5VOU5i?= =?utf-8?B?OGhHQW5zZ2pCN2dHSnBTOGNxTlk4RjFKRjdkc0xIVHgrUm1iUnQyNGRlYTlw?= =?utf-8?B?K3J4UjB4N1Jnd2VxbS9NbjRzVjRTUFJKQ3BZOWJQdVpaVnovSDRBSkRvaUNC?= =?utf-8?B?RGpMT0Q5VWxmTHVNb25sVC9nTndVV0NCcU5jZHFLN2wrZnBIa0dpUmdJZ2pZ?= =?utf-8?B?NTRlekpoTG5jOXpFMDI0UFROTkprQVptUldtSUlzNDcwOWU0Q29pUGJrenI3?= =?utf-8?B?ZTdxOGpmaUxuM0U0WGwydDFvRm1QNUIxV0ZyY2xuR0g1K2QvNUJBNUVtTzZL?= =?utf-8?B?czBsaXRmQ1JpMTNoT1dPKzN4bmMzWkxBYnJtOE8vaGpUMDNjc3hUbHYrd0Fi?= =?utf-8?B?dDZpd1U4SjJJb3NzVFhidWNqN0t4OHBVZ1IwVXBzRU9RNlhDNm5QSGNQQUpW?= =?utf-8?B?NVBPc1FTVHJVZURYb2w5UHNKNlZhUnZ2emZZbkVtdG5nNTdmZUlhSXlHUTh1?= =?utf-8?B?OG1Wc0ZNalRuTUhpR3FVWGNHNjIwSmdlZlRubmRCdEtJVGYvK2hYTDRoOWhn?= =?utf-8?B?OWlRQzFPQVFzL2pTR1hFYTgzay9MZ3U5Tk1hZ0EvSnhTRENpdFNuK3o3eDRJ?= =?utf-8?B?SkVIK3YxTjRjY251R3pHSHB6ZTU3RlNJOWE0Zk81S2xKL3ZScGg1NWlQci9s?= =?utf-8?B?dnlwNjZUSEdyTm9jM2RQYUlZL0FCZ0hVYTRxeGFyOVVaOVAvZ2xkcEpSQWh0?= =?utf-8?B?blVlZTZJSWVvdWp5MXhjU3ZtekRUWmRpT2Q0YVpBR00zYjYxemNFQk4yZkRS?= =?utf-8?B?VTE5ejhrY1o4MTFFeW5Oa2hzNHNpWitmbUtHL2FLSmU2dHNlNWgyZk11d3Jp?= =?utf-8?B?andRVUhMSGlwa0paeGVPZkdwVlZkSTFoMEN4bnhMY1JidzVUQ0wxa3J5MThC?= =?utf-8?B?dTIwaUtBWkI5MjBDOUorUWtzMCtaT0ZnQ002YWpuNmg1eUkyM25UTHR2NXo2?= =?utf-8?B?L3puVnV3VzZFVE5jdTBUditkS2NZWFE2aWY1T1ZnOEl3MWVLNVcvQyt5MU1F?= =?utf-8?B?VWRUd3IwUnFSNERHalJPclVuVTFWcWYzZTFyV3ZEcHYvYU1iNHB2ajhHbm44?= =?utf-8?B?WlBxTHNsTnVYODAwRDc4ODRMNXczZGV6bWQySC9EUTBUaXhBNjh5NERwc05t?= =?utf-8?B?VEJRRmE5TVVub3U5enArN1pFbWdtSjFxOHlWMGRpclFxMUZpeE80UmJEbGVO?= =?utf-8?B?SDV0Q205Y3pmNlpGQ2JaQVBYSmRrMTEwWUo1U3ZmNVlJV3U3bStIWm1uQUhz?= =?utf-8?B?UHkwQS9XdXV3dE1yc2dpUmcyYVNVM2F4bHhFVGtrOHZIbkRIUis5RDZRS25G?= =?utf-8?B?NzhGZDExODlHY0xES2lybHN1V2RRQWZIVWNGMU12dnJuSldrQkIxVXM3d3Uw?= =?utf-8?B?Z3JZU2VMR0xzdGhaOUlvMUNmQjJJNGVXNi95UzNHdDE3eHhuSW8wUWhFNWE1?= =?utf-8?B?L3VPb3RCMDB4ays2dzNhZWkxN1FoRCtucW1GWVpZS251OWtvK0Fjc2NFckN5?= =?utf-8?Q?GNw7SiAKVKCUTutgSgJwpVWnoFxuisN2VbOmgsJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e6610f2-c02b-4edc-3f9e-08d97868a0d8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:48:22.2045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AhiuDazYp7nMrRjVdb1DDZdSsb3eA0VlBUTuKMbTQgK69g5+sLmjdNkqnmx1G9GyLnROel+3j/QQr9TzNArz5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 03/32] net/ngbe: support Rx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support IP/L4 checksum on Rx, and convert it to mbuf flags. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 2 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 75 +++++++++++++++++++++++++++++-- > 3 files changed, 75 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini > index f85754eb7a..2777ed5a62 100644 > --- a/doc/guides/nics/features/ngbe.ini > +++ b/doc/guides/nics/features/ngbe.ini > @@ -9,6 +9,8 @@ Link status = Y > Link status event = Y > Queue start/stop = Y > Scattered Rx = Y > +L3 checksum offload = P > +L4 checksum offload = P Why partially supported? Can you please details in the commit log. <...> > +static inline uint64_t > +rx_desc_error_to_pkt_flags(uint32_t rx_status) > +{ > + uint64_t pkt_flags = 0; > + > + /* checksum offload can't be disabled */ > + if (rx_status & NGBE_RXD_STAT_IPCS) { > + pkt_flags |= (rx_status & NGBE_RXD_ERR_IPCS > + ? PKT_RX_IP_CKSUM_BAD : PKT_RX_IP_CKSUM_GOOD); > + } > + > + if (rx_status & NGBE_RXD_STAT_L4CS) { > + pkt_flags |= (rx_status & NGBE_RXD_ERR_L4CS > + ? PKT_RX_L4_CKSUM_BAD : PKT_RX_L4_CKSUM_GOOD); > + } > + > + if (rx_status & NGBE_RXD_STAT_EIPCS && > + rx_status & NGBE_RXD_ERR_EIPCS) { You can join both lines and can drop the {} for the single line if block.